From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ijc+uboot@hellion.org.uk>
Date: Mon, 22 Jun 2015 17:11:17 +0100
Subject: [U-Boot] [PATCH 1/3] sunxi: musb: Improve output during probing
In-Reply-To: <55882C3B.9010709@redhat.com>
References: <1434814509-21484-1-git-send-email-hdegoede@redhat.com>
 <1434814509-21484-2-git-send-email-hdegoede@redhat.com>
 <1434873606.17598.2.camel@hellion.org.uk> <55882C3B.9010709@redhat.com>
Message-ID: <1434989477.28264.176.camel@hellion.org.uk>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Mon, 2015-06-22 at 17:39 +0200, Hans de Goede wrote:
> How about the following:
> 
> 
> Subject: [PATCH 1/3] sunxi: musb: Improve output during probing
> 
> When we return an error the usb core will log a message, so in this case
> do not print anything.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Much better, especially given the below.

Acked-by: Ian Campbell <ian.campbell@citrix.com>

> 
> --- a/drivers/usb/musb-new/sunxi.c
> +++ b/drivers/usb/musb-new/sunxi.c
> @@ -301,21 +301,22 @@ int musb_usb_probe(struct udevice *dev)
>   {
>          struct musb_host_data *host = dev_get_priv(dev);
>          struct usb_bus_priv *priv = dev_get_uclass_priv(dev);
> +       int ret;

Wrong sort of w/space I suspect.

[...]
> This is exactly what the other host drivers do, only print
> something on success, and leave printing errors up to the
> caller.

If all others do this I think doing this is the best compromise too.

Ian.