From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 7/8] mtd/nand/ubi: assortment of alignment fixes
Date: Wed, 8 Jul 2015 18:25:33 -0500 [thread overview]
Message-ID: <1436397933.2658.88.camel@freescale.com> (raw)
In-Reply-To: <fb7ecceadecacd4498ca27ac2481252bffc4a36e.1436175196.git.marcel.ziswiler@toradex.com>
On Wed, 2015-07-08 at 13:58 +0200, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> Various U-Boot adoptions/extensions to MTD/NAND/UBI did not take buffer
> alignment into account which led to failures of the following form:
>
> ERROR: v7_dcache_inval_range - start address is not aligned - 0x1f7f0108
> ERROR: v7_dcache_inval_range - stop address is not aligned - 0x1f7f1108
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> ---
> Changes in v2: run it through checkpatch.pl and fix long lines
>
> common/cmd_ubi.c | 2 +-
> drivers/mtd/nand/nand_util.c | 2 +-
> fs/ubifs/super.c | 6 ++++--
> fs/ubifs/ubifs.c | 5 +++--
> lib/gzip.c | 2 +-
> 5 files changed, 10 insertions(+), 7 deletions(-)
As per discussion on v1, this isn't enough to guarantee that the stop address
will be aligned. There needs to be a wrapper around memalign() that cache-
aligns the size as well.
-Scott
next prev parent reply other threads:[~2015-07-08 23:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 11:58 [U-Boot] [PATCH v2 0/8] assortment of fixes/enhancements Marcel Ziswiler
2015-07-08 11:58 ` [U-Boot] [PATCH v2 1/8] fs/fs.c: read up to EOF when len would read past EOF Marcel Ziswiler
2015-07-08 11:58 ` [U-Boot] [PATCH v2 2/8] net: asix: fix operation without eeprom Marcel Ziswiler
2015-07-08 12:46 ` Marek Vasut
2015-07-08 11:58 ` [U-Boot] [PATCH v2 3/8] generic-board: allow showing custom board info Marcel Ziswiler
2015-07-08 14:10 ` Simon Glass
2015-07-08 11:58 ` [U-Boot] [PATCH v2 4/8] logos: add Toradex logo Marcel Ziswiler
2015-07-08 11:58 ` [U-Boot] [PATCH v2 5/8] colibri_vf: remove spurious new line Marcel Ziswiler
2015-07-08 11:58 ` [U-Boot] [PATCH v2 6/8] image-fdt.c: store returned error value Marcel Ziswiler
2015-07-08 11:58 ` [U-Boot] [PATCH v2 7/8] mtd/nand/ubi: assortment of alignment fixes Marcel Ziswiler
2015-07-08 14:10 ` Simon Glass
2015-07-08 23:25 ` Scott Wood [this message]
2015-07-09 7:47 ` Marcel Ziswiler
2015-07-09 20:32 ` Scott Wood
2015-07-08 11:58 ` [U-Boot] [PATCH v2 8/8] tftp.c: fix CONFIG_TFTP_TSIZE for small files Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436397933.2658.88.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox