public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marcel Ziswiler <marcel@ziswiler.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 7/8] mtd/nand/ubi: assortment of alignment fixes
Date: Thu, 09 Jul 2015 09:47:56 +0200	[thread overview]
Message-ID: <1436428076.2953.14.camel@localhost.localdomain> (raw)
In-Reply-To: <1436397933.2658.88.camel@freescale.com>

Hi Scott

On Wed, 2015-07-08 at 18:25 -0500, Scott Wood wrote:
>
> As per discussion on v1, this isn't enough to guarantee that the stop address 
> will be aligned.  There needs to be a wrapper around memalign() that cache-
> aligns the size as well.
> 
> -Scott

Sorry, that isn't quite clear to me yet. You're saying I would need to
handle that in this patch?

Looking through the sources I actually found only one single usage of
memalign() which explicitly takes care of this the way you propose:

drivers/usb/host/xhci-mem.c:	ptr = memalign(cacheline_size, ALIGN(size,
cacheline_size));

I'm just wondering about the 107 other places in U-Boot where memalign()
is already used the way I do in this patch.

Wouldn't there need to be an infrastructure solution done to e.g.
memalign() itself?

Cheers

Marcel

  reply	other threads:[~2015-07-09  7:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-08 11:58 [U-Boot] [PATCH v2 0/8] assortment of fixes/enhancements Marcel Ziswiler
2015-07-08 11:58 ` [U-Boot] [PATCH v2 1/8] fs/fs.c: read up to EOF when len would read past EOF Marcel Ziswiler
2015-07-08 11:58 ` [U-Boot] [PATCH v2 2/8] net: asix: fix operation without eeprom Marcel Ziswiler
2015-07-08 12:46   ` Marek Vasut
2015-07-08 11:58 ` [U-Boot] [PATCH v2 3/8] generic-board: allow showing custom board info Marcel Ziswiler
2015-07-08 14:10   ` Simon Glass
2015-07-08 11:58 ` [U-Boot] [PATCH v2 4/8] logos: add Toradex logo Marcel Ziswiler
2015-07-08 11:58 ` [U-Boot] [PATCH v2 5/8] colibri_vf: remove spurious new line Marcel Ziswiler
2015-07-08 11:58 ` [U-Boot] [PATCH v2 6/8] image-fdt.c: store returned error value Marcel Ziswiler
2015-07-08 11:58 ` [U-Boot] [PATCH v2 7/8] mtd/nand/ubi: assortment of alignment fixes Marcel Ziswiler
2015-07-08 14:10   ` Simon Glass
2015-07-08 23:25   ` Scott Wood
2015-07-09  7:47     ` Marcel Ziswiler [this message]
2015-07-09 20:32       ` Scott Wood
2015-07-08 11:58 ` [U-Boot] [PATCH v2 8/8] tftp.c: fix CONFIG_TFTP_TSIZE for small files Marcel Ziswiler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436428076.2953.14.camel@localhost.localdomain \
    --to=marcel@ziswiler.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox