From: Paul Kocialkowski <contact@paulk.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] am33xx: CONFIG_REVISION_TAG ifdef check for get_board_rev
Date: Thu, 16 Jul 2015 15:31:33 +0200 [thread overview]
Message-ID: <1437053493.2246.1.camel@aldrin> (raw)
In-Reply-To: <20150716132045.GU25532@bill-the-cat>
Le jeudi 16 juillet 2015 ? 09:20 -0400, Tom Rini a ?crit :
> On Thu, Jul 16, 2015 at 03:10:21PM +0200, Paul Kocialkowski wrote:
>
> > Despite being defined with __weak, this declaration of get_board_rev will
> > conflict with the fallback one when ONFIG_REVISION_TAG is not defined.
> >
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
>
> There is no support for am33xx boards and Linux-kernel board-file kernels
> so lets just drop this weak default one and let boards that must have
> this for various reasons implement a real one.
That's right, we can actually simply remove the whole function. If
that's okay, I'll just send another patch that replaces 2/2 and 1/2
should still be good for merging without another iteration.
Thanks for the review!
--
Paul Kocialkowski, Replicant developer
Replicant is a fully free Android distribution running on several
devices, a free software mobile operating system putting the emphasis on
freedom and privacy/security.
Website: http://www.replicant.us/
Blog: http://blog.replicant.us/
Wiki/tracker/forums: http://redmine.replicant.us/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150716/27270b78/attachment.sig>
next prev parent reply other threads:[~2015-07-16 13:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 13:10 [U-Boot] [PATCH 1/2] omap3: CONFIG_REVISION_TAG ifdef check for get_board_rev Paul Kocialkowski
2015-07-16 13:10 ` [U-Boot] [PATCH 2/2] am33xx: " Paul Kocialkowski
2015-07-16 13:20 ` Tom Rini
2015-07-16 13:31 ` Paul Kocialkowski [this message]
2015-07-16 13:21 ` [U-Boot] [PATCH 1/2] omap3: " Tom Rini
2015-07-26 16:31 ` Paul Kocialkowski
2015-07-28 14:59 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437053493.2246.1.camel@aldrin \
--to=contact@paulk.fr \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox