From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Kocialkowski Date: Thu, 16 Jul 2015 15:31:33 +0200 Subject: [U-Boot] [PATCH 2/2] am33xx: CONFIG_REVISION_TAG ifdef check for get_board_rev In-Reply-To: <20150716132045.GU25532@bill-the-cat> References: <1437052221-11040-1-git-send-email-contact@paulk.fr> <1437052221-11040-2-git-send-email-contact@paulk.fr> <20150716132045.GU25532@bill-the-cat> Message-ID: <1437053493.2246.1.camel@aldrin> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le jeudi 16 juillet 2015 ? 09:20 -0400, Tom Rini a ?crit : > On Thu, Jul 16, 2015 at 03:10:21PM +0200, Paul Kocialkowski wrote: > > > Despite being defined with __weak, this declaration of get_board_rev will > > conflict with the fallback one when ONFIG_REVISION_TAG is not defined. > > > > Signed-off-by: Paul Kocialkowski > > There is no support for am33xx boards and Linux-kernel board-file kernels > so lets just drop this weak default one and let boards that must have > this for various reasons implement a real one. That's right, we can actually simply remove the whole function. If that's okay, I'll just send another patch that replaces 2/2 and 1/2 should still be good for merging without another iteration. Thanks for the review! -- Paul Kocialkowski, Replicant developer Replicant is a fully free Android distribution running on several devices, a free software mobile operating system putting the emphasis on freedom and privacy/security. Website: http://www.replicant.us/ Blog: http://blog.replicant.us/ Wiki/tracker/forums: http://redmine.replicant.us/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: This is a digitally signed message part URL: