* [U-Boot] [PATCH] Kill unneeded #include <linux/kconfig.h>
@ 2015-07-17 8:28 Masahiro Yamada
2015-07-17 9:05 ` Ian Campbell
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2015-07-17 8:28 UTC (permalink / raw)
To: u-boot
Because the top-level Makefile forces all the source files
to include include/linux/kconfig (see the UBOOTINCLUDE define),
these includes are redundant.
By the way, there are exceptions for the statement above; host
programs. In fact, host tools in U-Boot depend on a particular
board configuration, although I think they should not. So, some
files still include <linux/config.h> to work around build errors
on host tools.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/arm/cpu/armv7/sunxi/dram_sun8i_a23.c | 1 -
arch/arm/cpu/armv7/sunxi/dram_sun8i_a33.c | 1 -
arch/x86/cpu/ivybridge/gma.c | 1 -
board/sunxi/dram_sun4i_auto.c | 1 -
board/sunxi/dram_sun5i_auto.c | 1 -
5 files changed, 5 deletions(-)
diff --git a/arch/arm/cpu/armv7/sunxi/dram_sun8i_a23.c b/arch/arm/cpu/armv7/sunxi/dram_sun8i_a23.c
index 165c052..c53671a 100644
--- a/arch/arm/cpu/armv7/sunxi/dram_sun8i_a23.c
+++ b/arch/arm/cpu/armv7/sunxi/dram_sun8i_a23.c
@@ -26,7 +26,6 @@
#include <asm/arch/clock.h>
#include <asm/arch/dram.h>
#include <asm/arch/prcm.h>
-#include <linux/kconfig.h>
static const struct dram_para dram_para = {
.clock = CONFIG_DRAM_CLK,
diff --git a/arch/arm/cpu/armv7/sunxi/dram_sun8i_a33.c b/arch/arm/cpu/armv7/sunxi/dram_sun8i_a33.c
index ebba438..fa1620c 100644
--- a/arch/arm/cpu/armv7/sunxi/dram_sun8i_a33.c
+++ b/arch/arm/cpu/armv7/sunxi/dram_sun8i_a33.c
@@ -14,7 +14,6 @@
#include <asm/arch/clock.h>
#include <asm/arch/dram.h>
#include <asm/arch/prcm.h>
-#include <linux/kconfig.h>
/* PLL runs at 2x dram-clk, controller runs at PLL / 4 (dram-clk / 2) */
#define DRAM_CLK_MUL 2
diff --git a/arch/x86/cpu/ivybridge/gma.c b/arch/x86/cpu/ivybridge/gma.c
index ea169b0..89d4a5e 100644
--- a/arch/x86/cpu/ivybridge/gma.c
+++ b/arch/x86/cpu/ivybridge/gma.c
@@ -16,7 +16,6 @@
#include <asm/pci.h>
#include <asm/arch/pch.h>
#include <asm/arch/sandybridge.h>
-#include <linux/kconfig.h>
struct gt_powermeter {
u16 reg;
diff --git a/board/sunxi/dram_sun4i_auto.c b/board/sunxi/dram_sun4i_auto.c
index 149bb51..7d4409b 100644
--- a/board/sunxi/dram_sun4i_auto.c
+++ b/board/sunxi/dram_sun4i_auto.c
@@ -1,6 +1,5 @@
#include <common.h>
#include <asm/arch/dram.h>
-#include <linux/kconfig.h>
static struct dram_para dram_para = {
.clock = CONFIG_DRAM_CLK,
diff --git a/board/sunxi/dram_sun5i_auto.c b/board/sunxi/dram_sun5i_auto.c
index 596a206..e3fa243 100644
--- a/board/sunxi/dram_sun5i_auto.c
+++ b/board/sunxi/dram_sun5i_auto.c
@@ -2,7 +2,6 @@
#include <common.h>
#include <asm/arch/dram.h>
-#include <linux/kconfig.h>
static struct dram_para dram_para = {
.clock = CONFIG_DRAM_CLK,
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] Kill unneeded #include <linux/kconfig.h>
2015-07-17 8:28 [U-Boot] [PATCH] Kill unneeded #include <linux/kconfig.h> Masahiro Yamada
@ 2015-07-17 9:05 ` Ian Campbell
0 siblings, 0 replies; 2+ messages in thread
From: Ian Campbell @ 2015-07-17 9:05 UTC (permalink / raw)
To: u-boot
On Fri, 2015-07-17 at 17:28 +0900, Masahiro Yamada wrote:
> Because the top-level Makefile forces all the source files
> to include include/linux/kconfig (see the UBOOTINCLUDE define),
> these includes are redundant.
>
> By the way, there are exceptions for the statement above; host
> programs. In fact, host tools in U-Boot depend on a particular
> board configuration, although I think they should not. So, some
> files still include <linux/config.h> to work around build errors
> on host tools.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Assuming you have build tested for sunxi then for the sunxi bits:
Acked-by: Ian Campbell <ijc@hellion.org.uk>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-17 9:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-17 8:28 [U-Boot] [PATCH] Kill unneeded #include <linux/kconfig.h> Masahiro Yamada
2015-07-17 9:05 ` Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox