From: Ian Campbell <ijc+uboot@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/5] sunxi: display: Replace #ifdef-ery with helper functions
Date: Wed, 05 Aug 2015 08:53:47 +0100 [thread overview]
Message-ID: <1438761227.18644.46.camel@hellion.org.uk> (raw)
In-Reply-To: <1438638870-3728-1-git-send-email-hdegoede@redhat.com>
On Mon, 2015-08-03 at 23:54 +0200, Hans de Goede wrote:
> All the #ifdef-ery in selecting the default and fallback monitor type
> is
> becoming unyielding and makes the code hard to read, replace it with
> a few
> helper functions.
>
> This will also be useful with the upcoming CHIP board which has
> display
> adapter daughterboards which should be runtime detectable.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
I couldn't quite convince myself there was "no semantic change" here,
but either way it's an improvement so:
Acked-by: Ian Campbell <ijc@hellion.org.uk>
prev parent reply other threads:[~2015-08-05 7:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 21:54 [U-Boot] [PATCH 1/5] sunxi: display: Replace #ifdef-ery with helper functions Hans de Goede
2015-08-03 21:54 ` [U-Boot] [PATCH 2/5] sunxi: display: Correct clk_delay calculations for lcd displays Hans de Goede
2015-08-05 7:54 ` Ian Campbell
2015-08-03 21:54 ` [U-Boot] [PATCH 3/5] sunxi: display: Add a few extra register and constant defines Hans de Goede
2015-08-05 7:57 ` Ian Campbell
2015-08-05 15:09 ` Hans de Goede
2015-08-03 21:54 ` [U-Boot] [PATCH 4/5] sunxi: display: Add support for interlaced modes Hans de Goede
2015-08-05 8:05 ` Ian Campbell
2015-08-05 15:13 ` Hans de Goede
2015-08-03 21:54 ` [U-Boot] [PATCH 5/5] sunxi: display: Add composite video out support Hans de Goede
2015-08-05 8:07 ` Ian Campbell
2015-08-05 7:53 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438761227.18644.46.camel@hellion.org.uk \
--to=ijc+uboot@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox