From: Marcel Ziswiler <marcel@ziswiler.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, RESEND, v5] mtd/nand/ubi: assortment of alignment fixes
Date: Thu, 13 Aug 2015 09:52:35 +0200 [thread overview]
Message-ID: <1439452355.3530.13.camel@ziswiler.com> (raw)
In-Reply-To: <20150812194318.GP25532@bill-the-cat>
On Wed, 2015-08-12 at 15:43 -0400, Tom Rini wrote:
> On Wed, Aug 05, 2015 at 05:17:04PM +0200, Marcel Ziswiler wrote:
>
> > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >
> > Various U-Boot adoptions/extensions to MTD/NAND/UBI did not take
> > buffer
> > alignment into account which led to failures of the following form:
> >
> > ERROR: v7_dcache_inval_range - start address is not aligned -
> > 0x1f7f0108
> > ERROR: v7_dcache_inval_range - stop address is not aligned -
> > 0x1f7f1108
> >
> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > Reviewed-by: Simon Glass <sjg@chromium.org>
> > Acked-by: Scott Wood <scottwood@freescale.com>
>
> This change causes a huge number of boards to fail to build due to
> some
> hidden #define games. The actual error message doesn't provide
> helpful
> context but building for say "spear300" will show the problem.
Uups, I see your point. I guess one should not include regular header
files like malloc.h in assembler .S files (;-p). I will send a v6 which
will wrap my wrapper in __ASSEMBLY__ which fixes this.
> Thanks!
You are very welcome.
next prev parent reply other threads:[~2015-08-13 7:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 15:16 [U-Boot] [RESEND PATCH v5] fs/fs.c: read up to EOF when len would read past EOF Marcel Ziswiler
2015-08-05 15:16 ` [U-Boot] [RESEND PATCH v5] net: asix: fix operation without eeprom Marcel Ziswiler
2015-08-05 15:20 ` Marek Vasut
2015-08-05 15:17 ` [U-Boot] [RESEND PATCH v5] generic-board: allow showing custom board info Marcel Ziswiler
2015-08-13 13:23 ` [U-Boot] [U-Boot, RESEND, " Tom Rini
2015-08-05 15:17 ` [U-Boot] [RESEND PATCH v5] logos: add Toradex logo Marcel Ziswiler
2015-08-13 13:16 ` Tom Rini
2015-08-05 15:17 ` [U-Boot] [RESEND PATCH v5] colibri_vf: remove spurious new line Marcel Ziswiler
2015-08-13 13:23 ` [U-Boot] [U-Boot, RESEND, " Tom Rini
2015-08-05 15:17 ` [U-Boot] [RESEND PATCH v5] image-fdt.c: store returned error value Marcel Ziswiler
2015-08-13 13:23 ` [U-Boot] [U-Boot, RESEND, " Tom Rini
2015-08-05 15:17 ` [U-Boot] [RESEND PATCH v5] mtd/nand/ubi: assortment of alignment fixes Marcel Ziswiler
2015-08-12 19:43 ` [U-Boot] [U-Boot, RESEND, " Tom Rini
2015-08-13 7:52 ` Marcel Ziswiler [this message]
2015-08-05 15:17 ` [U-Boot] [RESEND PATCH v5] tftp.c: fix CONFIG_TFTP_TSIZE for small files Marcel Ziswiler
2015-08-11 16:16 ` Joe Hershberger
2015-08-12 19:29 ` Joe Hershberger
2015-08-13 13:23 ` [U-Boot] [U-Boot, RESEND, v5] fs/fs.c: read up to EOF when len would read past EOF Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439452355.3530.13.camel@ziswiler.com \
--to=marcel@ziswiler.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox