From: Marcel Ziswiler <marcel@ziswiler.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 4/5] dm9000: dm9000_initialize stub
Date: Sun, 16 Aug 2015 03:15:46 +0200 [thread overview]
Message-ID: <1439687746.4218.31.camel@ziswiler.com> (raw)
In-Reply-To: <1439686300.4218.17.camel@ziswiler.com>
On Sun, 2015-08-16 at 02:51 +0200, Marcel Ziswiler wrote:
> On Wed, 2015-08-12 at 12:24 -0500, Andrew Ruder wrote:
>
> Just one nitty-gritty detail:
>
> > diff --git a/include/configs/colibri_pxa270.h
> > b/include/configs/colibri_pxa270.h
> > index e3f0ab0..e7db8cf 100644
> > --- a/include/configs/colibri_pxa270.h
> > +++ b/include/configs/colibri_pxa270.h
> > @@ -67,6 +67,7 @@
> > #define CONFIG_DM9000_BASE 0x08000000
> > #define DM9000_IO (CONFIG_DM9000_BASE)
> > #define DM9000_DATA (CONFIG_DM9000_BASE +
> > 4)
> > +#define DM9000_HAS_SROM 1
>
> Colibri PXA270 do not actually have any SROM so this should be
> defined
> to 0 instead.
>
> > #define CONFIG_NET_RETRY_COUNT 10
>
> Otherwise for the whole series.
>
> Signed-off-by: Marcel Ziswiler <marcel@ziswiler.com>
This should of course have been an Acked-by, sorry. Will by you some
Guinness in Dublin (;-p).
> Tested-by: Marcel Ziswiler <marcel@ziswiler.com>
> Tested-on: Colibri PXA270 V1.2C, V1.2D, V2.2B, V2.4A on Colibri
> Evaluation Board V3.1A
> Note: I only tested the one default on-module Ethernet instance and
> while it all still works OK it feels like the transfer speed is
> slightly lower (e.g. from the previous 1.3 MiB/s I now get 1.2
> MiB/s).
next prev parent reply other threads:[~2015-08-16 1:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 17:24 [U-Boot] [PATCH V2 0/5] DM9000 support for multiple interfaces Andrew Ruder
2015-08-12 17:24 ` [U-Boot] [PATCH V2 1/5] dm9000: whitespace cleanups Andrew Ruder
2015-08-12 19:07 ` Joe Hershberger
2015-08-12 17:24 ` [U-Boot] [PATCH V2 2/5] dm9000: mark dump_regs() function as unused Andrew Ruder
2015-08-12 19:07 ` Joe Hershberger
2015-08-12 17:24 ` [U-Boot] [PATCH V2 3/5] dm9000: Add struct eth_device * to SROM functions Andrew Ruder
2015-08-12 19:07 ` Joe Hershberger
2015-08-21 11:25 ` Andrew Ruder
2015-08-21 15:56 ` Joe Hershberger
2015-08-12 17:24 ` [U-Boot] [PATCH V2 4/5] dm9000: dm9000_initialize stub Andrew Ruder
2015-08-12 19:07 ` Joe Hershberger
2015-08-16 0:51 ` Marcel Ziswiler
2015-08-16 1:15 ` Marcel Ziswiler [this message]
2015-08-12 17:24 ` [U-Boot] [PATCH V2 5/5] dm9000: rework dm9000 to support multiple devices Andrew Ruder
2015-08-12 19:07 ` Joe Hershberger
2015-08-12 17:50 ` [U-Boot] [PATCH V2 0/5] DM9000 support for multiple interfaces Andrew Ruder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439687746.4218.31.camel@ziswiler.com \
--to=marcel@ziswiler.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox