From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ijc@hellion.org.uk>
Date: Mon, 17 Aug 2015 09:19:36 +0100
Subject: [U-Boot] [PATCH 04/15] sunxi_nand_spl: Do not bother writing
 the spare-area reg in syndrome mode
In-Reply-To: <1439668968-3882-5-git-send-email-hdegoede@redhat.com>
References: <1439668968-3882-1-git-send-email-hdegoede@redhat.com>
 <1439668968-3882-5-git-send-email-hdegoede@redhat.com>
Message-ID: <1439799576.3480.55.camel@hellion.org.uk>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Sat, 2015-08-15 at 22:02 +0200, Hans de Goede wrote:
> In syndrome mode we set the NFC_SEQ bit in the command register, so the
> spare-area register is not used. Also the value currently being written is
> actual wrong, the ecc sits at "column + CONFIG_NAND_SUNXI_SPL_ECC_PAGE_SIZE"
> not just CONFIG_NAND_SUNXI_SPL_ECC_PAGE_SIZE.
> 
> So the current code only serves to confuse the user -> remove it.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

There's a bunch of other uses of the syndrome parameter in this
function. Does syndrome=true work even without this particular bit of
code?

I suppose I'm asking, should the paramter and the other uses be
removed? Or should an ASSERT(!syndrome) be added, or am I worrying
about nothing and everything is just fine as it is after this patch?

I suspect the latter, so if that is indeed the case:
    Acked-by: Ian Campbell <    ijc@hellion.org.uk    >