public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jagan Teki <jteki@openedev.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/7] sf: Make BAR discovery, as spi_flash_read_bar
Date: Mon, 17 Aug 2015 16:02:50 +0530	[thread overview]
Message-ID: <1439807574-26767-4-git-send-email-jteki@openedev.com> (raw)
In-Reply-To: <1439807574-26767-1-git-send-email-jteki@openedev.com>

Add spi_flash_read_bar function for reading bar and discovering
bar commands at probe time.

Signed-off-by: Jagan Teki <jteki@openedev.com>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
---
 drivers/mtd/spi/sf_probe.c | 54 ++++++++++++++++++++++++++++++----------------
 1 file changed, 35 insertions(+), 19 deletions(-)

diff --git a/drivers/mtd/spi/sf_probe.c b/drivers/mtd/spi/sf_probe.c
index e0283dc..0483bed 100644
--- a/drivers/mtd/spi/sf_probe.c
+++ b/drivers/mtd/spi/sf_probe.c
@@ -99,6 +99,37 @@ static int spi_flash_set_qeb(struct spi_flash *flash, u8 idcode0)
 	}
 }
 
+#ifdef CONFIG_SPI_FLASH_BAR
+static int spi_flash_read_bank(struct spi_flash *flash, u8 idcode0)
+{
+	u8 curr_bank = 0;
+	int ret;
+
+	if (flash->size <= SPI_FLASH_16MB_BOUN)
+		goto bank_end;
+
+	switch (idcode0) {
+	case SPI_FLASH_CFI_MFR_SPANSION:
+		flash->bank_read_cmd = CMD_BANKADDR_BRRD;
+		flash->bank_write_cmd = CMD_BANKADDR_BRWR;
+	default:
+		flash->bank_read_cmd = CMD_EXTNADDR_RDEAR;
+		flash->bank_write_cmd = CMD_EXTNADDR_WREAR;
+	}
+
+	ret = spi_flash_read_common(flash, &flash->bank_read_cmd, 1,
+				    &curr_bank, 1);
+	if (ret) {
+		debug("SF: fail to read bank addr register\n");
+		return ret;
+	}
+
+bank_end:
+	flash->bank_curr = curr_bank;
+	return 0;
+}
+#endif
+
 static int spi_flash_validate_params(struct spi_slave *spi, u8 *idcode,
 				     struct spi_flash *flash)
 {
@@ -106,6 +137,7 @@ static int spi_flash_validate_params(struct spi_slave *spi, u8 *idcode,
 	u8 cmd;
 	u16 jedec = idcode[1] << 8 | idcode[2];
 	u16 ext_jedec = idcode[3] << 8 | idcode[4];
+	int ret;
 
 	/* Validate params from spi_flash_params table */
 	params = spi_flash_params_table;
@@ -235,25 +267,9 @@ static int spi_flash_validate_params(struct spi_slave *spi, u8 *idcode,
 
 	/* Configure the BAR - discover bank cmds and read current bank */
 #ifdef CONFIG_SPI_FLASH_BAR
-	u8 curr_bank = 0;
-	if (flash->size > SPI_FLASH_16MB_BOUN) {
-		int ret;
-
-		flash->bank_read_cmd = (idcode[0] == 0x01) ?
-					CMD_BANKADDR_BRRD : CMD_EXTNADDR_RDEAR;
-		flash->bank_write_cmd = (idcode[0] == 0x01) ?
-					CMD_BANKADDR_BRWR : CMD_EXTNADDR_WREAR;
-
-		ret = spi_flash_read_common(flash, &flash->bank_read_cmd, 1,
-					    &curr_bank, 1);
-		if (ret) {
-			debug("SF: fail to read bank addr register\n");
-			return ret;
-		}
-		flash->bank_curr = curr_bank;
-	} else {
-		flash->bank_curr = curr_bank;
-	}
+	ret = spi_flash_read_bank(flash, idcode[0]);
+	if (ret < 0)
+		return ret;
 #endif
 
 	/* Flash powers up read-only, so clear BP# bits */
-- 
1.9.1

  parent reply	other threads:[~2015-08-17 10:32 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-17 10:32 [U-Boot] [PATCH v2 0/7] BAR/wait_ready logic updates Jagan Teki
2015-08-17 10:32 ` [U-Boot] [PATCH v2 1/7] spi: zynq_spi: Remove unneeded headers Jagan Teki
2015-08-17 10:32 ` [U-Boot] [PATCH v2 2/7] sf: Return proper bank_sel, if flash->bank_curr == bank_sel Jagan Teki
2015-08-17 10:32 ` Jagan Teki [this message]
2015-08-18  7:46   ` [U-Boot] [PATCH v2 3/7] sf: Make BAR discovery, as spi_flash_read_bar Bin Meng
2015-08-18  8:22     ` Jagan Teki
2015-08-17 10:32 ` [U-Boot] [PATCH v2 4/7] sf: Optimize BAR write code Jagan Teki
2015-08-17 10:32 ` [U-Boot] [PATCH v2 5/7] sf: Make flash->flags use for generic usage Jagan Teki
2015-08-18  7:53   ` Bin Meng
2015-08-18  8:31     ` Jagan Teki
2015-08-17 10:32 ` [U-Boot] [PATCH v2 6/7] sf: Update status reg check in spi_flash_cmd_wait_ready Jagan Teki
2015-08-18 22:02   ` Marek Vasut
2015-08-18 22:39     ` Jagan Teki
2015-08-17 10:32 ` [U-Boot] [PATCH v2 7/7] sf: Add FSR support to spi_flash_cmd_wait_ready Jagan Teki
2015-08-18 22:03   ` Marek Vasut
2015-08-18 22:36     ` Jagan Teki
2015-08-18 22:58       ` Marek Vasut
2015-08-19  7:35         ` Jagan Teki
2015-08-19  7:39           ` Marek Vasut
2015-08-19  8:17             ` Jagan Teki
2015-08-19 20:10               ` Marek Vasut
2015-08-18  4:42 ` [U-Boot] [PATCH v2 0/7] BAR/wait_ready logic updates Bin Meng
2015-08-18  5:22   ` Jagan Teki
2015-08-18  7:12     ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439807574-26767-4-git-send-email-jteki@openedev.com \
    --to=jteki@openedev.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox