From: Chin Liang See <clsee@altera.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2] arm: socfpga: mmc: Enable calibration for drvsel and smpsel
Date: Thu, 20 Aug 2015 20:25:00 -0500 [thread overview]
Message-ID: <1440120300.1969.4.camel@clsee-VirtualBox> (raw)
In-Reply-To: <201508210307.38728.marex@denx.de>
On Fri, 2015-08-21 at 03:07 +0200, marex at denx.de wrote:
> On Friday, August 21, 2015 at 02:54:00 AM, Chin Liang See wrote:
> > Hi guys,
>
> Hi,
>
> > Any comment or ack for this patch?
>
> Please don't expect that the reviewers/maintainers have nothing else on
> their plate but to review your patch. Besides, this change is really low
> priority one, since thus far the SD/MMC works fine on all of the SoCFPGA
> boards to my knowledge.
>
> Also, I thought we agreed to wait for Simon to comment on this patch.
> You don't have to repost a patch before the discussion settles a bit.
> This doesn't help, it only puts burden on the receiving side, chill :)
> Let alone the fact that this code should be part of the DWMMC core, as
> it is not socfpga specific.
>
> What I would be really interested in is a proper description of the
> calibration algorithm. What is the goal and how do you achieve it ?
>
Actually I am probing the efforts needed for this patch before moving to
next one. While for the SDMMC calibration, it is not needed if the SD
card is routed near to the chip. We have incident where SD access failed
as they routed few inches away.
With that, let wait for Simon and I shall move on next item.
Thanks
Chin Liang
> Best regards,
> Marek Vasut
next prev parent reply other threads:[~2015-08-21 1:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 7:18 [U-Boot] [PATCH v2 1/2] arm: socfpga: mmc: Enable calibration for drvsel and smpsel Chin Liang See
2015-08-21 0:54 ` Chin Liang See
2015-08-21 1:07 ` Marek Vasut
2015-08-21 1:25 ` Chin Liang See [this message]
2015-08-21 3:03 ` Marek Vasut
2015-08-21 5:00 ` Chin Liang See
2015-08-21 5:21 ` Marek Vasut
2015-08-25 21:01 ` Pavel Machek
2015-08-26 5:43 ` Chin Liang See
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440120300.1969.4.camel@clsee-VirtualBox \
--to=clsee@altera.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox