public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] sunxi_nand_spl: Remove NAND_SUNXI_SPL_SYNDROME_PARTITIONS_END
Date: Mon, 24 Aug 2015 12:02:11 -0500	[thread overview]
Message-ID: <1440435731.30043.26.camel@freescale.com> (raw)
In-Reply-To: <1440267221-22220-2-git-send-email-hdegoede@redhat.com>

On Sat, 2015-08-22 at 20:13 +0200, Hans de Goede wrote:
> We only ever use syndrome mode for the partitions which contain the SPL,
> as that is required for the BROM to be able to read the SPL.
> 
> Instead of using some arbritray limit for deciding whether or not to
> use syndrome, be smart and check if u-boot-dtb.bin is directly behind
> the SPL, if it is not then it is on its own partition and we should not
> use syndrome.
> 
> Note the reason why we only use syndrome mode is because it comes with
> weaker randomization,

"...why we only use syndrome mode for the SPL is because..."

>  introducing a risc for more bit errors, 

risk


> -     int syndrome = offs < CONFIG_NAND_SUNXI_SPL_SYNDROME_PARTITIONS_END;
> -     int i;
> +     int i, syndrome;
> +
> +     if (CONFIG_SYS_NAND_U_BOOT_OFFS == CONFIG_SPL_PAD_TO)
> +             syndrome = 1; /* u-boot-dtb.bin appended to SPL */
> +     else
> +             syndrome = 0; /* u-boot-dtb.bin on its own partition */

Is it not possible for a separate partition to begin at CONFIG_SPL_PAD_TO, or 
would padding not be used in that case?

-Scott

  reply	other threads:[~2015-08-24 17:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-22 18:13 [U-Boot] [PATCH 1/4] sunxi_nand_spl: Rename SPL_NAND_SUNXI to NAND_SUNXI Hans de Goede
2015-08-22 18:13 ` [U-Boot] [PATCH 2/4] sunxi_nand_spl: Remove NAND_SUNXI_SPL_SYNDROME_PARTITIONS_END Hans de Goede
2015-08-24 17:02   ` Scott Wood [this message]
2015-08-25  7:18     ` Hans de Goede
2015-08-26 18:37       ` Ian Campbell
2015-08-22 18:13 ` [U-Boot] [PATCH 3/4] mtd: nand: Make CONFIG_SYS_NAND_U_BOOT_OFFS configurable through Kconfig Hans de Goede
2015-08-26 18:38   ` Ian Campbell
2015-08-26 19:08     ` Scott Wood
2015-08-27 18:04       ` Hans de Goede
2015-08-22 18:13 ` [U-Boot] [PATCH 4/4] sunxi: Add inet97fv2_defconfig Hans de Goede
2015-08-26 18:39   ` Ian Campbell
2015-08-27  8:11     ` Hans de Goede
2015-08-27 20:18       ` Ian Campbell
2015-08-26 18:35 ` [U-Boot] [PATCH 1/4] sunxi_nand_spl: Rename SPL_NAND_SUNXI to NAND_SUNXI Ian Campbell
2015-09-18 11:43 ` [U-Boot] [PATCH 1/4] sunxi_nand_spl: Rename SPL_NAND_SUNXIto NAND_SUNXI Olliver Schinagl
2015-09-18 11:51   ` Olliver Schinagl
2015-09-20 13:09   ` Hans de Goede
2015-09-26 13:01     ` Olliver Schinagl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440435731.30043.26.camel@freescale.com \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox