public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 2/3] mtd: nand: mxs check maximum ecc that platfrom supports
Date: Tue, 25 Aug 2015 16:05:56 -0500	[thread overview]
Message-ID: <1440536756.16577.39.camel@freescale.com> (raw)
In-Reply-To: <1437466521-27856-2-git-send-email-Peng.Fan@freescale.com>

On Tue, 2015-07-21 at 16:15 +0800, Peng Fan wrote:
> Check maximum ecc strength for each platfrom to avoid the calculated ecc
> exceed the limitation.
> 
> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
> Signed-off-by: Han Xu <b45815@freescale.com>
> Reviewed-by: Marek Vasut <marex@denx.de>
> ---
> 
> Changes v2:
>  Add Marek's reviewed by.
> 
>  drivers/mtd/nand/mxs_nand.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/mxs_nand.c b/drivers/mtd/nand/mxs_nand.c
> index 33ce817..97011b2 100644
> --- a/drivers/mtd/nand/mxs_nand.c
> +++ b/drivers/mtd/nand/mxs_nand.c
> @@ -149,6 +149,13 @@ static inline uint32_t 
> mxs_nand_get_ecc_strength(uint32_t page_data_size,
>                                               uint32_t page_oob_size)
>  {
>       int ecc_strength;
> +     int max_ecc_strength_supported;
> +
> +     /* Refer to Chapter 17 for i.MX6DQ, Chapter 18 for i.MX6SX */
> +     if (is_cpu_type(MXC_CPU_MX6SX))
> +             max_ecc_strength_supported = 62;
> +     else
> +             max_ecc_strength_supported = 40;

       arm:  +   mx28evk_nand                  
+drivers/mtd/nand/mxs_nand.c:155:18: error: 'MXC_CPU_MX6SX' undeclared (first use in this function)
+drivers/mtd/nand/mxs_nand.c:155:18: note: each undeclared identifier is reported only once for each function it appears in
+make[2]: *** [drivers/mtd/nand/mxs_nand.o] Error 1
+make[1]: *** [drivers/mtd/nand] Error 2
+make: *** [sub-make] Error 2

(among other failed targets)

I tried to fix it by including asm/arch-imx/cpu.h, but then got undefined 
reference to is_cpu_type().

-Scott

  parent reply	other threads:[~2015-08-25 21:05 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-21  8:15 [U-Boot] [PATCH resend V2 1/3] mtd: nand: mxs support oobsize bigger than 512 Peng Fan
2015-07-21  8:15 ` [U-Boot] [PATCH V2 2/3] mtd: nand: mxs check maximum ecc that platfrom supports Peng Fan
2015-07-31 16:14   ` Tim Harvey
2015-08-25 21:05   ` Scott Wood [this message]
2015-08-26  0:33     ` Peng Fan
2015-08-26  2:14       ` Scott Wood
2015-08-26  1:30         ` Peng Fan
2015-08-26  7:59           ` Stefano Babic
2015-07-21  8:15 ` [U-Boot] [PATCH V2 3/3] mtd: nand: mxs invalidate dcache before DMA read Peng Fan
2015-07-21  8:41   ` Marek Vasut
2015-07-31 14:49   ` Tim Harvey
2015-07-31 15:01     ` Marek Vasut
2015-07-31 16:20 ` [U-Boot] [PATCH resend V2 1/3] mtd: nand: mxs support oobsize bigger than 512 Tim Harvey
2015-07-31 17:07 ` Scott Wood
2015-08-01  1:15   ` Peng Fan
2015-08-01  2:36     ` Scott Wood
2015-08-01  5:56       ` Peng Fan
2015-08-01 15:18         ` Marek Vasut
2015-08-01 18:32           ` Scott Wood
2015-08-01 18:38             ` Marek Vasut
2015-08-01 18:54               ` Scott Wood
2015-08-02  3:18                 ` Peng Fan
2015-08-10  1:17                   ` Peng Fan
2015-08-10 23:31                     ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440536756.16577.39.camel@freescale.com \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox