From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chin Liang See <clsee@altera.com>
Date: Wed, 26 Aug 2015 00:43:20 -0500
Subject: [U-Boot] [PATCH v2 1/2] arm: socfpga: mmc: Enable calibration
 for drvsel and smpsel
In-Reply-To: <20150825210143.GA4501@amd>
References: <1440055109-2252-1-git-send-email-clsee@altera.com>
 <20150825210143.GA4501@amd>
Message-ID: <1440567800.2052.1.camel@clsee-VirtualBox>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tue, 2015-08-25 at 23:01 +0200, ZY - pavel wrote:
> On Thu 2015-08-20 02:18:29, Chin Liang See wrote:
> > Enable SDMMC calibration to determine the best setting for
> > drvsel and smpsel. It will be triggered whenever there is
> > a change of card frequency and bus width. This is to ensure
> > reliable transmission between the controller and the card.
> > 
> > Signed-off-by: Chin Liang See <clsee@altera.com>
> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > Cc: Pavel Machek <pavel@denx.de>
> > Cc: Marek Vasut <marex@denx.de>
> > Cc: Stefan Roese <sr@denx.de>
> 
> 
> 
> > +			/* Determine if the rectangle fits here */
> > +			for (add_col = 0; (add_col < rect_width) && ok;
> > +			     add_col++) {
> > +				for (add_row = 0; add_row < rect_height;
> > +				     add_row++) {
> > +					if (!cal_results[start_row + add_row]
> > +					    [start_col + add_col]) {
> > +						ok = 0;
> > +						break;
> > +					}
> > +				}
> > +			}
> 
> > +			/*
> > +			 * Return 'middle' of rectangle in case of
> > +			 * success
> > +			 */
> > +			if (ok) {
> > +				if (rect_width > 1)
> > +					rect_width--;
> > +
> > +				if (rect_height > 1)
> > +					rect_height--;
> > +
> > +				*cal_row = start_row + (rect_height / 2);
> > +				*cal_col = start_col + (rect_width / 2);
> > +
> > +				return 0;
> > +			}
> 
> This should go into separate function.

Actually I already break down once to avoid deep identation :)

> 
> The "&& ok" is not neccessary, since you break.

Cool, let change that in v3. I shall do that once finish sync up with
Jaehoon.

Thanks
Chin Liang

> 
> Thanks,
> 									Pavel