public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/9] dm: eth: Do not print misleading "Net Initialization Skipped"
Date: Thu, 27 Aug 2015 22:25:52 -0700	[thread overview]
Message-ID: <1440739559-16225-2-git-send-email-bmeng.cn@gmail.com> (raw)
In-Reply-To: <1440739559-16225-1-git-send-email-bmeng.cn@gmail.com>

With driver model, board_eth_init() or cpu_eth_init() is not a must.
Thus we don't need print a misleading "Net Initialization Skipped".

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>

---

Changes in v3: None
Changes in v2:
- Change to only comment out "Net Initialization Skipped" printf

 net/eth.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/eth.c b/net/eth.c
index d3ec8d6..c46a8c3 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -107,7 +107,9 @@ static void eth_common_init(void)
 		if (cpu_eth_init(gd->bd) < 0)
 			printf("CPU Net Initialization Failed\n");
 	} else {
+#ifndef CONFIG_DM_ETH
 		printf("Net Initialization Skipped\n");
+#endif
 	}
 }
 
-- 
1.8.2.1

  reply	other threads:[~2015-08-28  5:25 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-28  5:25 [U-Boot] [PATCH v3 1/9] net: Revert "tftp: adjust settings to be suitable for 100Mbit ethernet" Bin Meng
2015-08-28  5:25 ` Bin Meng [this message]
2015-09-01  0:32   ` [U-Boot] [PATCH v3 2/9] dm: eth: Do not print misleading "Net Initialization Skipped" Simon Glass
2015-08-28  5:25 ` [U-Boot] [PATCH v3 3/9] dm: test: Add a new test case for dm_test_eth_rotate Bin Meng
2015-09-01  0:32   ` Simon Glass
2015-08-28  5:25 ` [U-Boot] [PATCH v3 4/9] dm: eth: Correctly detect alias in eth_get_dev_by_name() Bin Meng
2015-09-01  0:32   ` Simon Glass
2015-08-28  5:25 ` [U-Boot] [PATCH v3 5/9] x86: crownbay: Convert to use CONFIG_DM_USB Bin Meng
2015-09-01  0:32   ` Simon Glass
2015-08-28  5:25 ` [U-Boot] [PATCH v3 6/9] x86: crownbay: Convert to use CONFIG_DM_ETH for E1000 Bin Meng
2015-09-01  0:32   ` Simon Glass
2015-08-28  5:25 ` [U-Boot] [PATCH v3 7/9] net: pch_gbe: Convert to driver model Bin Meng
2015-09-01  0:32   ` Simon Glass
2015-08-28  5:25 ` [U-Boot] [PATCH v3 8/9] net: pch_gbe: Add Kconfig option Bin Meng
2015-09-01  0:32   ` Simon Glass
2015-08-28  5:25 ` [U-Boot] [PATCH v3 9/9] x86: crownbay: Enable CONFIG_PCH_GBE Bin Meng
2015-09-01  0:32   ` Simon Glass
2015-08-30 22:45 ` [U-Boot] [PATCH v3 1/9] net: Revert "tftp: adjust settings to be suitable for 100Mbit ethernet" Simon Glass
2015-08-31 14:38   ` Joe Hershberger
2015-09-01  0:31     ` Simon Glass
2015-09-08  9:23 ` Heiko Schocher
2015-09-08 10:13   ` Hannes Schmelzer
2015-09-08 10:21     ` Bin Meng
2015-09-08 10:36     ` Stefan Roese
2015-09-08 10:42       ` Hannes Schmelzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440739559-16225-2-git-send-email-bmeng.cn@gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox