[U-Boot] [PATCH 1/2] arm: socfpga: mmc: Enable calibration for drvsel and smpsel

Marek Vasut
2015-08-20T21:59:19Z

On Thursday, August 20, 2015 at 11:55:02 PM, Dinh Nguyen wrote:
> +CC: Simon Glass

Hi Dinh,

> On Thu, Aug 20, 2015 at 12:32 AM, Marek Vasut <marex@denx.de> wrote:
> > On Thursday, August 20, 2015 at 07:28:02 AM, Chin Liang See wrote:
> >> Hi,
> >>
> >> On Wed, 2015-08-19 at 14:36 +0000, marex at denx.de wrote:
> >> > On Wednesday, August 19, 2015 at 10:21:17 AM, Chin Liang See wrote:
> >> > > Hi,
> >> >
> >> > Hi again,
> >> >
> >> > > On Wed, 2015-08-19 at 02:41 +0000, marex at denx.de wrote:
> >> > > > On Wednesday, August 19, 2015 at 07:54:50 AM, Chin Liang See wrote:
> >> > > > > Enable SDMMC calibration to determine the best setting for
> >> > > > > drvsel and smpsel. It will be triggered whenever there is
> >> > > > > a change of card frequency and bus width. This is to ensure
> >> > > > > reliable transmission between the controller and the card.
> >> > > > >
> >> > > > > Signed-off-by: Chin Liang See <clsee@altera.com>
> >> > > > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
>
> I think there's something wrong with your git scripts, I did not get this
> email.

You're not getting quite a lot of email I think. Could it be that altera
has some issues with their mail system after some 300 patches went through
your mailbox ? You sure you're not being filtered ? :b

> >> > > > > Cc: Pavel Machek <pavel@denx.de>
> >> > > > > Cc: Marek Vasut <marex@denx.de>
> >> > > > > Cc: Wolfgang Denk <wd@denx.de>
> >> > > > > Cc: Stefan Roese <sr@denx.de>
> >> > > > > Cc: Tom Rini <trini@konsulko.com>
> >> > > > > ---

[...]

> >> > Thanks. I was curious, is this really socfpga specific or can this
> >> > calibration be used on dwmmc in general -- thus on exynos and rockchip
> >> > systems -- as well? If it's generic to dwmmc, this should be moved
> >> > into the dwmmc core code. Also, I am CCing Simon, he's been plumbing
> >> > in the DWMMC recently.
>
> I didn't see you explicitly add Simon to the thread. Doing it here..
>
> >> I am not sure. But definitely we can make the calibration common enough
> >> if they required the calibration too. Let wait feedback from Simon.
>
> I know that the linux driver for the DW MMC for SoCFGPA, Exynos and
> Rockchip are using the drvsel and smpsel parameters. But I also think
> these parameters can
> be different for different types of SD card. Are you sure this
> function will cover those
> cases?

If we're doing the calibration, we should do it correctly :)