public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Paul Kocialkowski <contact@paulk.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] common/image.c: Make boot_get_ramdisk() perform a check for Android images
Date: Tue, 01 Sep 2015 15:50:29 +0200	[thread overview]
Message-ID: <1441115429.4123.1.camel@collins> (raw)
In-Reply-To: <1440704561-17015-1-git-send-email-trini@konsulko.com>

Le jeudi 27 ao?t 2015 ? 15:42 -0400, Tom Rini a ?crit :
> In 2dd4632 the check for where a ramdisk is found on an Android image
> was got moved into the "normal" loop here, causing people to have to
> pass the kernel address in the ramdisk address location in order to have
> Android boot still.  This changed previous behavior so perform a check
> early in the function to see if we have an Android image and if so use
> that as where to look for the ramdisk (which is what the rest of the
> code here expects).

That patch does fix my problem (the ramdisk is now correctly passed to
the kernel). I suggest that you merge it ASAP.

Thanks!

> Cc: Rob Herring <robh@kernel.org>
> Reported-by: Paul Kocialkowski <contact@paulk.fr>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
>  common/image.c |    9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/common/image.c b/common/image.c
> index ca721c5..e938bea 100644
> --- a/common/image.c
> +++ b/common/image.c
> @@ -907,6 +907,15 @@ int boot_get_ramdisk(int argc, char * const argv[], bootm_headers_t *images,
>  	if (argc >= 2)
>  		select = argv[1];
>  
> +#ifdef CONFIG_ANDROID_BOOT_IMAGE
> +	/*
> +	 * Look for an Android boot image.
> +	 */
> +	buf = map_sysmem(images->os.start, 0);
> +	if (genimg_get_format(buf) == IMAGE_FORMAT_ANDROID)
> +		select = argv[0];
> +#endif
> +
>  	/*
>  	 * Look for a '-' which indicates to ignore the
>  	 * ramdisk argument

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150901/56473b7c/attachment.sig>

  parent reply	other threads:[~2015-09-01 13:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27 19:42 [U-Boot] [PATCH] common/image.c: Make boot_get_ramdisk() perform a check for Android images Tom Rini
2015-08-27 21:04 ` Rob Herring
2015-08-27 21:47   ` Tom Rini
2015-08-28 15:35     ` Rob Herring
2015-08-28 16:24       ` Tom Rini
2015-09-01 13:50 ` Paul Kocialkowski [this message]
2015-10-05 19:23   ` Rob Herring
2015-10-07 18:07     ` Paul Kocialkowski
2015-10-10 13:10       ` Paul Kocialkowski
2015-10-11 13:09     ` Tom Rini
2015-10-12 15:15 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441115429.4123.1.camel@collins \
    --to=contact@paulk.fr \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox