From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Kocialkowski Date: Tue, 01 Sep 2015 15:59:46 +0200 Subject: [U-Boot] [PATCH 11/13] sunxi: Add support for android boot image In-Reply-To: <1441115649.26292.34.camel@hellion.org.uk> References: <1441032373-16992-1-git-send-email-maxime.ripard@free-electrons.com> <1441032373-16992-12-git-send-email-maxime.ripard@free-electrons.com> <1441091338.18644.151.camel@hellion.org.uk> <1441098053.2527.1.camel@collins> <1441104365.27618.32.camel@hellion.org.uk> <20150901112902.GO29389@lukather> <1441115649.26292.34.camel@hellion.org.uk> Message-ID: <1441115986.3008.4.camel@aldrin> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le mardi 01 septembre 2015 ? 14:54 +0100, Ian Campbell a ?crit : > On Tue, 2015-09-01 at 13:29 +0200, Maxime Ripard wrote: > > On Tue, Sep 01, 2015 at 11:46:05AM +0100, Ian Campbell wrote: > > > On Tue, 2015-09-01 at 11:00 +0200, Paul Kocialkowski wrote: > > > > Le mardi 01 septembre 2015 ? 08:08 +0100, Ian Campbell a ?crit : > > > > > On Mon, 2015-08-31 at 16:46 +0200, Maxime Ripard wrote: > > > > > > When using the fastboot boot command, the image sent to U-Boot > > > > > > will > > > > > > be an > > > > > > Android boot image. If the support is missing, that won't > > > > > > obviously > > > > > > work, > > > > > > so we need it in our configuration. > > > > > > > > > > Dumb question: Is it possible to boot anything _other_ than an > > > > > android > > > > > boot image via fastboot? > > > > > > > > > > If not then one of the two config options really ought to imply the > > > > > other. > > > > > > > > Well, those options have not been moved to Kconfig yet, but when they > > > > do, there should indeed be such a dependency. > > > > > > > > Otherwise, I believe it still makes sense to have two separate > > > > options > > > > because one might want Android boot image support without fastboot. > > > > > > Then fastboot should depend on android boot image support but not vice > > > -versa. > > > > Indeed, but it's not yet a Kconfig option. > > I'm not sure that's a necessary prerequisite, in some common place do: > > #if defined(CONFIG_CMD_FASTBOOT) && !defined(CONFIG_ANDROID_BOOT_IMAGE) > #define CONFIG_ANDROID_BOOT_IMAGE > #endif Well, I'm not sure adding Kconfig-style logic really is a good idea as it removes some incentive to do things right and move everything over to Kconfig (which is out of the scope of this patch set, I believe). In addition, I don't see what a relevant place to but this in would be. Putting that in sunxi-common.h is just adding two useless extra lines (having the define is sufficient). Overall, I don't think this is a good idea when we have Kconfig around the corner to do things right? -- Paul Kocialkowski, Replicant developer Replicant is a fully free Android distribution running on several devices, a free software mobile operating system putting the emphasis on freedom and privacy/security. Website: http://www.replicant.us/ Blog: http://blog.replicant.us/ Wiki/tracker/forums: http://redmine.replicant.us/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: This is a digitally signed message part URL: