public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/7] arm: mvebu: Do not call board_init_r() from board_init_f()
Date: Thu,  3 Sep 2015 15:08:55 +0200	[thread overview]
Message-ID: <1441285740-23686-2-git-send-email-sr@denx.de> (raw)
In-Reply-To: <1441285740-23686-1-git-send-email-sr@denx.de>

Instead of calling board_init_r() directly from board_init_f(), just
return from board_init_f(). This will make the code continue executing
in crt0.S _main(), from which the board_init_r() is called. This patch
aligns the MVEBU SPL with the correct SPL design as well as reduces
the stack utilisation slightly.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Marek Vasut <marex@denx.de>
Cc: Simon Glass <sjg@chromium.org>
Cc: Luka Perkov <luka.perkov@sartura.hr>
---
 arch/arm/mach-mvebu/spl.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/mach-mvebu/spl.c b/arch/arm/mach-mvebu/spl.c
index 26ff1a2..e273339 100644
--- a/arch/arm/mach-mvebu/spl.c
+++ b/arch/arm/mach-mvebu/spl.c
@@ -78,6 +78,4 @@ void board_init_f(ulong dummy)
 	 */
 	return_to_bootrom();
 #endif
-
-	board_init_r(NULL, 0);
 }
-- 
2.5.1

  reply	other threads:[~2015-09-03 13:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-03 13:08 [U-Boot] [PATCH 1/7] kwbimage: Align payload size to 4 bytes Stefan Roese
2015-09-03 13:08 ` Stefan Roese [this message]
2015-09-03 13:11   ` [U-Boot] [PATCH 2/7] arm: mvebu: Do not call board_init_r() from board_init_f() Marek Vasut
2015-09-04  0:58     ` Simon Glass
2015-09-03 13:08 ` [U-Boot] [PATCH 3/7] arm: mvebu: Add basic Armada XP / 38x dtsi/dts files Stefan Roese
2015-09-03 13:08 ` [U-Boot] [PATCH 4/7] arm: mvebu: Add DM (driver model) support Stefan Roese
2015-09-03 13:08 ` [U-Boot] [PATCH 5/7] usb: ehci-marvell.c: Add DM support Stefan Roese
2015-09-03 13:12   ` Marek Vasut
2015-09-03 13:16     ` Stefan Roese
2015-09-03 14:26       ` Marek Vasut
2015-09-03 14:33         ` Stefan Roese
2015-09-03 14:37           ` Marek Vasut
2015-09-03 13:08 ` [U-Boot] [PATCH 6/7] arm: mvebu: Enable DM_USB on AXP / A38x boards Stefan Roese
2015-09-03 13:09 ` [U-Boot] [PATCH 7/7] arm: mvebu: Enable DM_SERIAL " Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441285740-23686-2-git-send-email-sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox