From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5] bitops: introduce BIT() definition
Date: Wed, 9 Sep 2015 14:04:38 -0500 [thread overview]
Message-ID: <1441825478.29081.33.camel@freescale.com> (raw)
In-Reply-To: <20150909182540.25235380DF2@gemini.denx.de>
On Wed, 2015-09-09 at 20:25 +0200, Wolfgang Denk wrote:
> Dear Andreas,
>
> In message <1441626234-16364-1-git-send-email-andreas.devel@googlemail.com>
> you wrote:
> ...
> > --- a/include/linux/bitops.h
> > +++ b/include/linux/bitops.h
> > @@ -3,6 +3,8 @@
> >
> > #include <asm/types.h>
> >
> > +#define BIT(nr) (1UL << (nr))
>
> What happens when someone decides to use this on a 64 bit register?
>
> Also, this definition is inherently wrong for Power Architecture (TM)
> systems, where bit 0 is the most significant bit.
It's not "inherently wrong" to number bits from LSB on such systems -- it
just doesn't match the unusual convention found in PPC documentation and the
rotate instructions.
In any case, this would be part of the Linux driver compatibility layer
rather than the placement in common.h that you previously objected to.
-Scott
next prev parent reply other threads:[~2015-09-09 19:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 17:01 [U-Boot] [PATCH v4 0/4] add dfu support for at91 sam9260 based boards Heiko Schocher
2015-08-21 17:01 ` [U-Boot] [PATCH v4 1/4] bitops: introduce BIT() definition Heiko Schocher
2015-08-21 19:26 ` Michael Heimpold
2015-08-21 19:29 ` Marek Vasut
2015-09-07 11:20 ` Andreas Bießmann
2015-09-07 11:52 ` Heiko Schocher
2015-09-07 12:01 ` Andreas Bießmann
2015-09-07 12:15 ` Marek Vasut
2015-09-07 12:42 ` Jagan Teki
2015-09-07 11:43 ` [U-Boot] [PATCH v5] " Andreas Bießmann
2015-09-07 11:47 ` Stefan Roese
2015-09-08 15:54 ` Tom Warren
2015-09-08 16:17 ` Anatolij Gustschin
2015-09-08 18:01 ` ivan.khoronzhuk
2015-09-09 16:22 ` Scott Wood
2015-09-09 16:37 ` Tom Rini
2015-09-09 17:10 ` Scott Wood
2015-09-09 18:58 ` Ivan Khoronzhuk
2015-09-09 18:52 ` Ivan Khoronzhuk
2015-09-09 18:59 ` Scott Wood
2015-09-09 18:25 ` Wolfgang Denk
2015-09-09 19:04 ` Scott Wood [this message]
2015-09-12 12:52 ` [U-Boot] [U-Boot,v5] " Tom Rini
2015-09-08 18:03 ` [U-Boot] [PATCH v4 1/4] " Jagan Teki
2015-08-21 17:01 ` [U-Boot] [PATCH v4 2/4] usb: gadget: at91_udc: port linux driver at91_udc Heiko Schocher
2015-08-21 17:01 ` [U-Boot] [PATCH v4 3/4] usb: gadget: at91_udc: add at91_udc into U-Boot Heiko Schocher
2015-08-21 17:01 ` [U-Boot] [PATCH v4 4/4] at91, taurus, smartweb: add dfu support Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441825478.29081.33.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox