From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chin Liang See <clsee@altera.com>
Date: Thu, 10 Sep 2015 00:00:33 -0500
Subject: [U-Boot] [PATCH 2/4] spi: cadence_qspi: Fix fdt read of
	spi-max-frequency
In-Reply-To: <20150909071618.GA21205@amd>
References: <1441675104-2536-1-git-send-email-clsee@altera.com>
 <20150909071618.GA21205@amd>
Message-ID: <1441861233.1946.5.camel@clsee-VirtualBox>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi,

On Wed, 2015-09-09 at 09:16 +0200, ZY - pavel wrote:
> On Mon 2015-09-07 20:18:24, Chin Liang See wrote:
> > Fix the fdt read for spi-max-frequency as it's contained
> > in the child node. Current state of code is always
> > returning default value.
> > 
> > Signed-off-by: Chin Liang See <clsee@altera.com>
> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > Cc: Dinh Nguyen <dinh.linux@gmail.com>
> > Cc: Marek Vasut <marex@denx.de>
> > Cc: Stefan Roese <sr@denx.de>
> > Cc: Vikas Manocha <vikas.manocha@st.com>
> > Cc: Jagannadh Teki <jteki@openedev.com>
> > Cc: Pavel Machek <pavel@denx.de>
> > ---
> > Changes for v2
> > - Add unsigned casting for plat->max_hz
> > ---
> >  drivers/spi/cadence_qspi.c |    8 ++++----
> >  1 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/spi/cadence_qspi.c b/drivers/spi/cadence_qspi.c
> > index 23c88d5..8c0f7dd 100644
> > --- a/drivers/spi/cadence_qspi.c
> > +++ b/drivers/spi/cadence_qspi.c
> > @@ -296,10 +296,6 @@ static int cadence_spi_ofdata_to_platdata(struct udevice *bus)
> >  	plat->regbase = (void *)data[0];
> >  	plat->ahbbase = (void *)data[2];
> >  
> > -	/* Use 500KHz as a suitable default */
> > -	plat->max_hz = fdtdec_get_int(blob, node, "spi-max-frequency",
> > -				      500000);
> > -
> >  	/* All other paramters are embedded in the child node */
> >  	subnode = fdt_first_subnode(blob, node);
> >  	if (subnode < 0) {
> > @@ -307,6 +303,10 @@ static int cadence_spi_ofdata_to_platdata(struct udevice *bus)
> >  		return -ENODEV;
> >  	}
> >  
> > +	/* Use 500KHz as a suitable default */
> 
> And as you'll be updating it... it should be "500 kHz", AFAICT.

That sounds easy fix :)

Thanks
Chin Liang

> 
> 
> > +	plat->max_hz = (unsigned int)fdtdec_get_int(blob, subnode,
> > +						"spi-max-frequency", 500000);
> > +
> >  	/* Read other parameters from DT */
> >  	plat->page_size = fdtdec_get_int(blob, subnode, "page-size", 256);
> >  	plat->block_size = fdtdec_get_int(blob, subnode, "block-size",
> > 16);
> 
> 									Pavel
>