From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] mmc: dw_mmc: Zap endless timeout
Date: Fri, 11 Sep 2015 17:04:42 +0000 [thread overview]
Message-ID: <1441991081.10291.5.camel@synopsys.com> (raw)
In-Reply-To: <201509111349.57023.marex@denx.de>
Hi Marek,
On Fri, 2015-09-11 at 13:49 +0200, Marek Vasut wrote:
> On Friday, September 11, 2015 at 09:59:32 AM, Alexey Brodkin wrote:
> > Hi Marek,
>
> Hi!
> btw Is your mailer totally broken by any chance ?
Hm, I'm not sure what happened but as I may see here
https://patchwork.ozlabs.org/patch/516618/ my message looks good :)
> > It turned out that patch breaks functionality in some cases.
> > For me on every attempt to download something significant (at least I see
> > it on 5/7 Mb files) from SD I'm seeing timeout firing too early.
> >
> > I added a bit of extra instrumentation to see where time is spent and why.
>
> Check this patch:
>
> [PATCH 1/2] mmc: dw_mmc: Increase timeout to 20 seconds
>
> https://patchwork.ozlabs.org/patch/511899/
>
> Does it fix things for you ?
Well this might fix my particular test-case, but are you sure there's
no chance for this timeout to be not long enough?
And vice versa why wait 20 seconds if problem has happened on short
transfer? Really wait 20 seconds on boot of say TV-set just because
USB-drive is broken?
So I would say that we need to rely on amount of data to be transferred
instead of having any random number of seconds for all.
-Alexey
next prev parent reply other threads:[~2015-09-11 17:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 20:39 [U-Boot] [PATCH 1/4] mmc: dw_mmc: Stop bounce buffer even in case of failure Marek Vasut
2015-07-27 20:39 ` [U-Boot] [PATCH 2/4] mmc: dw_mmc: Zap endless timeout Marek Vasut
2015-08-12 7:26 ` Pantelis Antoniou
2015-09-11 7:59 ` Alexey Brodkin
2015-09-11 11:49 ` Marek Vasut
2015-09-11 17:04 ` Alexey Brodkin [this message]
2015-09-12 16:17 ` Marek Vasut
2015-07-27 20:39 ` [U-Boot] [PATCH 3/4] mmc: dw_mmc: Improve handling of data transfer failure Marek Vasut
2015-08-12 7:27 ` Pantelis Antoniou
2015-07-27 20:39 ` [U-Boot] [PATCH 4/4] mmc: dw_mmc: Probe the MMC from OF Marek Vasut
2015-08-12 7:35 ` Pantelis Antoniou
2015-08-12 20:43 ` [U-Boot] [PATCH V2 " Marek Vasut
2015-08-19 21:58 ` Marek Vasut
2015-08-19 22:55 ` Pantelis Antoniou
2015-08-19 22:57 ` Marek Vasut
2015-08-12 20:43 ` [U-Boot] [PATCH " Marek Vasut
2015-08-12 7:25 ` [U-Boot] [PATCH 1/4] mmc: dw_mmc: Stop bounce buffer even in case of failure Pantelis Antoniou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441991081.10291.5.camel@synopsys.com \
--to=alexey.brodkin@synopsys.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox