From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Mon, 14 Sep 2015 00:57:04 +0200 Subject: [U-Boot] [PATCH 2/2] FIX: env: import: hashtable: Free memory allocated before exiting from himport_r() In-Reply-To: <1442185024-14645-1-git-send-email-l.majewski@majess.pl> References: <1442185024-14645-1-git-send-email-l.majewski@majess.pl> Message-ID: <1442185024-14645-2-git-send-email-l.majewski@majess.pl> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Without this patch memory is not released on early exit. Signed-off-by: Lukasz Majewski --- lib/hashtable.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/hashtable.c b/lib/hashtable.c index 7df424a..02b4105 100644 --- a/lib/hashtable.c +++ b/lib/hashtable.c @@ -842,8 +842,10 @@ int himport_r(struct hsearch_data *htab, } } - if(!size) + if (!size) { + free(data); return 1; /* everything OK */ + } if(crlf_is_lf) { /* Remove Carriage Returns in front of Line Feeds */ unsigned ignored_crs = 0; @@ -907,6 +909,7 @@ int himport_r(struct hsearch_data *htab, if (*name == 0) { debug("INSERT: unable to use an empty key\n"); __set_errno(EINVAL); + free(data); return 0; } -- 2.1.4