public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mtd: nand: fsmc: Fixes and cleanup for fsmc_nand_switch_ecc()
Date: Mon, 14 Sep 2015 10:17:20 -0500	[thread overview]
Message-ID: <1442243840.2909.65.camel@freescale.com> (raw)
In-Reply-To: <1442213267-9343-1-git-send-email-sr@denx.de>

On Mon, 2015-09-14 at 08:47 +0200, Stefan Roese wrote:
> This patch addresses some comments raised by Scott in the last versions.
> Here the changes in detail:
> 
> - Removed __maybe_unused as its not needed
> - Added check for strength == 4 and error out for the unsupported
>   ECC strength values
> - Don't set .caclulate, .correct, and .bytes for NAND_ECC_SOFT_BCH as this
>   will be done in nand_scan_tail()
> - Set .caclulate back to fsmc_read_hwecc() in the HW case
> - Added comment that this function will only be called on SPEAr platforms,
>   not supporting the BCH8 HW ECC (FSMC_VER8)
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Scott Wood <scottwood@freescale.com>
> Cc: Tom Rini <trini@konsulko.com>
> ---
>  drivers/mtd/nand/fsmc_nand.c | 21 +++++++++++++++------
>  1 file changed, 15 insertions(+), 6 deletions(-)

Acked-by: Scott Wood <scottwood@freescale.com>

-Scott

  reply	other threads:[~2015-09-14 15:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-14  6:47 [U-Boot] [PATCH] mtd: nand: fsmc: Fixes and cleanup for fsmc_nand_switch_ecc() Stefan Roese
2015-09-14 15:17 ` Scott Wood [this message]
2015-09-15 21:34 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442243840.2909.65.camel@freescale.com \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox