public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch v2 02/16] common/board_f.c: modify the macro to use get_clocks() more common
Date: Mon, 21 Sep 2015 12:33:13 -0500	[thread overview]
Message-ID: <1442856793.19102.169.camel@freescale.com> (raw)
In-Reply-To: <1442473363-15096-1-git-send-email-Qianyu.Gong@freescale.com>

On Thu, 2015-09-17 at 15:02 +0800, Gong Qianyu wrote:
> get_clocks() should not be limited by ESDHC.
> 
> Signed-off-by: Gong Qianyu <Qianyu.Gong@freescale.com>
> ---
>  common/board_f.c                  | 2 +-
>  include/configs/BSC9132QDS.h      | 1 +
>  include/configs/MPC8308RDB.h      | 1 +
>  include/configs/MPC837XEMDS.h     | 1 +
>  include/configs/MPC837XERDB.h     | 1 +
>  include/configs/MPC8536DS.h       | 1 +
>  include/configs/MPC8569MDS.h      | 1 +
>  include/configs/P1010RDB.h        | 1 +
>  include/configs/P1022DS.h         | 1 +
>  include/configs/P2041RDB.h        | 1 +
>  include/configs/T102xQDS.h        | 1 +
>  include/configs/T102xRDB.h        | 1 +
>  include/configs/T1040QDS.h        | 1 +
>  include/configs/T104xRDB.h        | 1 +
>  include/configs/T208xQDS.h        | 1 +
>  include/configs/T208xRDB.h        | 1 +
>  include/configs/T4240QDS.h        | 1 +
>  include/configs/T4240RDB.h        | 1 +
>  include/configs/UCP1020.h         | 1 +
>  include/configs/colibri_vf.h      | 1 +
>  include/configs/controlcenterd.h  | 1 +
>  include/configs/corenet_ds.h      | 1 +
>  include/configs/hrcon.h           | 1 +
>  include/configs/ima3-mx53.h       | 1 +
>  include/configs/ls1021aqds.h      | 1 +
>  include/configs/ls1021atwr.h      | 1 +
>  include/configs/ls2085aqds.h      | 1 +
>  include/configs/ls2085ardb.h      | 1 +
>  include/configs/m53evk.h          | 1 +
>  include/configs/mx25pdk.h         | 1 +
>  include/configs/mx35pdk.h         | 1 +
>  include/configs/mx51_efikamx.h    | 1 +
>  include/configs/mx51evk.h         | 1 +
>  include/configs/mx53ard.h         | 1 +
>  include/configs/mx53evk.h         | 1 +
>  include/configs/mx53loco.h        | 1 +
>  include/configs/mx53smd.h         | 1 +
>  include/configs/mx6_common.h      | 1 +
>  include/configs/p1_p2_rdb_pc.h    | 1 +
>  include/configs/p1_twr.h          | 1 +
>  include/configs/usbarmory.h       | 1 +
>  include/configs/vf610twr.h        | 1 +
>  include/configs/vision2.h         | 1 +
>  include/configs/woodburn_common.h | 1 +
>  44 files changed, 44 insertions(+), 1 deletion(-)
> 
> diff --git a/common/board_f.c b/common/board_f.c
> index 613332e..1bb84b3 100644
> --- a/common/board_f.c
> +++ b/common/board_f.c
> @@ -806,7 +806,7 @@ static init_fnc_t init_sequence_f[] = {
>  #if defined(CONFIG_BOARD_POSTCLK_INIT)
>       board_postclk_init,
>  #endif
> -#ifdef CONFIG_FSL_ESDHC
> +#ifdef CONFIG_FSL_CLK
>       get_clocks,
>  #endif
>  #ifdef CONFIG_M68K

Symbol name is either too vague or too specific, and needs documentation.  
Maybe just make it unconditional, and add an empty weak function?  Is there a 
good reason some configs call get_clocks earlier than others?

-Scott

      parent reply	other threads:[~2015-09-21 17:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17  7:02 [U-Boot] [Patch v2 02/16] common/board_f.c: modify the macro to use get_clocks() more common Gong Qianyu
2015-09-21 17:26 ` York Sun
2015-09-22  2:59   ` Gong Q.Y.
2015-09-22 14:49     ` York Sun
2015-09-22 15:32       ` Scott Wood
2015-09-22 15:42         ` York Sun
2015-09-21 17:33 ` Scott Wood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442856793.19102.169.camel@freescale.com \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox