From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Date: Mon, 21 Sep 2015 12:33:13 -0500
Subject: [U-Boot] [Patch v2 02/16] common/board_f.c: modify the macro to
 use get_clocks() more common
In-Reply-To: <1442473363-15096-1-git-send-email-Qianyu.Gong@freescale.com>
References: <1442473363-15096-1-git-send-email-Qianyu.Gong@freescale.com>
Message-ID: <1442856793.19102.169.camel@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Thu, 2015-09-17 at 15:02 +0800, Gong Qianyu wrote:
> get_clocks() should not be limited by ESDHC.
> 
> Signed-off-by: Gong Qianyu <Qianyu.Gong@freescale.com>
> ---
>  common/board_f.c                  | 2 +-
>  include/configs/BSC9132QDS.h      | 1 +
>  include/configs/MPC8308RDB.h      | 1 +
>  include/configs/MPC837XEMDS.h     | 1 +
>  include/configs/MPC837XERDB.h     | 1 +
>  include/configs/MPC8536DS.h       | 1 +
>  include/configs/MPC8569MDS.h      | 1 +
>  include/configs/P1010RDB.h        | 1 +
>  include/configs/P1022DS.h         | 1 +
>  include/configs/P2041RDB.h        | 1 +
>  include/configs/T102xQDS.h        | 1 +
>  include/configs/T102xRDB.h        | 1 +
>  include/configs/T1040QDS.h        | 1 +
>  include/configs/T104xRDB.h        | 1 +
>  include/configs/T208xQDS.h        | 1 +
>  include/configs/T208xRDB.h        | 1 +
>  include/configs/T4240QDS.h        | 1 +
>  include/configs/T4240RDB.h        | 1 +
>  include/configs/UCP1020.h         | 1 +
>  include/configs/colibri_vf.h      | 1 +
>  include/configs/controlcenterd.h  | 1 +
>  include/configs/corenet_ds.h      | 1 +
>  include/configs/hrcon.h           | 1 +
>  include/configs/ima3-mx53.h       | 1 +
>  include/configs/ls1021aqds.h      | 1 +
>  include/configs/ls1021atwr.h      | 1 +
>  include/configs/ls2085aqds.h      | 1 +
>  include/configs/ls2085ardb.h      | 1 +
>  include/configs/m53evk.h          | 1 +
>  include/configs/mx25pdk.h         | 1 +
>  include/configs/mx35pdk.h         | 1 +
>  include/configs/mx51_efikamx.h    | 1 +
>  include/configs/mx51evk.h         | 1 +
>  include/configs/mx53ard.h         | 1 +
>  include/configs/mx53evk.h         | 1 +
>  include/configs/mx53loco.h        | 1 +
>  include/configs/mx53smd.h         | 1 +
>  include/configs/mx6_common.h      | 1 +
>  include/configs/p1_p2_rdb_pc.h    | 1 +
>  include/configs/p1_twr.h          | 1 +
>  include/configs/usbarmory.h       | 1 +
>  include/configs/vf610twr.h        | 1 +
>  include/configs/vision2.h         | 1 +
>  include/configs/woodburn_common.h | 1 +
>  44 files changed, 44 insertions(+), 1 deletion(-)
> 
> diff --git a/common/board_f.c b/common/board_f.c
> index 613332e..1bb84b3 100644
> --- a/common/board_f.c
> +++ b/common/board_f.c
> @@ -806,7 +806,7 @@ static init_fnc_t init_sequence_f[] = {
>  #if defined(CONFIG_BOARD_POSTCLK_INIT)
>       board_postclk_init,
>  #endif
> -#ifdef CONFIG_FSL_ESDHC
> +#ifdef CONFIG_FSL_CLK
>       get_clocks,
>  #endif
>  #ifdef CONFIG_M68K

Symbol name is either too vague or too specific, and needs documentation.  
Maybe just make it unconditional, and add an empty weak function?  Is there a 
good reason some configs call get_clocks earlier than others?

-Scott