public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/6] pci: Set PCI_COMMAND_IO bit for VGA device
Date: Thu,  1 Oct 2015 00:35:59 -0700	[thread overview]
Message-ID: <1443684964-342-2-git-send-email-bmeng.cn@gmail.com> (raw)
In-Reply-To: <1443684964-342-1-git-send-email-bmeng.cn@gmail.com>

PCI_COMMAND_IO bit must be set for VGA device as it needs to respond
to legacy VGA IO address.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 drivers/pci/pci_auto.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/pci/pci_auto.c b/drivers/pci/pci_auto.c
index 41d5447..e2c239e 100644
--- a/drivers/pci/pci_auto.c
+++ b/drivers/pci/pci_auto.c
@@ -89,6 +89,7 @@ void pciauto_setup_device(struct pci_controller *hose,
 	struct pci_region *bar_res;
 	int found_mem64 = 0;
 #endif
+	u16 class;
 
 	pci_hose_read_config_word(hose, dev, PCI_COMMAND, &cmdstat);
 	cmdstat = (cmdstat & ~(PCI_COMMAND_IO | PCI_COMMAND_MEMORY)) | PCI_COMMAND_MASTER;
@@ -205,6 +206,11 @@ void pciauto_setup_device(struct pci_controller *hose,
 	}
 #endif
 
+	/* PCI_COMMAND_IO must be set for VGA device */
+	pci_hose_read_config_word(hose, dev, PCI_CLASS_DEVICE, &class);
+	if (class == PCI_CLASS_DISPLAY_VGA)
+		cmdstat |= PCI_COMMAND_IO;
+
 	pci_hose_write_config_word(hose, dev, PCI_COMMAND, cmdstat);
 	pci_hose_write_config_byte(hose, dev, PCI_CACHE_LINE_SIZE,
 		CONFIG_SYS_PCI_CACHE_LINE_SIZE);
-- 
1.8.2.1

  reply	other threads:[~2015-10-01  7:35 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-01  7:35 [U-Boot] [PATCH 0/6] x86: pci: Various bug fixes/enhancements Bin Meng
2015-10-01  7:35 ` Bin Meng [this message]
2015-10-03 14:29   ` [U-Boot] [PATCH 1/6] pci: Set PCI_COMMAND_IO bit for VGA device Simon Glass
2015-10-18 21:36     ` Simon Glass
2015-10-01  7:36 ` [U-Boot] [PATCH 2/6] video: vesa_fb: Fix wrong return value check of pci_find_class() Bin Meng
2015-10-03 14:29   ` Simon Glass
2015-10-07 18:40   ` Anatolij Gustschin
2015-10-18 21:36     ` Simon Glass
2015-10-01  7:36 ` [U-Boot] [PATCH 3/6] dm: pci: Fix pci_last_busno() to return the real last bus no Bin Meng
2015-10-03 14:29   ` Simon Glass
2015-10-18 21:36     ` Simon Glass
2015-10-01  7:36 ` [U-Boot] [PATCH 4/6] dm: pci: Enable VGA address forwarding on bridges Bin Meng
2015-10-03 14:29   ` Simon Glass
2015-10-18 21:36     ` Simon Glass
2015-10-01  7:36 ` [U-Boot] [PATCH 5/6] x86: ivybridge: Remove the dead codes that programs pci bridge Bin Meng
2015-10-03 14:29   ` Simon Glass
2015-10-18 21:37     ` Simon Glass
2015-10-01  7:36 ` [U-Boot] [PATCH 6/6] x86: Allow disabling IGD on Intel Queensbay Bin Meng
2015-10-03 14:29   ` Simon Glass
2015-10-07  8:24     ` Bin Meng
2015-10-09  9:36       ` Simon Glass
2015-10-18 21:37     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443684964-342-2-git-send-email-bmeng.cn@gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox