From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/6] x86: ivybridge: Remove the dead codes that programs pci bridge
Date: Thu, 1 Oct 2015 00:36:03 -0700 [thread overview]
Message-ID: <1443684964-342-6-git-send-email-bmeng.cn@gmail.com> (raw)
In-Reply-To: <1443684964-342-1-git-send-email-bmeng.cn@gmail.com>
Remove bd82x6x_pci_bus_enable_resources() that is not called anywhere.
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
arch/x86/cpu/ivybridge/bd82x6x.c | 32 --------------------------------
1 file changed, 32 deletions(-)
diff --git a/arch/x86/cpu/ivybridge/bd82x6x.c b/arch/x86/cpu/ivybridge/bd82x6x.c
index ca8cccf..3e7a907 100644
--- a/arch/x86/cpu/ivybridge/bd82x6x.c
+++ b/arch/x86/cpu/ivybridge/bd82x6x.c
@@ -55,38 +55,6 @@ void bd82x6x_pci_init(pci_dev_t dev)
x86_pci_write_config16(dev, SECSTS, reg16);
}
-#define PCI_BRIDGE_UPDATE_COMMAND
-void bd82x6x_pci_dev_enable_resources(pci_dev_t dev)
-{
- uint16_t command;
-
- command = x86_pci_read_config16(dev, PCI_COMMAND);
- command |= PCI_COMMAND_IO;
-#ifdef PCI_BRIDGE_UPDATE_COMMAND
- /*
- * If we write to PCI_COMMAND, on some systems this will cause the
- * ROM and APICs to become invisible.
- */
- debug("%x cmd <- %02x\n", dev, command);
- x86_pci_write_config16(dev, PCI_COMMAND, command);
-#else
- printf("%s cmd <- %02x (NOT WRITTEN!)\n", dev_path(dev), command);
-#endif
-}
-
-void bd82x6x_pci_bus_enable_resources(pci_dev_t dev)
-{
- uint16_t ctrl;
-
- ctrl = x86_pci_read_config16(dev, PCI_BRIDGE_CONTROL);
- ctrl |= PCI_COMMAND_IO;
- ctrl |= PCI_BRIDGE_CTL_VGA;
- debug("%x bridge ctrl <- %04x\n", dev, ctrl);
- x86_pci_write_config16(dev, PCI_BRIDGE_CONTROL, ctrl);
-
- bd82x6x_pci_dev_enable_resources(dev);
-}
-
static int bd82x6x_probe(struct udevice *dev)
{
const void *blob = gd->fdt_blob;
--
1.8.2.1
next prev parent reply other threads:[~2015-10-01 7:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 7:35 [U-Boot] [PATCH 0/6] x86: pci: Various bug fixes/enhancements Bin Meng
2015-10-01 7:35 ` [U-Boot] [PATCH 1/6] pci: Set PCI_COMMAND_IO bit for VGA device Bin Meng
2015-10-03 14:29 ` Simon Glass
2015-10-18 21:36 ` Simon Glass
2015-10-01 7:36 ` [U-Boot] [PATCH 2/6] video: vesa_fb: Fix wrong return value check of pci_find_class() Bin Meng
2015-10-03 14:29 ` Simon Glass
2015-10-07 18:40 ` Anatolij Gustschin
2015-10-18 21:36 ` Simon Glass
2015-10-01 7:36 ` [U-Boot] [PATCH 3/6] dm: pci: Fix pci_last_busno() to return the real last bus no Bin Meng
2015-10-03 14:29 ` Simon Glass
2015-10-18 21:36 ` Simon Glass
2015-10-01 7:36 ` [U-Boot] [PATCH 4/6] dm: pci: Enable VGA address forwarding on bridges Bin Meng
2015-10-03 14:29 ` Simon Glass
2015-10-18 21:36 ` Simon Glass
2015-10-01 7:36 ` Bin Meng [this message]
2015-10-03 14:29 ` [U-Boot] [PATCH 5/6] x86: ivybridge: Remove the dead codes that programs pci bridge Simon Glass
2015-10-18 21:37 ` Simon Glass
2015-10-01 7:36 ` [U-Boot] [PATCH 6/6] x86: Allow disabling IGD on Intel Queensbay Bin Meng
2015-10-03 14:29 ` Simon Glass
2015-10-07 8:24 ` Bin Meng
2015-10-09 9:36 ` Simon Glass
2015-10-18 21:37 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443684964-342-6-git-send-email-bmeng.cn@gmail.com \
--to=bmeng.cn@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox