public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ian Campbell <ijc+uboot@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/7] sunxi: Kconfig-ify CONFIG_AXP152_POWER and _AXP209_POWER
Date: Fri, 09 Oct 2015 07:49:53 +0100	[thread overview]
Message-ID: <1444373393.16876.3.camel@hellion.org.uk> (raw)
In-Reply-To: <1443882383-21181-1-git-send-email-hdegoede@redhat.com>

On Sat, 2015-10-03 at 16:26 +0200, Hans de Goede wrote:
> Note that sun5i boards can have either an AXP209 or an AXP152 pmic,

Is it actually xor? I think so given that you later on unify the names
such that they cannot be compiled in at the same time.

If so then...
 
> +config AXP152_POWER
> +	boolean "axp152 pmic support"
> +	depends on MACH_SUN5I
> +	---help---
> +	Say y here to enable support for the axp152 pmic found on
> most A10s
> +	boards.
> +
> +config AXP209_POWER
> +	boolean "axp209 pmic support"
> +	depends on MACH_SUN4I || MACH_SUN5I || MACH_SUN7I
> +	default y if MACH_SUN4I || MACH_SUN7I
> +	---help---
> +	Say y here to enable support for the axp209 pmic found on
> most
> +	A10, A13 and A20 boards.
> +
>  config AXP221_POWER

... these three ought to be inside a choice?

Ian.

  parent reply	other threads:[~2015-10-09  6:49 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-03 14:26 [U-Boot] [PATCH 1/7] sunxi: Kconfig-ify CONFIG_AXP152_POWER and _AXP209_POWER Hans de Goede
2015-10-03 14:26 ` [U-Boot] [PATCH 2/7] sunxi: power: Make all voltages configurable through Kconfig Hans de Goede
2015-10-09  6:56   ` Ian Campbell
2015-10-03 14:26 ` [U-Boot] [PATCH 3/7] sunxi: power: Unify axp pmic function names Hans de Goede
2015-10-03 14:32   ` Chen-Yu Tsai
2015-10-03 20:16     ` Hans de Goede
2015-10-09  8:31       ` Ian Campbell
2015-10-09 11:24         ` Hans de Goede
2015-10-09 12:41           ` Ian Campbell
2015-10-09 13:44             ` Hans de Goede
2015-10-09 14:24               ` Ian Campbell
2015-10-09 14:49             ` Chen-Yu Tsai
2015-10-11 11:14   ` Ian Campbell
2015-10-03 14:26 ` [U-Boot] [PATCH 4/7] sunxi: power: Change A23/A33 VDD-SYS default from 1.2V to 1.1V Hans de Goede
2015-10-09  8:33   ` Ian Campbell
2015-10-10 14:13   ` Chen-Yu Tsai
2015-10-11 11:17     ` Hans de Goede
2015-10-03 14:26 ` [U-Boot] [PATCH 5/7] sunxi: power: Change A23/A33 aldo1 default voltage to 3.0V Hans de Goede
2015-10-09  8:34   ` Ian Campbell
2015-10-03 14:26 ` [U-Boot] [PATCH 6/7] sunxi: power: Use pmic_bus functions for axp152 / axp209 driver Hans de Goede
2015-10-09  8:36   ` Ian Campbell
2015-10-03 14:26 ` [U-Boot] [PATCH 7/7] sunxi: power: Drop protection against multiple calls from axp221 axp_init() Hans de Goede
2015-10-09  8:36   ` Ian Campbell
2015-10-09  6:49 ` Ian Campbell [this message]
2015-10-09 11:20   ` [U-Boot] [PATCH 1/7] sunxi: Kconfig-ify CONFIG_AXP152_POWER and _AXP209_POWER Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444373393.16876.3.camel@hellion.org.uk \
    --to=ijc+uboot@hellion.org.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox