From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 6/6] sbc8641d: increase monitor size from 256k to 384k
Date: Sat, 17 Oct 2015 16:40:31 -0400 [thread overview]
Message-ID: <1445114431-9524-7-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1445114431-9524-1-git-send-email-paul.gortmaker@windriver.com>
Between 2015.07-rc1 and 2015.07-rc2 this board started
silent boot failure. A bisect led to commit 6eed3786c68c8a49d
("net: Move the CMD_NET config to defconfigs"). This commit
looks harmless in itself, but it did implicitly add a feature
to the image which led to this:
u-boot$git describe 6eed3786c68c8a49d
v2015.07-rc1-412-g6eed3786c68c
^^^
u-boot$ls -l ../41*/u-boot.bin
-rwxrwxr-x 1 paul paul 261476 Oct 16 16:47 ../411/u-boot.bin
-rwxrwxr-x 1 paul paul 266392 Oct 16 16:43 ../412/u-boot.bin
u-boot$bc
bc 1.06.95
Copyright 1991-1994, 1997, 1998, 2000, 2004, 2006 Free Software Foundation, Inc.
This is free software with ABSOLUTELY NO WARRANTY.
For details type `warranty'.
256*1024
262144
i.e. we finally broke through the 256k monitor size. Jump it
up to 384k and fix the hard coded value used in the env offset
at the same time.
We were probably flirting with the 256k size issue without
knowing it when testing on different baselines in earlier
commits, but since this is all board specific, a rebase or
reorder to put this commit 1st is of little value.
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
board/sbc8641d/README | 6 +++---
include/configs/sbc8641d.h | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/board/sbc8641d/README b/board/sbc8641d/README
index af180888182d..d07f1ccf7c33 100644
--- a/board/sbc8641d/README
+++ b/board/sbc8641d/README
@@ -3,7 +3,7 @@ Wind River SBC8641D reference board
Created 06/14/2007 Joe Hamman
Copyright 2007, Embedded Specialties, Inc.
-Copyright 2007 Wind River Systemes, Inc.
+Copyright 2007 Wind River Systems, Inc.
-----------------------------
1. Building U-Boot
@@ -43,7 +43,7 @@ c) while on, using static precautions, move JP10 back to the failed image.
d) use "md fff00000" to confirm you are looking at the failed image
e) turn off write protect with "prot off all"
f) get new image, i.e. "tftp 200000 /somepath/u-boot.bin"
-g) erase failed image: "erase FFF00000 FFF3FFFF"
-h) copy in new image: "cp.b 200000 FFF00000 40000"
+g) erase failed image: "erase FFF00000 FFF5FFFF"
+h) copy in new image: "cp.b 200000 FFF00000 60000"
i) ensure new image is written: "md fff00000"
k) power cycle the board and confirm new image works.
diff --git a/include/configs/sbc8641d.h b/include/configs/sbc8641d.h
index 2f3ec2e20088..eed0f4975164 100644
--- a/include/configs/sbc8641d.h
+++ b/include/configs/sbc8641d.h
@@ -243,7 +243,7 @@
#define CONFIG_SYS_GBL_DATA_OFFSET (CONFIG_SYS_INIT_RAM_SIZE - GENERATED_GBL_DATA_SIZE)
#define CONFIG_SYS_INIT_SP_OFFSET CONFIG_SYS_GBL_DATA_OFFSET
-#define CONFIG_SYS_MONITOR_LEN (256 * 1024) /* Reserve 256 kB for Mon */
+#define CONFIG_SYS_MONITOR_LEN (384 * 1024) /* Reserve 384 kB for Mon */
#define CONFIG_SYS_MALLOC_LEN (1024 * 1024) /* Reserved for malloc */
/* Serial Port */
@@ -474,7 +474,7 @@
* Environment
*/
#define CONFIG_ENV_IS_IN_FLASH 1
-#define CONFIG_ENV_ADDR (CONFIG_SYS_MONITOR_BASE + 0x40000)
+#define CONFIG_ENV_ADDR (CONFIG_SYS_MONITOR_BASE + CONFIG_SYS_MONITOR_LEN)
#define CONFIG_ENV_SECT_SIZE 0x20000 /* 128k(one sector) for env */
#define CONFIG_ENV_SIZE 0x2000
--
2.1.0
next prev parent reply other threads:[~2015-10-17 20:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-17 20:40 [U-Boot] [PATCH 0/6] sbc8641d: misc fixes and generic board enablement Paul Gortmaker
2015-10-17 20:40 ` [U-Boot] [PATCH v2 1/6] sbc8641d: enable command line editing Paul Gortmaker
2015-10-20 0:07 ` [U-Boot] [U-Boot,v2,1/6] " Tom Rini
2015-10-17 20:40 ` [U-Boot] [PATCH v2 2/6] sbc8641d: increase malloc pool size to a sane default Paul Gortmaker
2015-10-20 0:07 ` [U-Boot] [U-Boot, v2, " Tom Rini
2015-10-17 20:40 ` [U-Boot] [PATCH v2 3/6] sbc8641d: set proper environment sector size Paul Gortmaker
2015-10-20 0:07 ` [U-Boot] [U-Boot, v2, " Tom Rini
2015-10-17 20:40 ` [U-Boot] [PATCH v2 4/6] sbc8641d: add basic flash setup instructions to README file Paul Gortmaker
2015-10-20 0:07 ` [U-Boot] [U-Boot, v2, " Tom Rini
2015-10-17 20:40 ` [U-Boot] [PATCH v2 5/6] sbc8641d: enable and test CONFIG_SYS_GENERIC_BOARD Paul Gortmaker
2015-10-20 0:07 ` [U-Boot] [U-Boot, v2, " Tom Rini
2015-10-20 14:49 ` Paul Gortmaker
2015-10-17 20:40 ` Paul Gortmaker [this message]
2015-10-20 0:07 ` [U-Boot] [U-Boot, v2, 6/6] sbc8641d: increase monitor size from 256k to 384k Tom Rini
2015-10-17 21:50 ` [U-Boot] [PATCH 0/6] sbc8641d: misc fixes and generic board enablement Tom Rini
2015-10-17 22:50 ` Paul Gortmaker
2015-10-17 23:11 ` Paul Gortmaker
2015-10-17 23:58 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445114431-9524-7-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox