From: Fabio Estevam <festevam@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 04/12] powerpc: Remove __ilog2_u64 and ffs4 from bitops
Date: Sat, 24 Oct 2015 13:26:46 -0200 [thread overview]
Message-ID: <1445700414-28600-4-git-send-email-festevam@gmail.com> (raw)
In-Reply-To: <1445700414-28600-1-git-send-email-festevam@gmail.com>
From: Fabio Estevam <fabio.estevam@freescale.com>
Remove __ilog2_u64 and ffs4 from powerpc bitops to align with the
kernel implementation.
Use the generic __ffs64 instead of a custom powerpc implementation.
Cc: York Sun <yorksun@freescale.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- Use the generic __ffs64 from <linux/bitops.h> (Tom)
arch/powerpc/cpu/mpc83xx/law.c | 5 +++--
arch/powerpc/cpu/mpc85xx/tlb.c | 2 ++
arch/powerpc/cpu/mpc8xxx/law.c | 5 +++--
arch/powerpc/include/asm/bitops.h | 11 +----------
arch/powerpc/include/asm/fsl_law.h | 1 +
arch/powerpc/include/asm/fsl_srio.h | 2 ++
6 files changed, 12 insertions(+), 14 deletions(-)
diff --git a/arch/powerpc/cpu/mpc83xx/law.c b/arch/powerpc/cpu/mpc83xx/law.c
index 66c88b6..262ae7f 100644
--- a/arch/powerpc/cpu/mpc83xx/law.c
+++ b/arch/powerpc/cpu/mpc83xx/law.c
@@ -9,6 +9,7 @@
#include <common.h>
#include <asm/fsl_law.h>
#include <asm/mmu.h>
+#include <linux/log2.h>
int set_ddr_laws(u64 start, u64 sz, enum law_trgt_if id)
{
@@ -20,7 +21,7 @@ int set_ddr_laws(u64 start, u64 sz, enum law_trgt_if id)
if (start == 0)
start_align = 1ull << (LAW_SIZE_2G + 1);
else
- start_align = 1ull << (ffs64(start) - 1);
+ start_align = 1ull << (__ffs64(start) - 1);
law_sz = min(start_align, sz);
law_sz_enc = __ilog2_u64(law_sz) - 1;
@@ -40,7 +41,7 @@ int set_ddr_laws(u64 start, u64 sz, enum law_trgt_if id)
if (sz) {
start += law_sz;
- start_align = 1ull << (ffs64(start) - 1);
+ start_align = 1ull << (__ffs64(start) - 1);
law_sz = min(start_align, sz);
law_sz_enc = __ilog2_u64(law_sz) - 1;
ecm = &immap->sysconf.ddrlaw[1];
diff --git a/arch/powerpc/cpu/mpc85xx/tlb.c b/arch/powerpc/cpu/mpc85xx/tlb.c
index 8e0508f..cf31eb2 100644
--- a/arch/powerpc/cpu/mpc85xx/tlb.c
+++ b/arch/powerpc/cpu/mpc85xx/tlb.c
@@ -14,6 +14,8 @@
#include <addr_map.h>
#endif
+#include <linux/log2.h>
+
DECLARE_GLOBAL_DATA_PTR;
void invalidate_tlb(u8 tlb)
diff --git a/arch/powerpc/cpu/mpc8xxx/law.c b/arch/powerpc/cpu/mpc8xxx/law.c
index 33d53a8..24baad4 100644
--- a/arch/powerpc/cpu/mpc8xxx/law.c
+++ b/arch/powerpc/cpu/mpc8xxx/law.c
@@ -11,6 +11,7 @@
#include <linux/compiler.h>
#include <asm/fsl_law.h>
#include <asm/io.h>
+#include <linux/log2.h>
DECLARE_GLOBAL_DATA_PTR;
@@ -187,7 +188,7 @@ int set_ddr_laws(u64 start, u64 sz, enum law_trgt_if id)
if (start == 0)
start_align = 1ull << (LAW_SIZE_32G + 1);
else
- start_align = 1ull << (ffs64(start) - 1);
+ start_align = 1ull << (__ffs64(start) - 1);
law_sz = min(start_align, sz);
law_sz_enc = __ilog2_u64(law_sz) - 1;
@@ -202,7 +203,7 @@ int set_ddr_laws(u64 start, u64 sz, enum law_trgt_if id)
if (sz) {
start += law_sz;
- start_align = 1ull << (ffs64(start) - 1);
+ start_align = 1ull << (__ffs64(start) - 1);
law_sz = min(start_align, sz);
law_sz_enc = __ilog2_u64(law_sz) - 1;
diff --git a/arch/powerpc/include/asm/bitops.h b/arch/powerpc/include/asm/bitops.h
index a6bcf3c..14217ef 100644
--- a/arch/powerpc/include/asm/bitops.h
+++ b/arch/powerpc/include/asm/bitops.h
@@ -6,6 +6,7 @@
#define _PPC_BITOPS_H
#include <asm/byteorder.h>
+#include <asm-generic/bitops/__ffs.h>
extern void set_bit(int nr, volatile void *addr);
extern void clear_bit(int nr, volatile void *addr);
@@ -209,16 +210,6 @@ static inline int fls64(__u64 x)
#error BITS_PER_LONG not 32 or 64
#endif
-static inline int __ilog2_u64(u64 n)
-{
- return fls64(n) - 1;
-}
-
-static inline int ffs64(u64 x)
-{
- return __ilog2_u64(x & -x) + 1ull;
-}
-
#ifdef __KERNEL__
/*
diff --git a/arch/powerpc/include/asm/fsl_law.h b/arch/powerpc/include/asm/fsl_law.h
index 3b50487..8e1d22a 100644
--- a/arch/powerpc/include/asm/fsl_law.h
+++ b/arch/powerpc/include/asm/fsl_law.h
@@ -10,6 +10,7 @@
#define _FSL_LAW_H_
#include <asm/io.h>
+#include <linux/log2.h>
#define LAW_EN 0x80000000
diff --git a/arch/powerpc/include/asm/fsl_srio.h b/arch/powerpc/include/asm/fsl_srio.h
index e5aab2a..ec25e16 100644
--- a/arch/powerpc/include/asm/fsl_srio.h
+++ b/arch/powerpc/include/asm/fsl_srio.h
@@ -7,6 +7,8 @@
#ifndef _FSL_SRIO_H_
#define _FSL_SRIO_H_
+#include <linux/log2.h>
+
enum atmu_size {
ATMU_SIZE_4K = 0xb,
ATMU_SIZE_8K,
--
1.9.1
next prev parent reply other threads:[~2015-10-24 15:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-24 15:26 [U-Boot] [PATCH v2 01/13] include: Add log2 header from the kernel Fabio Estevam
2015-10-24 15:26 ` [U-Boot] [PATCH v2 02/13] include: Add generic bitops headers Fabio Estevam
2015-10-25 6:50 ` Jagan Teki
2015-10-25 16:28 ` Fabio Estevam
2015-10-25 16:54 ` Fabio Estevam
2015-10-24 15:26 ` [U-Boot] [PATCH v2 03/12] compat: Remove is_power_of_2() definition Fabio Estevam
2015-10-25 6:53 ` Jagan Teki
2015-10-25 13:11 ` Fabio Estevam
2015-10-24 15:26 ` Fabio Estevam [this message]
2015-10-24 21:16 ` [U-Boot] [PATCH v2 04/12] powerpc: Remove __ilog2_u64 and ffs4 from bitops Tom Rini
2015-10-24 15:26 ` [U-Boot] [PATCH v2 05/12] ARM: bitops: Use the generic bitops headers Fabio Estevam
2015-10-24 21:16 ` Tom Rini
2015-10-24 15:26 ` [U-Boot] [PATCH v2 06/12] x86: " Fabio Estevam
2015-10-24 21:16 ` Tom Rini
2015-10-24 15:26 ` [U-Boot] [PATCH v2 07/12] m68k: " Fabio Estevam
2015-10-24 21:16 ` Tom Rini
2015-10-24 15:26 ` [U-Boot] [PATCH v2 08/12] blackfin: " Fabio Estevam
2015-10-24 21:17 ` Tom Rini
2015-10-24 15:26 ` [U-Boot] [PATCH v2 09/12] sh: " Fabio Estevam
2015-10-24 21:17 ` Tom Rini
2015-10-24 15:26 ` [U-Boot] [PATCH v2 10/12] sandbox: " Fabio Estevam
2015-10-24 21:17 ` Tom Rini
2015-10-24 15:26 ` [U-Boot] [PATCH v2 11/12] spi: sf_ops: Add SPI protection mechanism from the kernel Fabio Estevam
2015-10-24 23:24 ` Tom Rini
2015-10-24 15:26 ` [U-Boot] [PATCH v2 12/12] spi: Add SPI NOR protection mechanism Fabio Estevam
2015-10-24 23:24 ` Tom Rini
2015-10-25 6:44 ` [U-Boot] [PATCH v2 01/13] include: Add log2 header from the kernel Jagan Teki
2015-10-25 12:51 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445700414-28600-4-git-send-email-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox