From: Ian Campbell <ijc+uboot@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] musb: sunxi: Implement dfu_usb_get_reset()
Date: Sun, 25 Oct 2015 12:40:45 +0000 [thread overview]
Message-ID: <1445776845.28851.5.camel@hellion.org.uk> (raw)
In-Reply-To: <20151025124630.68a2f2e6@lilith>
On Sun, 2015-10-25 at 12:46 +0100, Albert ARIBAUD wrote:
> > > +static u8 last_int_usb;
> > > +
> > > +bool dfu_usb_get_reset(void)
> > > +{
> > > + return !!(last_int_usb & MUSB_INTR_RESET);
> >
> > The !! is not needed.
>
> Except if you want to be sure that you return 0 or 1 rather than 0 or
> (1 << something).
Doesn't the bool return type already cause that to happen? (from the
PoV of the caller@least)
Ian.
next prev parent reply other threads:[~2015-10-25 12:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-25 4:44 [U-Boot] [PATCH 0/2] Enable DFU for RAM on Allwinner devices Siarhei Siamashka
2015-10-25 4:44 ` [U-Boot] [PATCH 1/2] sunxi: Enable DFU for RAM Siarhei Siamashka
2015-11-20 15:21 ` [U-Boot] [U-Boot,1/2] " Hans de Goede
2015-10-25 4:44 ` [U-Boot] [PATCH 2/2] musb: sunxi: Implement dfu_usb_get_reset() Siarhei Siamashka
2015-10-25 11:00 ` Marek Vasut
2015-10-25 11:46 ` Albert ARIBAUD
2015-10-25 12:40 ` Ian Campbell [this message]
2015-10-25 13:22 ` Albert ARIBAUD
2015-10-25 13:29 ` Marek Vasut
2015-10-25 14:46 ` Siarhei Siamashka
2015-10-25 16:08 ` Marek Vasut
2015-10-25 19:24 ` Ian Campbell
2015-10-25 20:48 ` Siarhei Siamashka
2015-10-25 19:22 ` Ian Campbell
2015-10-25 21:16 ` Albert ARIBAUD
2015-10-26 10:07 ` Ian Campbell
2015-10-26 11:32 ` Albert ARIBAUD
2015-10-25 14:55 ` Siarhei Siamashka
2015-10-25 16:09 ` Marek Vasut
2015-10-25 21:19 ` Albert ARIBAUD
2015-10-26 11:18 ` [U-Boot] [PATCH 0/2] Enable DFU for RAM on Allwinner devices Piotr Król
2015-10-27 4:31 ` Siarhei Siamashka
2015-10-27 23:27 ` Piotr Król
2015-10-28 4:49 ` Siarhei Siamashka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445776845.28851.5.camel@hellion.org.uk \
--to=ijc+uboot@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox