[U-Boot] [PATCH][v2] mpc85xx/u-boot*.lds: remove _GLOBAL_OFFSET_TABLE_ definition

Joakim Tjernlund
2015-11-02T16:17:01Z

On Fri, 2015-10-30 at 10:12 -0700, York Sun wrote:
>
> On 10/24/2015 10:02 PM, Prabhakar Kushwaha wrote:
> > From: Zhenhua Luo <zhenhua.luo@freescale.com>
> >
> > In binutils-2.25, the _GLOBAL_OFFSET_TABLE_ symbols defined by PROVIDE in
> > u-boot.lds overrides the linker built-in symbols
> > (https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;
> > h=b893397a4b1316610f49819344817715e4305de9),

hmm, what was the reson for this change in binutils? As I recall, PROVIDE should
only add a symbol when there is none and now binutils just ignores this, strange.

> > so the linker is treating _GLOBAL_OFFSET_TABLE_ as a definition into the
> > .reloc section.

Yes, where do you want it instead? what is the difference with/without PROVIDE?

> >
> > To align with the change of binutils-2.25, the _GLOBAL_OFFSET_TABLE_ symbol
> > should not be defined in sections, and the symbols in linker generated .got
> > section should be used(https://sourceware.org/ml/binutils/2008-09/
> > msg00122.html)
> > Fixed the following build errors with binutils-2.25:
> > > powerpc-poky-linux-gnuspe-ld.bfd: _GLOBAL_OFFSET_TABLE_ not defined in
> > linker created .got
> >
> > Signed-off-by: Zhenhua Luo <zhenhua.luo@freescale.com>
> > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> > ---
> > Changes for v2: Updated Subject
> >
>
> Prabhakar/Zhenghua,
>
> Have you addressed Tom's comment (on rev 1 patch)? Quote, "What happens when we
> use older binutils? I'd like some run-time testing too please".
>
> York
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot