From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Date: Mon, 16 Nov 2015 22:15:46 +0000
Subject: [U-Boot] [PATCH] arc: add stubs for map_physmem() and
	unmap_physmem()
In-Reply-To: <CAPnjgZ02cj8ik1xeoQB-44jxNhxTvezYAGC-0qvUbz3KgDLCOg@mail.gmail.com>
References: <1447365381-16342-1-git-send-email-abrodkin@synopsys.com>
 <CAPnjgZ09v4ZHMnFcBQypTW0OM6sZ6bzMkbNqAA-g8-w=VQd=VQ@mail.gmail.com>
 <1447438996.5262.12.camel@synopsys.com>
 <CAPnjgZ2-kN6JJCLE1pF+CsZVJABAAqe-4ssXWB=pNsks0MvpLw@mail.gmail.com>
 <1447681662.6240.19.camel@synopsys.com>
 <CAPnjgZ02cj8ik1xeoQB-44jxNhxTvezYAGC-0qvUbz3KgDLCOg@mail.gmail.com>
Message-ID: <1447712146.6240.41.camel@synopsys.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Stephen,

On Mon, 2015-11-16 at 14:08 -0700, Simon Glass wrote:
> Hi,
> 
> On 16 November 2015 at 06:47, Alexey Brodkin
> <Alexey.Brodkin@synopsys.com> wrote:
> > Hi Simon, Stephen,
> > 
> > On Fri, 2015-11-13 at 19:03 -0700, Simon Glass wrote:
> > > On 13 November 2015 at 11:23, Alexey Brodkin
> > > <Alexey.Brodkin@synopsys.com> wrote:
> > > > Hi Simon,
> > > > 
> > > > On Fri, 2015-11-13 at 11:14 -0700, Simon Glass wrote:
> > > > > Hi Alexey,
> > > > > 
> > > > > On 12 November 2015 at 14:56, Alexey Brodkin
> > > > > <Alexey.Brodkin@synopsys.com> wrote:
> > 
> > [snip]
> > 
> > > > > > Up until now there was no need in those stubs.
> > > > > > 
> > > > > > But since following commit compilation of U-Boot on ARC is broken:
> > > > > > ------------------------>8----------------------
> > > > > > commit 7861204c9af7fec1ea9b41541c272516235a6c93
> > > > > > Author: Stephen Warren <swarren@wwwdotorg.org>
> > > > > > Date:   Sat Oct 3 13:56:46 2015 -0600
> > > > > > 
> > > > > >     itest: make memory access work under sandbox
> > > > > > 
> > > > > >     itest accesses memory, and hence must map/unmap it. Without doing so, it
> > > > > >     accesses invalid addresses and crashes.
> > > > > > 
> > > > > >     Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
> > > > > >     Reviewed-by: Simon Glass <sjg@chromium.org>
> > > > > > ------------------------>8----------------------
> > > > > > 
> > > > > > That's because CMD_ITEST is enabled by default in common/Kconfig and now
> > > > > > map_physmem()/unmap_physmem() is used there.
> > > > > > 
> > > > > > So this patch adds missing stubs for ARC.
> > > > > > 
> > > > > > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > > > > > Cc: Stephen Warren <swarren@wwwdotorg.org>
> > > > > > Cc: Simon Glass <sjg@chromium.org>
> > > > > > ---
> > > 
> > > Reviewed-by: Simon Glass <sjg@chromium.org>
> > 
> > So should I move map_physmem()/unmap_physmem() in generic header and include
> > it in asm/io.h for every arch (as suggested by Stephen) or for starters I
> > may have stubs for ARC and once this patch is accepted do clean-up for
> > all arches at once?
> 
> Either is fine with me. If you do a shared file it should be in
> include/asm-generic I think.

Please let me know if you're fine as well with local patch for ARC
for starters. This quick fix is really necessary because as of today
U-Boot for ARC couldn't be built at all from current master branch.

-Alexey