public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ian Campbell <ijc+uboot@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi: Set AHB1 clock to PLL6/3 on all clock_sun6i.h using SoCs
Date: Sat, 21 Nov 2015 15:48:29 +0000	[thread overview]
Message-ID: <1448120909.13926.3.camel@hellion.org.uk> (raw)
In-Reply-To: <1448044323-4447-1-git-send-email-hdegoede@redhat.com>

On Fri, 2015-11-20 at 19:32 +0100, Hans de Goede wrote:
> According to the datasheets the max speed of AHB1 is 276 MHz, so
> setting it to PLL6 / 3 which gives us 200MHz everywhere is fine,
> and gives us a nice speed-up in certain workloads.
> 
> Suggested-by: Chen-Yu Tsai <wens@csie.org>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

I suppose you've tested this on at least one such board? In that case:
Acked-by: Ian Campbell <ijc@hellion.org.uk>

> ---
>  arch/arm/include/asm/arch-sunxi/clock_sun6i.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/arm/include/asm/arch-sunxi/clock_sun6i.h
> b/arch/arm/include/asm/arch-sunxi/clock_sun6i.h
> index 09337a1..5c76275 100644
> --- a/arch/arm/include/asm/arch-sunxi/clock_sun6i.h
> +++ b/arch/arm/include/asm/arch-sunxi/clock_sun6i.h
> @@ -220,11 +220,7 @@ struct sunxi_ccm_reg {
>  #define CCM_PLL11_CTRL_UPD		(0x1 << 30)
>  #define CCM_PLL11_CTRL_EN		(0x1 << 31)
>  
> -#if defined CONFIG_MACH_SUN8I_H3
>  #define AHB1_ABP1_DIV_DEFAULT		0x00003180 /*
> AHB1=PLL6/3,APB1=AHB1/2 */
> -#else
> -#define AHB1_ABP1_DIV_DEFAULT		0x00002020 /*
> AHB1=AXI/4, APB1=AHB1/2 */
> -#endif
>  
>  #define AXI_GATE_OFFSET_DRAM		0
>  

  reply	other threads:[~2015-11-21 15:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20 18:32 [U-Boot] [PATCH] sunxi: Set AHB1 clock to PLL6/3 on all clock_sun6i.h using SoCs Hans de Goede
2015-11-21 15:48 ` Ian Campbell [this message]
2015-11-22 14:14   ` Chen-Yu Tsai
2015-11-22 15:40     ` Hans de Goede
2015-11-23  6:47       ` Chen-Yu Tsai
2015-11-23  8:34         ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448120909.13926.3.camel@hellion.org.uk \
    --to=ijc+uboot@hellion.org.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox