public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ian Campbell <ijc+uboot@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi: Set AHB1 clock to PLL6/3 on all clock_sun6i.h using SoCs
Date: Mon, 23 Nov 2015 08:34:49 +0000	[thread overview]
Message-ID: <1448267689.13926.14.camel@hellion.org.uk> (raw)
In-Reply-To: <CAGb2v66GmZqMn4hFXYjRHiU7PNGgu6LAH_AJ9DBUFgf69KKiWQ@mail.gmail.com>

On Mon, 2015-11-23 at 14:47 +0800, Chen-Yu Tsai wrote:
> Hi,
> 
> On Sun, Nov 22, 2015 at 11:40 PM, Hans de Goede <hdegoede@redhat.com>
> wrote:
> > Hi,
> >
> > On 22-11-15 15:14, Chen-Yu Tsai wrote:
> >>
> >> On Sat, Nov 21, 2015 at 11:48 PM, Ian Campbell <
> ijc+uboot at hellion.org.uk>
> >> wrote:
> >>>
> >>> On Fri, 2015-11-20 at 19:32 +0100, Hans de Goede wrote:
> >>>>
> >>>> According to the datasheets the max speed of AHB1 is 276 MHz, so
> >>>> setting it to PLL6 / 3 which gives us 200MHz everywhere is fine,
> >>>> and gives us a nice speed-up in certain workloads.
> >>>>
> >>>> Suggested-by: Chen-Yu Tsai <wens@csie.org>
> >>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >>>
> >>>
> >>> I suppose you've tested this on at least one such board? In that
> case:
> >>> Acked-by: Ian Campbell <ijc@hellion.org.uk>
> >>
> >>
> >> I've tested this on some of my boards. It works fine on my
> Hummingbird A31
> >> and A23 Q8 tablet. However my Sinlinx SinA33 is giving me kernel
> Oops
> >> which
> >> I haven't looked into yet.
> >
> >
> > Works for me on a q8 A33 tablet. But lets investigate your oops
> before
> > including
> > this in the next pull-req. Thanks for the testing!
> 
> I retested it with a proper clean build, and it works now. No idea
> what
> the oops was about.
> 
> Also tested on my Sinlinx SinA31s. So it now works on all my sun6i
> generation
> boards.
> 
> Tested-by: Chen-Yu Tsai <wens@csie.org>

Good enough for me, my original Ack stands...

> 

      reply	other threads:[~2015-11-23  8:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20 18:32 [U-Boot] [PATCH] sunxi: Set AHB1 clock to PLL6/3 on all clock_sun6i.h using SoCs Hans de Goede
2015-11-21 15:48 ` Ian Campbell
2015-11-22 14:14   ` Chen-Yu Tsai
2015-11-22 15:40     ` Hans de Goede
2015-11-23  6:47       ` Chen-Yu Tsai
2015-11-23  8:34         ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448267689.13926.14.camel@hellion.org.uk \
    --to=ijc+uboot@hellion.org.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox