[U-Boot] [PATCH v1] arm: socfpga: Enable load zImage and Linux DTB from QSPI

[U-Boot] [PATCH v1] arm: socfpga: Enable load zImage and Linux DTB from QSPI

[Chin Liang See]

Adding new environment qspiload which will load zImage and
Linux DTB from serial NOR flash. The default flash offset for
the images as below and they are configurable during run time.

- zImage located at 0xa0000 with assuming file size 6MB
- Linux DTB located at 0x50000 with assuming file size 28kB

Please adjust the file size env var if exceeding the default

Signed-off-by: Chin Liang See <clsee@altera.com>
Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
Cc: Dinh Nguyen <dinh.linux@gmail.com>
Cc: Pavel Machek <pavel@denx.de>
Cc: Marek Vasut <marex@denx.de>
Cc: Stefan Roese <sr@denx.de>
---
 include/configs/socfpga_arria5_socdk.h   | 10 +++++++++-
 include/configs/socfpga_cyclone5_socdk.h | 10 +++++++++-
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/include/configs/socfpga_arria5_socdk.h b/include/configs/socfpga_arria5_socdk.h
index 91ecbf7..0506336 100644
--- a/include/configs/socfpga_arria5_socdk.h
+++ b/include/configs/socfpga_arria5_socdk.h
@@ -77,9 +77,11 @@
 	"ramboot=setenv bootargs " CONFIG_BOOTARGS ";" \
 		"bootm ${loadaddr} - ${fdt_addr}\0" \
 	"bootimage=zImage\0" \
+	"bootimagesize=0x600000\0" \
 	"fdt_addr=100\0" \
 	"fdtimage=socfpga.dtb\0" \
-		"fsloadcmd=ext2load\0" \
+	"fdtimagesize=0x7000\0" \
+	"fsloadcmd=ext2load\0" \
 	"bootm ${loadaddr} - ${fdt_addr}\0" \
 	"mmcroot=/dev/mmcblk0p2\0" \
 	"mmcboot=setenv bootargs " CONFIG_BOOTARGS \
@@ -90,6 +92,12 @@
 		"load mmc 0:1 ${fdt_addr} ${fdtimage}\0" \
 	"qspiroot=/dev/mtdblock0\0" \
 	"qspirootfstype=jffs2\0" \
+	"qspiloadcs=0\0" \
+	"qspibootimageaddr=0xa0000\0" \
+	"qspifdtaddr=0x50000\0" \
+	"qspiload=sf probe ${qspiloadcs};" \
+		"sf read ${loadaddr} ${qspibootimageaddr} ${bootimagesize};" \
+		"sf read ${fdt_addr} ${qspifdtaddr} ${fdtimagesize};\0" \
 	"qspiboot=setenv bootargs " CONFIG_BOOTARGS \
 		" root=${qspiroot} rw rootfstype=${qspirootfstype};"\
 		"bootm ${loadaddr} - ${fdt_addr}\0"
diff --git a/include/configs/socfpga_cyclone5_socdk.h b/include/configs/socfpga_cyclone5_socdk.h
index b5cf393..d7369ee 100644
--- a/include/configs/socfpga_cyclone5_socdk.h
+++ b/include/configs/socfpga_cyclone5_socdk.h
@@ -77,9 +77,11 @@
 	"ramboot=setenv bootargs " CONFIG_BOOTARGS ";" \
 		"bootm ${loadaddr} - ${fdt_addr}\0" \
 	"bootimage=zImage\0" \
+	"bootimagesize=0x600000\0" \
 	"fdt_addr=100\0" \
 	"fdtimage=socfpga.dtb\0" \
-		"fsloadcmd=ext2load\0" \
+	"fdtimagesize=0x7000\0" \
+	"fsloadcmd=ext2load\0" \
 	"bootm ${loadaddr} - ${fdt_addr}\0" \
 	"mmcroot=/dev/mmcblk0p2\0" \
 	"mmcboot=setenv bootargs " CONFIG_BOOTARGS \
@@ -90,6 +92,12 @@
 		"load mmc 0:1 ${fdt_addr} ${fdtimage}\0" \
 	"qspiroot=/dev/mtdblock0\0" \
 	"qspirootfstype=jffs2\0" \
+	"qspiloadcs=0\0" \
+	"qspibootimageaddr=0xa0000\0" \
+	"qspifdtaddr=0x50000\0" \
+	"qspiload=sf probe ${qspiloadcs};" \
+		"sf read ${loadaddr} ${qspibootimageaddr} ${bootimagesize};" \
+		"sf read ${fdt_addr} ${qspifdtaddr} ${fdtimagesize};\0" \
 	"qspiboot=setenv bootargs " CONFIG_BOOTARGS \
 		" root=${qspiroot} rw rootfstype=${qspirootfstype};"\
 		"bootm ${loadaddr} - ${fdt_addr}\0"
-- 
2.2.0


From clsee at ubuntu  Thu Nov 26 01:37:35 2015
From: clsee at ubuntu (clsee)
Date: Thu, 26 Nov 2015 08:37:35 +0800
Subject: [U-Boot] [PATCH] mmc: socfpga_dw_mmc: Move drvsel and smplsel to dts
Message-ID: <1448498255-2505-1-git-send-email-user@ubuntu>

From: Chin Liang See <clsee@altera.com>

socfpga_dw_mmc driver will obtain the drvsel and
smplsel value from device tree instead of definition
in config header file.

Signed-off-by: Chin Liang See <clsee@altera.com>
Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
Cc: Dinh Nguyen <dinh.linux@gmail.com>
Cc: Pavel Machek <pavel@denx.de>
Cc: Marek Vasut <marex@denx.de>
Cc: Stefan Roese <sr@denx.de>
Cc: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Jaehoon Chung <jh80.chung@samsung.com>
---
 arch/arm/dts/socfpga_cyclone5.dtsi |  2 ++
 drivers/mmc/socfpga_dw_mmc.c       | 24 ++++++++++++++++++++++--
 include/configs/socfpga_common.h   |  2 --
 3 files changed, 24 insertions(+), 4 deletions(-)

diff --git a/arch/arm/dts/socfpga_cyclone5.dtsi b/arch/arm/dts/socfpga_cyclone5.dtsi
index de36209..040b236 100644
--- a/arch/arm/dts/socfpga_cyclone5.dtsi
+++ b/arch/arm/dts/socfpga_cyclone5.dtsi
@@ -25,6 +25,8 @@
 			bus-width = <4>;
 			cap-mmc-highspeed;
 			cap-sd-highspeed;
+			drvsel = <3>;
+			smplsel = <0>;
 		};
 
 		sysmgr at ffd08000 {
diff --git a/drivers/mmc/socfpga_dw_mmc.c b/drivers/mmc/socfpga_dw_mmc.c
index 8076761..2cd7a51 100644
--- a/drivers/mmc/socfpga_dw_mmc.c
+++ b/drivers/mmc/socfpga_dw_mmc.c
@@ -19,18 +19,25 @@ static const struct socfpga_clock_manager *clock_manager_base =
 static const struct socfpga_system_manager *system_manager_base =
 		(void *)SOCFPGA_SYSMGR_ADDRESS;
 
+/* socfpga implmentation specific drver private data */
+struct dwmci_socfpga_priv_data {
+	unsigned int drvsel;
+	unsigned int smplsel;
+};
+
 static void socfpga_dwmci_clksel(struct dwmci_host *host)
 {
 	unsigned int drvsel;
 	unsigned int smplsel;
+	struct dwmci_socfpga_priv_data *priv = host->priv;
 
 	/* Disable SDMMC clock. */
 	clrbits_le32(&clock_manager_base->per_pll.en,
 		CLKMGR_PERPLLGRP_EN_SDMMCCLK_MASK);
 
 	/* Configures drv_sel and smpl_sel */
-	drvsel = CONFIG_SOCFPGA_DWMMC_DRVSEL;
-	smplsel = CONFIG_SOCFPGA_DWMMC_SMPSEL;
+	drvsel = priv->drvsel;
+	smplsel = priv->smplsel;
 
 	debug("%s: drvsel %d smplsel %d\n", __func__, drvsel, smplsel);
 	writel(SYSMGR_SDMMC_CTRL_SET(smplsel, drvsel),
@@ -50,8 +57,10 @@ static int socfpga_dwmci_of_probe(const void *blob, int node, const int idx)
 	const unsigned long clk = cm_get_mmc_controller_clk_hz();
 
 	struct dwmci_host *host;
+	struct dwmci_socfpga_priv_data *priv;
 	fdt_addr_t reg_base;
 	int bus_width, fifo_depth;
+	unsigned int drvsel, smplsel;
 
 	if (clk == 0) {
 		printf("DWMMC%d: MMC clock is zero!", idx);
@@ -78,11 +87,19 @@ static int socfpga_dwmci_of_probe(const void *blob, int node, const int idx)
 		return -EINVAL;
 	}
 
+	drvsel = fdtdec_get_uint(blob, node, "drvsel", 0);
+	smplsel = fdtdec_get_uint(blob, node, "smplsel", 0);
+
 	/* Allocate the host */
 	host = calloc(1, sizeof(*host));
 	if (!host)
 		return -ENOMEM;
 
+	/* Allocate the priv */
+	priv = calloc(1, sizeof(*priv));
+	if (!priv)
+		return -ENOMEM;
+
 	host->name = "SOCFPGA DWMMC";
 	host->ioaddr = (void *)reg_base;
 	host->buswidth = bus_width;
@@ -92,6 +109,9 @@ static int socfpga_dwmci_of_probe(const void *blob, int node, const int idx)
 	host->bus_hz = clk;
 	host->fifoth_val = MSIZE(0x2) |
 		RX_WMARK(fifo_depth / 2 - 1) | TX_WMARK(fifo_depth / 2);
+	priv->drvsel = drvsel;
+	priv->smplsel = smplsel;
+	host->priv = priv;
 
 	return add_dwmci(host, host->bus_hz, 400000);
 }
diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h
index f6808b5..b661cc2 100644
--- a/include/configs/socfpga_common.h
+++ b/include/configs/socfpga_common.h
@@ -153,8 +153,6 @@
 #define CONFIG_DWMMC
 #define CONFIG_SOCFPGA_DWMMC
 #define CONFIG_SOCFPGA_DWMMC_FIFO_DEPTH	1024
-#define CONFIG_SOCFPGA_DWMMC_DRVSEL	3
-#define CONFIG_SOCFPGA_DWMMC_SMPSEL	0
 /* FIXME */
 /* using smaller max blk cnt to avoid flooding the limited stack we have */
 #define CONFIG_SYS_MMC_MAX_BLK_COUNT	256	/* FIXME -- SPL only? */
-- 
2.2.0

[U-Boot] [PATCH v1] arm: socfpga: Enable load zImage and Linux DTB from QSPI

[Stefan Roese]

On 26.11.2015 03:32, Chin Liang See wrote:
> Adding new environment qspiload which will load zImage and
> Linux DTB from serial NOR flash. The default flash offset for
> the images as below and they are configurable during run time.
>
> - zImage located at 0xa0000 with assuming file size 6MB
> - Linux DTB located at 0x50000 with assuming file size 28kB
>
> Please adjust the file size env var if exceeding the default
>
> Signed-off-by: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> Cc: Dinh Nguyen <dinh.linux@gmail.com>
> Cc: Pavel Machek <pavel@denx.de>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Stefan Roese <sr@denx.de>
> ---
>   include/configs/socfpga_arria5_socdk.h   | 10 +++++++++-
>   include/configs/socfpga_cyclone5_socdk.h | 10 +++++++++-
>   2 files changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/include/configs/socfpga_arria5_socdk.h b/include/configs/socfpga_arria5_socdk.h
> index 91ecbf7..0506336 100644
> --- a/include/configs/socfpga_arria5_socdk.h
> +++ b/include/configs/socfpga_arria5_socdk.h
> @@ -77,9 +77,11 @@
>   	"ramboot=setenv bootargs " CONFIG_BOOTARGS ";" \
>   		"bootm ${loadaddr} - ${fdt_addr}\0" \
>   	"bootimage=zImage\0" \
> +	"bootimagesize=0x600000\0" \
>   	"fdt_addr=100\0" \
>   	"fdtimage=socfpga.dtb\0" \
> -		"fsloadcmd=ext2load\0" \
> +	"fdtimagesize=0x7000\0" \
> +	"fsloadcmd=ext2load\0" \
>   	"bootm ${loadaddr} - ${fdt_addr}\0" \
>   	"mmcroot=/dev/mmcblk0p2\0" \
>   	"mmcboot=setenv bootargs " CONFIG_BOOTARGS \
> @@ -90,6 +92,12 @@
>   		"load mmc 0:1 ${fdt_addr} ${fdtimage}\0" \
>   	"qspiroot=/dev/mtdblock0\0" \
>   	"qspirootfstype=jffs2\0" \
> +	"qspiloadcs=0\0" \
> +	"qspibootimageaddr=0xa0000\0" \
> +	"qspifdtaddr=0x50000\0" \
> +	"qspiload=sf probe ${qspiloadcs};" \
> +		"sf read ${loadaddr} ${qspibootimageaddr} ${bootimagesize};" \
> +		"sf read ${fdt_addr} ${qspifdtaddr} ${fdtimagesize};\0" \
>   	"qspiboot=setenv bootargs " CONFIG_BOOTARGS \
>   		" root=${qspiroot} rw rootfstype=${qspirootfstype};"\
>   		"bootm ${loadaddr} - ${fdt_addr}\0"
> diff --git a/include/configs/socfpga_cyclone5_socdk.h b/include/configs/socfpga_cyclone5_socdk.h
> index b5cf393..d7369ee 100644
> --- a/include/configs/socfpga_cyclone5_socdk.h
> +++ b/include/configs/socfpga_cyclone5_socdk.h
> @@ -77,9 +77,11 @@
>   	"ramboot=setenv bootargs " CONFIG_BOOTARGS ";" \
>   		"bootm ${loadaddr} - ${fdt_addr}\0" \
>   	"bootimage=zImage\0" \
> +	"bootimagesize=0x600000\0" \
>   	"fdt_addr=100\0" \
>   	"fdtimage=socfpga.dtb\0" \
> -		"fsloadcmd=ext2load\0" \
> +	"fdtimagesize=0x7000\0" \
> +	"fsloadcmd=ext2load\0" \
>   	"bootm ${loadaddr} - ${fdt_addr}\0" \
>   	"mmcroot=/dev/mmcblk0p2\0" \
>   	"mmcboot=setenv bootargs " CONFIG_BOOTARGS \
> @@ -90,6 +92,12 @@
>   		"load mmc 0:1 ${fdt_addr} ${fdtimage}\0" \
>   	"qspiroot=/dev/mtdblock0\0" \
>   	"qspirootfstype=jffs2\0" \
> +	"qspiloadcs=0\0" \
> +	"qspibootimageaddr=0xa0000\0" \
> +	"qspifdtaddr=0x50000\0" \
> +	"qspiload=sf probe ${qspiloadcs};" \
> +		"sf read ${loadaddr} ${qspibootimageaddr} ${bootimagesize};" \
> +		"sf read ${fdt_addr} ${qspifdtaddr} ${fdtimagesize};\0" \
>   	"qspiboot=setenv bootargs " CONFIG_BOOTARGS \
>   		" root=${qspiroot} rw rootfstype=${qspirootfstype};"\
>   		"bootm ${loadaddr} - ${fdt_addr}\0"

I know that you didn't introduce this here, but wouldn't it make
sense to switch to the generic FS commands, "load" and "ls" instead
of using the specific ones "ext2load" etc? Especially since EXT2
is a bit deprecated.

Thanks,
Stefan

[U-Boot] [PATCH v1] arm: socfpga: Enable load zImage and Linux DTB from QSPI

[Chin Liang See]

Hi Stefan,

On Thu, 2015-11-26 at 07:12 +0100, Stefan Roese wrote:
> On 26.11.2015 03:32, Chin Liang See wrote:
> > Adding new environment qspiload which will load zImage and
> > Linux DTB from serial NOR flash. The default flash offset for
> > the images as below and they are configurable during run time.
> > 
> > - zImage located at 0xa0000 with assuming file size 6MB
> > - Linux DTB located at 0x50000 with assuming file size 28kB
> > 
> > Please adjust the file size env var if exceeding the default
> > 
> > Signed-off-by: Chin Liang See <clsee@altera.com>
> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > Cc: Dinh Nguyen <dinh.linux@gmail.com>
> > Cc: Pavel Machek <pavel@denx.de>
> > Cc: Marek Vasut <marex@denx.de>
> > Cc: Stefan Roese <sr@denx.de>
> > ---
> >   include/configs/socfpga_arria5_socdk.h   | 10 +++++++++-
> >   include/configs/socfpga_cyclone5_socdk.h | 10 +++++++++-
> >   2 files changed, 18 insertions(+), 2 deletions(-)
> > 
> > diff --git a/include/configs/socfpga_arria5_socdk.h
> > b/include/configs/socfpga_arria5_socdk.h
> > index 91ecbf7..0506336 100644
> > --- a/include/configs/socfpga_arria5_socdk.h
> > +++ b/include/configs/socfpga_arria5_socdk.h
> > @@ -77,9 +77,11 @@
> >   	"ramboot=setenv bootargs " CONFIG_BOOTARGS ";" \
> >   		"bootm ${loadaddr} - ${fdt_addr}\0" \
> >   	"bootimage=zImage\0" \
> > +	"bootimagesize=0x600000\0" \
> >   	"fdt_addr=100\0" \
> >   	"fdtimage=socfpga.dtb\0" \
> > -		"fsloadcmd=ext2load\0" \
> > +	"fdtimagesize=0x7000\0" \
> > +	"fsloadcmd=ext2load\0" \
> >   	"bootm ${loadaddr} - ${fdt_addr}\0" \
> >   	"mmcroot=/dev/mmcblk0p2\0" \
> >   	"mmcboot=setenv bootargs " CONFIG_BOOTARGS \
> > @@ -90,6 +92,12 @@
> >   		"load mmc 0:1 ${fdt_addr} ${fdtimage}\0" \
> >   	"qspiroot=/dev/mtdblock0\0" \
> >   	"qspirootfstype=jffs2\0" \
> > +	"qspiloadcs=0\0" \
> > +	"qspibootimageaddr=0xa0000\0" \
> > +	"qspifdtaddr=0x50000\0" \
> > +	"qspiload=sf probe ${qspiloadcs};" \
> > +		"sf read ${loadaddr} ${qspibootimageaddr}
> > ${bootimagesize};" \
> > +		"sf read ${fdt_addr} ${qspifdtaddr}
> > ${fdtimagesize};\0" \
> >   	"qspiboot=setenv bootargs " CONFIG_BOOTARGS \
> >   		" root=${qspiroot} rw
> > rootfstype=${qspirootfstype};"\
> >   		"bootm ${loadaddr} - ${fdt_addr}\0"
> > diff --git a/include/configs/socfpga_cyclone5_socdk.h
> > b/include/configs/socfpga_cyclone5_socdk.h
> > index b5cf393..d7369ee 100644
> > --- a/include/configs/socfpga_cyclone5_socdk.h
> > +++ b/include/configs/socfpga_cyclone5_socdk.h
> > @@ -77,9 +77,11 @@
> >   	"ramboot=setenv bootargs " CONFIG_BOOTARGS ";" \
> >   		"bootm ${loadaddr} - ${fdt_addr}\0" \
> >   	"bootimage=zImage\0" \
> > +	"bootimagesize=0x600000\0" \
> >   	"fdt_addr=100\0" \
> >   	"fdtimage=socfpga.dtb\0" \
> > -		"fsloadcmd=ext2load\0" \
> > +	"fdtimagesize=0x7000\0" \
> > +	"fsloadcmd=ext2load\0" \
> >   	"bootm ${loadaddr} - ${fdt_addr}\0" \
> >   	"mmcroot=/dev/mmcblk0p2\0" \
> >   	"mmcboot=setenv bootargs " CONFIG_BOOTARGS \
> > @@ -90,6 +92,12 @@
> >   		"load mmc 0:1 ${fdt_addr} ${fdtimage}\0" \
> >   	"qspiroot=/dev/mtdblock0\0" \
> >   	"qspirootfstype=jffs2\0" \
> > +	"qspiloadcs=0\0" \
> > +	"qspibootimageaddr=0xa0000\0" \
> > +	"qspifdtaddr=0x50000\0" \
> > +	"qspiload=sf probe ${qspiloadcs};" \
> > +		"sf read ${loadaddr} ${qspibootimageaddr}
> > ${bootimagesize};" \
> > +		"sf read ${fdt_addr} ${qspifdtaddr}
> > ${fdtimagesize};\0" \
> >   	"qspiboot=setenv bootargs " CONFIG_BOOTARGS \
> >   		" root=${qspiroot} rw
> > rootfstype=${qspirootfstype};"\
> >   		"bootm ${loadaddr} - ${fdt_addr}\0"
> 
> I know that you didn't introduce this here, but wouldn't it make
> sense to switch to the generic FS commands, "load" and "ls" instead
> of using the specific ones "ext2load" etc? Especially since EXT2
> is a bit deprecated.
> 

Yah, we should be using newer ext command. Let me drop another patch to
use load command. Thanks for raising this.

Thanks
Chin Liang


> Thanks,
> Stefan
> 

[U-Boot] [PATCH v1] arm: socfpga: Enable load zImage and Linux DTB from QSPI

[Pavel Machek]

Hi!

> Adding new environment qspiload which will load zImage and
> Linux DTB from serial NOR flash. The default flash offset for
> the images as below and they are configurable during run time.
> 
> - zImage located at    0xa0000 with assuming file size 6MB
> - Linux DTB located at 0x50000 with assuming file size 28kB

Hmm. Ok, zImage second, so that it can grow. Makes sense. Not sure if
28kB is not a bit small for DTB. I'd reserve at least 64kB.

> Please adjust the file size env var if exceeding the default
> 
> Signed-off-by: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> Cc: Dinh Nguyen <dinh.linux@gmail.com>

Acked-by: Pavel Machek <pavel@denx.de>

Notice that you sent two patches marked "v1".

Thanks,
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[U-Boot] [PATCH v1] arm: socfpga: Enable load zImage and Linux DTB from QSPI

[Chin Liang See]

Hi Pavel,

On Thu, 2015-11-26 at 15:43 +0100, Pavel Machek wrote:
> Hi!
> 
> > Adding new environment qspiload which will load zImage and
> > Linux DTB from serial NOR flash. The default flash offset for
> > the images as below and they are configurable during run time.
> > 
> > - zImage located at    0xa0000 with assuming file size 6MB
> > - Linux DTB located at 0x50000 with assuming file size 28kB
> 
> Hmm. Ok, zImage second, so that it can grow. Makes sense. Not sure if
> 28kB is not a bit small for DTB. I'd reserve at least 64kB.

Yup, it can grow up to 64kB as the size for a sector. We used 28KB
mainly for boot time performance.

> 
> > Please adjust the file size env var if exceeding the default
> > 
> > Signed-off-by: Chin Liang See <clsee@altera.com>
> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > Cc: Dinh Nguyen <dinh.linux@gmail.com>
> 
> Acked-by: Pavel Machek <pavel@denx.de>
> 
> Notice that you sent two patches marked "v1".

Haha too obsess with the -v argument within git format-patch :P

Thanks
Chin Liang

> 
> Thanks,
> 								Pavel

[U-Boot] [PATCH v1] arm: socfpga: Enable load zImage and Linux DTB from QSPI

[Marek Vasut]

On Friday, November 27, 2015 at 02:24:49 AM, Chin Liang See wrote:
> Hi Pavel,
> 
> On Thu, 2015-11-26 at 15:43 +0100, Pavel Machek wrote:
> > Hi!
> > 
> > > Adding new environment qspiload which will load zImage and
> > > Linux DTB from serial NOR flash. The default flash offset for
> > > the images as below and they are configurable during run time.
> > > 
> > > - zImage located at    0xa0000 with assuming file size 6MB
> > > - Linux DTB located at 0x50000 with assuming file size 28kB
> > 
> > Hmm. Ok, zImage second, so that it can grow. Makes sense. Not sure if
> > 28kB is not a bit small for DTB. I'd reserve at least 64kB.
> 
> Yup, it can grow up to 64kB as the size for a sector. We used 28KB
> mainly for boot time performance.

So why don't you use UBI on the QSPI NOR ? That way, you'd secure the
binaries against bitrot as well.

Best regards,
Marek Vasut

[U-Boot] [PATCH v1] arm: socfpga: Enable load zImage and Linux DTB from QSPI

[Chin Liang See]

Hi Marek,

On Fri, 2015-11-27 at 02:27 +0100, Marek Vasut wrote:
> On Friday, November 27, 2015 at 02:24:49 AM, Chin Liang See wrote:
> > Hi Pavel,
> > 
> > On Thu, 2015-11-26 at 15:43 +0100, Pavel Machek wrote:
> > > Hi!
> > > 
> > > > Adding new environment qspiload which will load zImage and
> > > > Linux DTB from serial NOR flash. The default flash offset for
> > > > the images as below and they are configurable during run time.
> > > > 
> > > > - zImage located at    0xa0000 with assuming file size 6MB
> > > > - Linux DTB located at 0x50000 with assuming file size 28kB
> > > 
> > > Hmm. Ok, zImage second, so that it can grow. Makes sense. Not
> > > sure if
> > > 28kB is not a bit small for DTB. I'd reserve at least 64kB.
> > 
> > Yup, it can grow up to 64kB as the size for a sector. We used 28KB
> > mainly for boot time performance.
> 
> So why don't you use UBI on the QSPI NOR ? That way, you'd secure the
> binaries against bitrot as well.
> 

Good point. Its a nice enhancement as we were using raw access for the
images in NAND and QSPI. Will add a new command for fs support once we
enable the ubifs support in socfpga

Thanks
Chin Liang


> Best regards,
> Marek Vasut

[U-Boot] [PATCH v1] arm: socfpga: Enable load zImage and Linux DTB from QSPI

[Marek Vasut]

On Friday, November 27, 2015 at 02:34:27 AM, Chin Liang See wrote:
> Hi Marek,
> 
> On Fri, 2015-11-27 at 02:27 +0100, Marek Vasut wrote:
> > On Friday, November 27, 2015 at 02:24:49 AM, Chin Liang See wrote:
> > > Hi Pavel,
> > > 
> > > On Thu, 2015-11-26 at 15:43 +0100, Pavel Machek wrote:
> > > > Hi!
> > > > 
> > > > > Adding new environment qspiload which will load zImage and
> > > > > Linux DTB from serial NOR flash. The default flash offset for
> > > > > the images as below and they are configurable during run time.
> > > > > 
> > > > > - zImage located at    0xa0000 with assuming file size 6MB
> > > > > - Linux DTB located at 0x50000 with assuming file size 28kB
> > > > 
> > > > Hmm. Ok, zImage second, so that it can grow. Makes sense. Not
> > > > sure if
> > > > 28kB is not a bit small for DTB. I'd reserve at least 64kB.
> > > 
> > > Yup, it can grow up to 64kB as the size for a sector. We used 28KB
> > > mainly for boot time performance.
> > 
> > So why don't you use UBI on the QSPI NOR ? That way, you'd secure the
> > binaries against bitrot as well.
> 
> Good point. Its a nice enhancement as we were using raw access for the
> images in NAND and QSPI. Will add a new command for fs support once we
> enable the ubifs support in socfpga

Why can't this be enabled now then ?

Best regards,
Marek Vasut

[U-Boot] [PATCH v1] arm: socfpga: Enable load zImage and Linux DTB from QSPI

[Chin Liang See]

On Fri, 2015-11-27 at 11:20 +0100, Marek Vasut wrote:
> On Friday, November 27, 2015 at 02:34:27 AM, Chin Liang See wrote:
> > Hi Marek,
> > 
> > On Fri, 2015-11-27 at 02:27 +0100, Marek Vasut wrote:
> > > On Friday, November 27, 2015 at 02:24:49 AM, Chin Liang See
> > > wrote:
> > > > Hi Pavel,
> > > > 
> > > > On Thu, 2015-11-26 at 15:43 +0100, Pavel Machek wrote:
> > > > > Hi!
> > > > > 
> > > > > > Adding new environment qspiload which will load zImage and
> > > > > > Linux DTB from serial NOR flash. The default flash offset
> > > > > > for
> > > > > > the images as below and they are configurable during run
> > > > > > time.
> > > > > > 
> > > > > > - zImage located at    0xa0000 with assuming file size 6MB
> > > > > > - Linux DTB located at 0x50000 with assuming file size 28kB
> > > > > 
> > > > > Hmm. Ok, zImage second, so that it can grow. Makes sense. Not
> > > > > sure if
> > > > > 28kB is not a bit small for DTB. I'd reserve at least 64kB.
> > > > 
> > > > Yup, it can grow up to 64kB as the size for a sector. We used
> > > > 28KB
> > > > mainly for boot time performance.
> > > 
> > > So why don't you use UBI on the QSPI NOR ? That way, you'd secure
> > > the
> > > binaries against bitrot as well.
> > 
> > Good point. Its a nice enhancement as we were using raw access for
> > the
> > images in NAND and QSPI. Will add a new command for fs support once
> > we
> > enable the ubifs support in socfpga
> 
> Why can't this be enabled now then ?

Mainly for backward compatibility as customer might have their own
script on programming a blank flash in production. This is the same
where we can do mmc load or a load (with file system).

Thanks
Chin Liang

> 
> Best regards,
> Marek Vasut

[U-Boot] [PATCH v1] arm: socfpga: Enable load zImage and Linux DTB from QSPI

[Marek Vasut]

On Friday, November 27, 2015 at 01:07:23 PM, Chin Liang See wrote:
> On Fri, 2015-11-27 at 11:20 +0100, Marek Vasut wrote:
> > On Friday, November 27, 2015 at 02:34:27 AM, Chin Liang See wrote:
> > > Hi Marek,
> > > 
> > > On Fri, 2015-11-27 at 02:27 +0100, Marek Vasut wrote:
> > > > On Friday, November 27, 2015 at 02:24:49 AM, Chin Liang See
> > > > 
> > > > wrote:
> > > > > Hi Pavel,
> > > > > 
> > > > > On Thu, 2015-11-26 at 15:43 +0100, Pavel Machek wrote:
> > > > > > Hi!
> > > > > > 
> > > > > > > Adding new environment qspiload which will load zImage and
> > > > > > > Linux DTB from serial NOR flash. The default flash offset
> > > > > > > for
> > > > > > > the images as below and they are configurable during run
> > > > > > > time.
> > > > > > > 
> > > > > > > - zImage located at    0xa0000 with assuming file size 6MB
> > > > > > > - Linux DTB located at 0x50000 with assuming file size 28kB
> > > > > > 
> > > > > > Hmm. Ok, zImage second, so that it can grow. Makes sense. Not
> > > > > > sure if
> > > > > > 28kB is not a bit small for DTB. I'd reserve at least 64kB.
> > > > > 
> > > > > Yup, it can grow up to 64kB as the size for a sector. We used
> > > > > 28KB
> > > > > mainly for boot time performance.
> > > > 
> > > > So why don't you use UBI on the QSPI NOR ? That way, you'd secure
> > > > the
> > > > binaries against bitrot as well.
> > > 
> > > Good point. Its a nice enhancement as we were using raw access for
> > > the
> > > images in NAND and QSPI. Will add a new command for fs support once
> > > we
> > > enable the ubifs support in socfpga
> > 
> > Why can't this be enabled now then ?
> 
> Mainly for backward compatibility as customer might have their own
> script on programming a blank flash in production. This is the same
> where we can do mmc load or a load (with file system).

Does that imply that we will have to get stuck in the past because some
random customer of some random company might have a random script somewhere? :)

Best regards,
Marek Vasut

[U-Boot] [PATCH v1] arm: socfpga: Enable load zImage and Linux DTB from QSPI

[Chin Liang See]

On Fri, 2015-11-27 at 13:11 +0100, Marek Vasut wrote:
> On Friday, November 27, 2015 at 01:07:23 PM, Chin Liang See wrote:
> > On Fri, 2015-11-27 at 11:20 +0100, Marek Vasut wrote:
> > > On Friday, November 27, 2015 at 02:34:27 AM, Chin Liang See
> > > wrote:
> > > > Hi Marek,
> > > > 
> > > > On Fri, 2015-11-27 at 02:27 +0100, Marek Vasut wrote:
> > > > > On Friday, November 27, 2015 at 02:24:49 AM, Chin Liang See
> > > > > 
> > > > > wrote:
> > > > > > Hi Pavel,
> > > > > > 
> > > > > > On Thu, 2015-11-26 at 15:43 +0100, Pavel Machek wrote:
> > > > > > > Hi!
> > > > > > > 
> > > > > > > > Adding new environment qspiload which will load zImage
> > > > > > > > and
> > > > > > > > Linux DTB from serial NOR flash. The default flash
> > > > > > > > offset
> > > > > > > > for
> > > > > > > > the images as below and they are configurable during
> > > > > > > > run
> > > > > > > > time.
> > > > > > > > 
> > > > > > > > - zImage located at    0xa0000 with assuming file size
> > > > > > > > 6MB
> > > > > > > > - Linux DTB located at 0x50000 with assuming file size
> > > > > > > > 28kB
> > > > > > > 
> > > > > > > Hmm. Ok, zImage second, so that it can grow. Makes sense.
> > > > > > > Not
> > > > > > > sure if
> > > > > > > 28kB is not a bit small for DTB. I'd reserve at least
> > > > > > > 64kB.
> > > > > > 
> > > > > > Yup, it can grow up to 64kB as the size for a sector. We
> > > > > > used
> > > > > > 28KB
> > > > > > mainly for boot time performance.
> > > > > 
> > > > > So why don't you use UBI on the QSPI NOR ? That way, you'd
> > > > > secure
> > > > > the
> > > > > binaries against bitrot as well.
> > > > 
> > > > Good point. Its a nice enhancement as we were using raw access
> > > > for
> > > > the
> > > > images in NAND and QSPI. Will add a new command for fs support
> > > > once
> > > > we
> > > > enable the ubifs support in socfpga
> > > 
> > > Why can't this be enabled now then ?
> > 
> > Mainly for backward compatibility as customer might have their own
> > script on programming a blank flash in production. This is the same
> > where we can do mmc load or a load (with file system).
> 
> Does that imply that we will have to get stuck in the past because
> some
> random customer of some random company might have a random script
> somewhere? :)
> 

Haha nope, we still need to advance. Just that we are giving choice for
classic and new :)

Thanks
Chin Liang


> Best regards,
> Marek Vasut

[U-Boot] [PATCH v1] arm: socfpga: Enable load zImage and Linux DTB from QSPI

[Marek Vasut]

On Friday, November 27, 2015 at 01:16:19 PM, Chin Liang See wrote:
> On Fri, 2015-11-27 at 13:11 +0100, Marek Vasut wrote:
> > On Friday, November 27, 2015 at 01:07:23 PM, Chin Liang See wrote:
> > > On Fri, 2015-11-27 at 11:20 +0100, Marek Vasut wrote:
> > > > On Friday, November 27, 2015 at 02:34:27 AM, Chin Liang See
> > > > 
> > > > wrote:
> > > > > Hi Marek,
> > > > > 
> > > > > On Fri, 2015-11-27 at 02:27 +0100, Marek Vasut wrote:
> > > > > > On Friday, November 27, 2015 at 02:24:49 AM, Chin Liang See
> > > > > > 
> > > > > > wrote:
> > > > > > > Hi Pavel,
> > > > > > > 
> > > > > > > On Thu, 2015-11-26 at 15:43 +0100, Pavel Machek wrote:
> > > > > > > > Hi!
> > > > > > > > 
> > > > > > > > > Adding new environment qspiload which will load zImage
> > > > > > > > > and
> > > > > > > > > Linux DTB from serial NOR flash. The default flash
> > > > > > > > > offset
> > > > > > > > > for
> > > > > > > > > the images as below and they are configurable during
> > > > > > > > > run
> > > > > > > > > time.
> > > > > > > > > 
> > > > > > > > > - zImage located at    0xa0000 with assuming file size
> > > > > > > > > 6MB
> > > > > > > > > - Linux DTB located at 0x50000 with assuming file size
> > > > > > > > > 28kB
> > > > > > > > 
> > > > > > > > Hmm. Ok, zImage second, so that it can grow. Makes sense.
> > > > > > > > Not
> > > > > > > > sure if
> > > > > > > > 28kB is not a bit small for DTB. I'd reserve at least
> > > > > > > > 64kB.
> > > > > > > 
> > > > > > > Yup, it can grow up to 64kB as the size for a sector. We
> > > > > > > used
> > > > > > > 28KB
> > > > > > > mainly for boot time performance.
> > > > > > 
> > > > > > So why don't you use UBI on the QSPI NOR ? That way, you'd
> > > > > > secure
> > > > > > the
> > > > > > binaries against bitrot as well.
> > > > > 
> > > > > Good point. Its a nice enhancement as we were using raw access
> > > > > for
> > > > > the
> > > > > images in NAND and QSPI. Will add a new command for fs support
> > > > > once
> > > > > we
> > > > > enable the ubifs support in socfpga
> > > > 
> > > > Why can't this be enabled now then ?
> > > 
> > > Mainly for backward compatibility as customer might have their own
> > > script on programming a blank flash in production. This is the same
> > > where we can do mmc load or a load (with file system).
> > 
> > Does that imply that we will have to get stuck in the past because
> > some
> > random customer of some random company might have a random script
> > somewhere? :)
> 
> Haha nope, we still need to advance. Just that we are giving choice for
> classic and new :)

Can you check if we can do both then? With the option to prefer the new one?

Check the attached patch, it should give you an idea how to load files from
UBI/UBIFS on QSPI. It even enables mtdparts for the QSPI, which is cool too.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-FIXME-SoCkit-OpenWRT-tuning.patch
Type: text/x-patch
Size: 6457 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151127/950b314d/attachment.bin>

[U-Boot] [PATCH v1] arm: socfpga: Enable load zImage and Linux DTB from QSPI

[Chin Liang See]

On Fri, 2015-11-27 at 13:26 +0100, Marek Vasut wrote:
> On Friday, November 27, 2015 at 01:16:19 PM, Chin Liang See wrote:
> > On Fri, 2015-11-27 at 13:11 +0100, Marek Vasut wrote:
> > > On Friday, November 27, 2015 at 01:07:23 PM, Chin Liang See
> > > wrote:
> > > > On Fri, 2015-11-27 at 11:20 +0100, Marek Vasut wrote:
> > > > > On Friday, November 27, 2015 at 02:34:27 AM, Chin Liang See
> > > > > 
> > > > > wrote:
> > > > > > Hi Marek,
> > > > > > 
> > > > > > On Fri, 2015-11-27 at 02:27 +0100, Marek Vasut wrote:
> > > > > > > On Friday, November 27, 2015 at 02:24:49 AM, Chin Liang
> > > > > > > See
> > > > > > > 
> > > > > > > wrote:
> > > > > > > > Hi Pavel,
> > > > > > > > 
> > > > > > > > On Thu, 2015-11-26 at 15:43 +0100, Pavel Machek wrote:
> > > > > > > > > Hi!
> > > > > > > > > 
> > > > > > > > > > Adding new environment qspiload which will load
> > > > > > > > > > zImage
> > > > > > > > > > and
> > > > > > > > > > Linux DTB from serial NOR flash. The default flash
> > > > > > > > > > offset
> > > > > > > > > > for
> > > > > > > > > > the images as below and they are configurable
> > > > > > > > > > during
> > > > > > > > > > run
> > > > > > > > > > time.
> > > > > > > > > > 
> > > > > > > > > > - zImage located at    0xa0000 with assuming file
> > > > > > > > > > size
> > > > > > > > > > 6MB
> > > > > > > > > > - Linux DTB located at 0x50000 with assuming file
> > > > > > > > > > size
> > > > > > > > > > 28kB
> > > > > > > > > 
> > > > > > > > > Hmm. Ok, zImage second, so that it can grow. Makes
> > > > > > > > > sense.
> > > > > > > > > Not
> > > > > > > > > sure if
> > > > > > > > > 28kB is not a bit small for DTB. I'd reserve at least
> > > > > > > > > 64kB.
> > > > > > > > 
> > > > > > > > Yup, it can grow up to 64kB as the size for a sector.
> > > > > > > > We
> > > > > > > > used
> > > > > > > > 28KB
> > > > > > > > mainly for boot time performance.
> > > > > > > 
> > > > > > > So why don't you use UBI on the QSPI NOR ? That way,
> > > > > > > you'd
> > > > > > > secure
> > > > > > > the
> > > > > > > binaries against bitrot as well.
> > > > > > 
> > > > > > Good point. Its a nice enhancement as we were using raw
> > > > > > access
> > > > > > for
> > > > > > the
> > > > > > images in NAND and QSPI. Will add a new command for fs
> > > > > > support
> > > > > > once
> > > > > > we
> > > > > > enable the ubifs support in socfpga
> > > > > 
> > > > > Why can't this be enabled now then ?
> > > > 
> > > > Mainly for backward compatibility as customer might have their
> > > > own
> > > > script on programming a blank flash in production. This is the
> > > > same
> > > > where we can do mmc load or a load (with file system).
> > > 
> > > Does that imply that we will have to get stuck in the past
> > > because
> > > some
> > > random customer of some random company might have a random script
> > > somewhere? :)
> > 
> > Haha nope, we still need to advance. Just that we are giving choice
> > for
> > classic and new :)
> 
> Can you check if we can do both then? With the option to prefer the
> new one?
> 

Sure as you already give me a jump start :)


> Check the attached patch, it should give you an idea how to load
> files from
> UBI/UBIFS on QSPI. It even enables mtdparts for the QSPI, which is
> cool too.

Cool, thanks for the pointer.

Thanks
Chin Liang

[U-Boot] [PATCH v1] arm: socfpga: Enable load zImage and Linux DTB from QSPI

[Marek Vasut]

On Friday, November 27, 2015 at 02:08:30 PM, Chin Liang See wrote:
> On Fri, 2015-11-27 at 13:26 +0100, Marek Vasut wrote:
> > On Friday, November 27, 2015 at 01:16:19 PM, Chin Liang See wrote:
> > > On Fri, 2015-11-27 at 13:11 +0100, Marek Vasut wrote:
> > > > On Friday, November 27, 2015 at 01:07:23 PM, Chin Liang See
> > > > 
> > > > wrote:
> > > > > On Fri, 2015-11-27 at 11:20 +0100, Marek Vasut wrote:
> > > > > > On Friday, November 27, 2015 at 02:34:27 AM, Chin Liang See
> > > > > > 
> > > > > > wrote:
> > > > > > > Hi Marek,
> > > > > > > 
> > > > > > > On Fri, 2015-11-27 at 02:27 +0100, Marek Vasut wrote:
> > > > > > > > On Friday, November 27, 2015 at 02:24:49 AM, Chin Liang
> > > > > > > > See
> > > > > > > > 
> > > > > > > > wrote:
> > > > > > > > > Hi Pavel,
> > > > > > > > > 
> > > > > > > > > On Thu, 2015-11-26 at 15:43 +0100, Pavel Machek wrote:
> > > > > > > > > > Hi!
> > > > > > > > > > 
> > > > > > > > > > > Adding new environment qspiload which will load
> > > > > > > > > > > zImage
> > > > > > > > > > > and
> > > > > > > > > > > Linux DTB from serial NOR flash. The default flash
> > > > > > > > > > > offset
> > > > > > > > > > > for
> > > > > > > > > > > the images as below and they are configurable
> > > > > > > > > > > during
> > > > > > > > > > > run
> > > > > > > > > > > time.
> > > > > > > > > > > 
> > > > > > > > > > > - zImage located at    0xa0000 with assuming file
> > > > > > > > > > > size
> > > > > > > > > > > 6MB
> > > > > > > > > > > - Linux DTB located at 0x50000 with assuming file
> > > > > > > > > > > size
> > > > > > > > > > > 28kB
> > > > > > > > > > 
> > > > > > > > > > Hmm. Ok, zImage second, so that it can grow. Makes
> > > > > > > > > > sense.
> > > > > > > > > > Not
> > > > > > > > > > sure if
> > > > > > > > > > 28kB is not a bit small for DTB. I'd reserve at least
> > > > > > > > > > 64kB.
> > > > > > > > > 
> > > > > > > > > Yup, it can grow up to 64kB as the size for a sector.
> > > > > > > > > We
> > > > > > > > > used
> > > > > > > > > 28KB
> > > > > > > > > mainly for boot time performance.
> > > > > > > > 
> > > > > > > > So why don't you use UBI on the QSPI NOR ? That way,
> > > > > > > > you'd
> > > > > > > > secure
> > > > > > > > the
> > > > > > > > binaries against bitrot as well.
> > > > > > > 
> > > > > > > Good point. Its a nice enhancement as we were using raw
> > > > > > > access
> > > > > > > for
> > > > > > > the
> > > > > > > images in NAND and QSPI. Will add a new command for fs
> > > > > > > support
> > > > > > > once
> > > > > > > we
> > > > > > > enable the ubifs support in socfpga
> > > > > > 
> > > > > > Why can't this be enabled now then ?
> > > > > 
> > > > > Mainly for backward compatibility as customer might have their
> > > > > own
> > > > > script on programming a blank flash in production. This is the
> > > > > same
> > > > > where we can do mmc load or a load (with file system).
> > > > 
> > > > Does that imply that we will have to get stuck in the past
> > > > because
> > > > some
> > > > random customer of some random company might have a random script
> > > > somewhere? :)
> > > 
> > > Haha nope, we still need to advance. Just that we are giving choice
> > > for
> > > classic and new :)
> > 
> > Can you check if we can do both then? With the option to prefer the
> > new one?
> 
> Sure as you already give me a jump start :)
> 
> > Check the attached patch, it should give you an idea how to load
> > files from
> > UBI/UBIFS on QSPI. It even enables mtdparts for the QSPI, which is
> > cool too.
> 
> Cool, thanks for the pointer.

Thanks! This really helps.