public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] checkpatch.pl: Fix checkpatch.pl warnings with Perl 5.22
Date: Mon, 30 Nov 2015 10:23:20 +0000	[thread overview]
Message-ID: <1448878997.5176.4.camel@synopsys.com> (raw)
In-Reply-To: <CANr=Z=Zvtd=MNA08thp1-rw2WNqGJx5awSHB7R8sP423o88XJw@mail.gmail.com>

Hi Joe,

On Thu, 2015-09-03 at 15:46 -0500, Joe Hershberger wrote:
> Hi Moritz,
> 
> On Thu, Sep 3, 2015 at 2:25 PM, Moritz Fischer <moritz.fischer@ettus.com> wrote:
> > This patch fixes a bunch of deprecation warings that show up when using
> > checkpatch.pl with Perl 5.22.
> > 
> > Unescaped left brace in regex is deprecated, passed through in regex;
> > marked by <-- HERE in m/\#\s*define.*do\s{ <-- HERE / at
> > ./scripts/checkpatch.pl line 2829.
> > 
> > Unescaped left brace in regex is deprecated, passed through in regex;
> > marked by <-- HERE in m/\(.*\){ <-- HERE / at
> > ./scripts/checkpatch.pl line 3262.
> > 
> > Unescaped left brace in regex is deprecated, passed through in regex;
> > marked by <-- HERE in m/do{ <-- HERE / at
> > ./scripts/checkpatch.pl line 3263.
> > 
> > Unescaped left brace in regex is deprecated, passed through in regex;
> > marked by <-- HERE in m/^\({ <-- HERE / at
> > ./scripts/checkpatch.pl line 3636.
> > 
> > Unescaped left brace in regex is deprecated, passed through in regex;
> > marked by <-- HERE in m/(?^x:
> > 
> > Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
> 
> Please submit this and have it accepted in the Linux tree. We will
> then pull it in here once it is accepted there.

Similar fix is already in Linus' master tree, see
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=4e5d56bdf892e18832a6540b63ebf709966bce2a

Also note:
 [1] That commit from Linux tree won't apply cleanly on U-Boot
     due to a bit different context.
 [2] Even if manually tweaked it looks like it is incomplete:
     ------------------->8-------------------
     )\(.*\).*\s{ <-- HERE /@scripts/checkpatch.pl line 2828.
     ------------------->8-------------------

So with above in mind could you please apply that patch posted by
Moritz?

This fixes checkpatch in Fedora 23 - in current state it is way too noisy.

-Alexey

  reply	other threads:[~2015-11-30 10:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-03 19:25 [U-Boot] [PATCH] checkpatch.pl: Fix checkpatch.pl warnings with Perl 5.22 Moritz Fischer
2015-09-03 19:32 ` Joe Perches
2015-09-03 20:46 ` Joe Hershberger
2015-11-30 10:23   ` Alexey Brodkin [this message]
2015-11-30 15:56     ` Tom Rini
2015-11-30 15:57       ` Alexey Brodkin
2015-11-30 16:02         ` Tom Rini
2015-11-30 16:05           ` Alexey Brodkin
2015-11-30 16:06       ` Joe Perches
2015-11-30 16:37         ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448878997.5176.4.camel@synopsys.com \
    --to=alexey.brodkin@synopsys.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox