From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Brodkin Date: Mon, 30 Nov 2015 16:05:12 +0000 Subject: [U-Boot] [PATCH] checkpatch.pl: Fix checkpatch.pl warnings with Perl 5.22 In-Reply-To: <20151130160214.GU9551@bill-the-cat> References: <1441308335-13518-1-git-send-email-moritz.fischer@ettus.com> <1448878997.5176.4.camel@synopsys.com> <20151130155607.GT9551@bill-the-cat> <1448899032.2903.2.camel@synopsys.com> <20151130160214.GU9551@bill-the-cat> Message-ID: <1448899511.2903.4.camel@synopsys.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, On Mon, 2015-11-30 at 11:02 -0500, Tom Rini wrote: > On Mon, Nov 30, 2015 at 03:57:12PM +0000, Alexey Brodkin wrote: > > Hi Tom, > > > > On Mon, 2015-11-30 at 10:56 -0500, Tom Rini wrote: > > > On Mon, Nov 30, 2015 at 10:23:20AM +0000, Alexey Brodkin wrote: > > > > Hi Joe, > > > > > > > > On Thu, 2015-09-03 at 15:46 -0500, Joe Hershberger wrote: > > > > > Hi Moritz, > > > > > > > > > > On Thu, Sep 3, 2015 at 2:25 PM, Moritz Fischer wrote: > > > > > > This patch fixes a bunch of deprecation warings that show up when using > > > > > > checkpatch.pl with Perl 5.22. > > > > > > > > > > > > Unescaped left brace in regex is deprecated, passed through in regex; > > > > > > marked by <-- HERE in m/\#\s*define.*do\s{ <-- HERE / at > > > > > > ./scripts/checkpatch.pl line 2829. > > > > > > > > > > > > Unescaped left brace in regex is deprecated, passed through in regex; > > > > > > marked by <-- HERE in m/\(.*\){ <-- HERE / at > > > > > > ./scripts/checkpatch.pl line 3262. > > > > > > > > > > > > Unescaped left brace in regex is deprecated, passed through in regex; > > > > > > marked by <-- HERE in m/do{ <-- HERE / at > > > > > > ./scripts/checkpatch.pl line 3263. > > > > > > > > > > > > Unescaped left brace in regex is deprecated, passed through in regex; > > > > > > marked by <-- HERE in m/^\({ <-- HERE / at > > > > > > ./scripts/checkpatch.pl line 3636. > > > > > > > > > > > > Unescaped left brace in regex is deprecated, passed through in regex; > > > > > > marked by <-- HERE in m/(?^x: > > > > > > > > > > > > Signed-off-by: Moritz Fischer > > > > > > > > > > Please submit this and have it accepted in the Linux tree. We will > > > > > then pull it in here once it is accepted there. > > > > > > > > Similar fix is already in Linus' master tree, see > > > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=4e5d56bdf892e18832a6540b63ebf709966bce > > > > 2a > > > > > > > > Also note: > > > > [1] That commit from Linux tree won't apply cleanly on U-Boot > > > > due to a bit different context. > > > > [2] Even if manually tweaked it looks like it is incomplete: > > > > ------------------->8------------------- > > > > )\(.*\).*\s{ <-- HERE /@scripts/checkpatch.pl line 2828. > > > > ------------------->8------------------- > > > > > > > > So with above in mind could you please apply that patch posted by > > > > Moritz? > > > > > > > > This fixes checkpatch in Fedora 23 - in current state it is way too noisy. > > > > > > Maybe we just need to re-sync again? > > > > > > > Do you mean to copy entire checkpatch.pl over from Linux to U-Boot? > > Not quite blindly, we have an intentional change or two (I _think_ the > change for __packed detection / warning was rejected upstream, memory is > hazy) but by and large yes, it's just an import from the kernel anyhow. > I'm fine with that but not sure if I may do it myself - at least I havent's tried it :) Volunteers? -Alexey