From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Date: Tue, 1 Dec 2015 19:08:10 +0000
Subject: [U-Boot] [PATCH v2] axs10x: add support of generic ECHI USB 2.0
 controller
In-Reply-To: <201511301906.36345.marex@denx.de>
References: <1448906005-28161-1-git-send-email-abrodkin@synopsys.com>
 <201511301906.36345.marex@denx.de>
Message-ID: <1448996890.6697.22.camel@synopsys.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Marek,

On Mon, 2015-11-30 at 19:06 +0100, Marek Vasut wrote:
> On Monday, November 30, 2015 at 06:53:25 PM, Alexey Brodkin wrote:
> > This commit adds support of USB 2.0 storage media on AXS10x boards.
> > 
> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > Cc: Marek Vasut <marex@denx.de>
> > Cc: Simon Glass <sjg@chromium.org>
> > ---
> 
> Ad subject -- It's EHCI, not ECHI ;-)

Good catch!

> 
> > diff --git a/configs/axs101_defconfig b/configs/axs101_defconfig
> > index 52d5e2f..a541d9d 100644
> > --- a/configs/axs101_defconfig
> > +++ b/configs/axs101_defconfig
> > @@ -8,6 +8,7 @@ CONFIG_DEFAULT_DEVICE_TREE="axs10x"
> >  CONFIG_SYS_PROMPT="AXS# "
> >  # CONFIG_CMD_IMLS is not set
> >  # CONFIG_CMD_FLASH is not set
> > +CONFIG_CMD_USB=y
> >  # CONFIG_CMD_SETEXPR is not set
> >  CONFIG_CMD_DHCP=y
> >  CONFIG_CMD_PING=y
> > @@ -19,4 +20,9 @@ CONFIG_CLK=y
> >  CONFIG_DM_ETH=y
> >  CONFIG_ETH_DESIGNWARE=y
> >  CONFIG_SYS_NS16550=y
> > +CONFIG_USB=y
> > +CONFIG_DM_USB=y
> > +CONFIG_USB_EHCI_HCD=y
> 
> You don't need EHCI_HCD in defconfig in case EHCI_GENERIC depends on it I think.

Yeah but remember in drivers/usb/host it's not a dependency but conditional branch.
That's why "savedefconfig" (but not me really) put EHCI_HCD here.

-Alexey