* [U-Boot] [PATCH] arm: socfpga: arria10: add additional i2c nodes for Arria10
@ 2015-12-01 16:41 dinguyen at opensource.altera.com
2015-12-01 17:12 ` Stefan Roese
2015-12-02 5:36 ` Chin Liang See
0 siblings, 2 replies; 4+ messages in thread
From: dinguyen at opensource.altera.com @ 2015-12-01 16:41 UTC (permalink / raw)
To: u-boot
From: Dinh Nguyen <dinguyen@opensource.altera.com>
Add remaining 3 I2C base addresses for the Arria10.
Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
---
arch/arm/mach-socfpga/include/mach/base_addr_a10.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/mach-socfpga/include/mach/base_addr_a10.h b/arch/arm/mach-socfpga/include/mach/base_addr_a10.h
index a7056d4..8653dd5 100644
--- a/arch/arm/mach-socfpga/include/mach/base_addr_a10.h
+++ b/arch/arm/mach-socfpga/include/mach/base_addr_a10.h
@@ -29,6 +29,10 @@
#define SOCFPGA_MPUL2_ADDRESS 0xfffff000
#define SOCFPGA_I2C0_ADDRESS 0xffc02200
#define SOCFPGA_I2C1_ADDRESS 0xffc02300
+#define SOCFPGA_I2C2_ADDRESS 0xffc02400
+#define SOCFPGA_I2C3_ADDRESS 0xffc02500
+#define SOCFPGA_I2C4_ADDRESS 0xffc02600
+
#define SOCFPGA_ECC_OCRAM_ADDRESS 0xff8c3000
#define SOCFPGA_UART0_ADDRESS 0xffc02000
--
2.6.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] arm: socfpga: arria10: add additional i2c nodes for Arria10
2015-12-01 16:41 [U-Boot] [PATCH] arm: socfpga: arria10: add additional i2c nodes for Arria10 dinguyen at opensource.altera.com
@ 2015-12-01 17:12 ` Stefan Roese
2015-12-01 18:41 ` Marek Vasut
2015-12-02 5:36 ` Chin Liang See
1 sibling, 1 reply; 4+ messages in thread
From: Stefan Roese @ 2015-12-01 17:12 UTC (permalink / raw)
To: u-boot
On 01.12.2015 17:41, dinguyen at opensource.altera.com wrote:
> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>
> Add remaining 3 I2C base addresses for the Arria10.
>
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> ---
> arch/arm/mach-socfpga/include/mach/base_addr_a10.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/mach-socfpga/include/mach/base_addr_a10.h b/arch/arm/mach-socfpga/include/mach/base_addr_a10.h
> index a7056d4..8653dd5 100644
> --- a/arch/arm/mach-socfpga/include/mach/base_addr_a10.h
> +++ b/arch/arm/mach-socfpga/include/mach/base_addr_a10.h
> @@ -29,6 +29,10 @@
> #define SOCFPGA_MPUL2_ADDRESS 0xfffff000
> #define SOCFPGA_I2C0_ADDRESS 0xffc02200
> #define SOCFPGA_I2C1_ADDRESS 0xffc02300
> +#define SOCFPGA_I2C2_ADDRESS 0xffc02400
> +#define SOCFPGA_I2C3_ADDRESS 0xffc02500
> +#define SOCFPGA_I2C4_ADDRESS 0xffc02600
> +
>
> #define SOCFPGA_ECC_OCRAM_ADDRESS 0xff8c3000
> #define SOCFPGA_UART0_ADDRESS 0xffc02000
Nitpicking, but there seems to be one empty line too much
added above.
Other than this:
Reviewed-by: Stefan Roese <sr@denx.de>
BTW: Is anyone working on DM conversion of this I2C driver? All
those macros for the base addresses would not be needed then.
Thanks,
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] arm: socfpga: arria10: add additional i2c nodes for Arria10
2015-12-01 17:12 ` Stefan Roese
@ 2015-12-01 18:41 ` Marek Vasut
0 siblings, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2015-12-01 18:41 UTC (permalink / raw)
To: u-boot
On Tuesday, December 01, 2015 at 06:12:32 PM, Stefan Roese wrote:
> On 01.12.2015 17:41, dinguyen at opensource.altera.com wrote:
> > From: Dinh Nguyen <dinguyen@opensource.altera.com>
> >
> > Add remaining 3 I2C base addresses for the Arria10.
> >
> > Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> > ---
> >
> > arch/arm/mach-socfpga/include/mach/base_addr_a10.h | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/mach-socfpga/include/mach/base_addr_a10.h
> > b/arch/arm/mach-socfpga/include/mach/base_addr_a10.h index
> > a7056d4..8653dd5 100644
> > --- a/arch/arm/mach-socfpga/include/mach/base_addr_a10.h
> > +++ b/arch/arm/mach-socfpga/include/mach/base_addr_a10.h
> > @@ -29,6 +29,10 @@
> >
> > #define SOCFPGA_MPUL2_ADDRESS 0xfffff000
> > #define SOCFPGA_I2C0_ADDRESS 0xffc02200
> > #define SOCFPGA_I2C1_ADDRESS 0xffc02300
> >
> > +#define SOCFPGA_I2C2_ADDRESS 0xffc02400
> > +#define SOCFPGA_I2C3_ADDRESS 0xffc02500
> > +#define SOCFPGA_I2C4_ADDRESS 0xffc02600
> > +
> >
> > #define SOCFPGA_ECC_OCRAM_ADDRESS 0xff8c3000
> > #define SOCFPGA_UART0_ADDRESS 0xffc02000
>
> Nitpicking, but there seems to be one empty line too much
> added above.
>
> Other than this:
>
> Reviewed-by: Stefan Roese <sr@denx.de>
>
> BTW: Is anyone working on DM conversion of this I2C driver? All
> those macros for the base addresses would not be needed then.
Fixed and applied.
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] arm: socfpga: arria10: add additional i2c nodes for Arria10
2015-12-01 16:41 [U-Boot] [PATCH] arm: socfpga: arria10: add additional i2c nodes for Arria10 dinguyen at opensource.altera.com
2015-12-01 17:12 ` Stefan Roese
@ 2015-12-02 5:36 ` Chin Liang See
1 sibling, 0 replies; 4+ messages in thread
From: Chin Liang See @ 2015-12-02 5:36 UTC (permalink / raw)
To: u-boot
On Tue, 2015-12-01 at 10:41 -0600, dinguyen at opensource.altera.com
wrote:
> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>
> Add remaining 3 I2C base addresses for the Arria10.
>
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> ---
Acked-by: Chin Liang See <clsee@altera.com>
Thanks
Chin Liang
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-02 5:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-01 16:41 [U-Boot] [PATCH] arm: socfpga: arria10: add additional i2c nodes for Arria10 dinguyen at opensource.altera.com
2015-12-01 17:12 ` Stefan Roese
2015-12-01 18:41 ` Marek Vasut
2015-12-02 5:36 ` Chin Liang See
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox