public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jagan Teki <jteki@openedev.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v8 05/14] sf: Use static for file-scope functions
Date: Mon,  7 Dec 2015 00:04:17 +0530	[thread overview]
Message-ID: <1449426866-696-6-git-send-email-jteki@openedev.com> (raw)
In-Reply-To: <1449426866-696-1-git-send-email-jteki@openedev.com>

Use static for file-scope functions and removed
them from header files.

Signed-off-by: Jagan Teki <jteki@openedev.com>
---
 drivers/mtd/spi/sf_internal.h | 18 ------------------
 drivers/mtd/spi/sf_ops.c      | 11 ++++++-----
 2 files changed, 6 insertions(+), 23 deletions(-)

diff --git a/drivers/mtd/spi/sf_internal.h b/drivers/mtd/spi/sf_internal.h
index 670429f..8f586ee 100644
--- a/drivers/mtd/spi/sf_internal.h
+++ b/drivers/mtd/spi/sf_internal.h
@@ -171,12 +171,6 @@ int spi_flash_cmd_write(struct spi_slave *spi, const u8 *cmd, size_t cmd_len,
 /* Flash erase(sectors) operation, support all possible erase commands */
 int spi_flash_cmd_erase_ops(struct spi_flash *flash, u32 offset, size_t len);
 
-/* Read the status register */
-int spi_flash_cmd_read_status(struct spi_flash *flash, u8 *rs);
-
-/* Program the status register */
-int spi_flash_cmd_write_status(struct spi_flash *flash, u8 ws);
-
 /* Lock stmicro spi flash region */
 int stm_lock(struct spi_flash *flash, u32 ofs, size_t len);
 
@@ -186,12 +180,6 @@ int stm_unlock(struct spi_flash *flash, u32 ofs, size_t len);
 /* Check if a stmicro spi flash region is completely locked */
 int stm_is_locked(struct spi_flash *flash, u32 ofs, size_t len);
 
-/* Read the config register */
-int spi_flash_cmd_read_config(struct spi_flash *flash, u8 *rc);
-
-/* Program the config register */
-int spi_flash_cmd_write_config(struct spi_flash *flash, u8 wc);
-
 /* Enable writing on the SPI flash */
 static inline int spi_flash_cmd_write_enable(struct spi_flash *flash)
 {
@@ -205,12 +193,6 @@ static inline int spi_flash_cmd_write_disable(struct spi_flash *flash)
 }
 
 /*
- * Send the read status command to the device and wait for the wip
- * (write-in-progress) bit to clear itself.
- */
-int spi_flash_cmd_wait_ready(struct spi_flash *flash, unsigned long timeout);
-
-/*
  * Used for spi_flash write operation
  * - SPI claim
  * - spi_flash_cmd_write_enable
diff --git a/drivers/mtd/spi/sf_ops.c b/drivers/mtd/spi/sf_ops.c
index 8d6040e..23a6adb 100644
--- a/drivers/mtd/spi/sf_ops.c
+++ b/drivers/mtd/spi/sf_ops.c
@@ -40,7 +40,7 @@ static u8 spi_read_cmds_array[] = {
 	CMD_READ_QUAD_IO_FAST,
 };
 
-int spi_flash_cmd_read_status(struct spi_flash *flash, u8 *rs)
+static int spi_flash_cmd_read_status(struct spi_flash *flash, u8 *rs)
 {
 	int ret;
 	u8 cmd;
@@ -69,7 +69,7 @@ static int read_fsr(struct spi_flash *flash, u8 *fsr)
 	return 0;
 }
 
-int spi_flash_cmd_write_status(struct spi_flash *flash, u8 ws)
+static int spi_flash_cmd_write_status(struct spi_flash *flash, u8 ws)
 {
 	u8 cmd;
 	int ret;
@@ -85,7 +85,7 @@ int spi_flash_cmd_write_status(struct spi_flash *flash, u8 ws)
 }
 
 #if defined(CONFIG_SPI_FLASH_SPANSION) || defined(CONFIG_SPI_FLASH_WINBOND)
-int spi_flash_cmd_read_config(struct spi_flash *flash, u8 *rc)
+static int spi_flash_cmd_read_config(struct spi_flash *flash, u8 *rc)
 {
 	int ret;
 	u8 cmd;
@@ -100,7 +100,7 @@ int spi_flash_cmd_read_config(struct spi_flash *flash, u8 *rc)
 	return 0;
 }
 
-int spi_flash_cmd_write_config(struct spi_flash *flash, u8 wc)
+static int spi_flash_cmd_write_config(struct spi_flash *flash, u8 wc)
 {
 	u8 data[2];
 	u8 cmd;
@@ -238,7 +238,8 @@ static int spi_flash_ready(struct spi_flash *flash)
 	return sr && fsr;
 }
 
-int spi_flash_cmd_wait_ready(struct spi_flash *flash, unsigned long timeout)
+static int spi_flash_cmd_wait_ready(struct spi_flash *flash,
+					unsigned long timeout)
 {
 	int timebase, ret;
 
-- 
1.9.1

  parent reply	other threads:[~2015-12-06 18:34 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-06 18:34 [U-Boot] [PATCH v8 00/14] sf: Tuning spi-flash layer Jagan Teki
2015-12-06 18:34 ` [U-Boot] [PATCH v8 01/14] sf: spi_flash_validate_params => spi_flash_scan Jagan Teki
2015-12-10  1:30   ` Bin Meng
2015-12-10 15:16     ` Jagan Teki
2015-12-11  6:21       ` Bin Meng
2015-12-11  6:31         ` Jagan Teki
2015-12-11  6:44           ` Bin Meng
2015-12-06 18:34 ` [U-Boot] [PATCH v8 02/14] sf: Move spi_flash_scan code to sf_ops Jagan Teki
2015-12-10  1:30   ` Bin Meng
2015-12-06 18:34 ` [U-Boot] [PATCH v8 03/14] sf: Move read_id " Jagan Teki
2015-12-10  1:30   ` Bin Meng
2015-12-06 18:34 ` [U-Boot] [PATCH v8 04/14] sf: probe: Code cleanup Jagan Teki
2015-12-10  1:30   ` Bin Meng
2015-12-06 18:34 ` Jagan Teki [this message]
2015-12-10  1:31   ` [U-Boot] [PATCH v8 05/14] sf: Use static for file-scope functions Bin Meng
2015-12-06 18:34 ` [U-Boot] [PATCH v8 06/14] sf: Fix Makefile Jagan Teki
2015-12-06 18:34 ` [U-Boot] [PATCH v8 07/14] sf: Use simple name for register access functions Jagan Teki
2015-12-10  1:31   ` Bin Meng
2015-12-06 18:34 ` [U-Boot] [PATCH v8 08/14] sf: Flash power up read-only based on idcode0 Jagan Teki
2015-12-10  1:31   ` Bin Meng
2015-12-06 18:34 ` [U-Boot] [PATCH v8 09/14] sf: Remove unneeded header includes Jagan Teki
2015-12-10  1:31   ` Bin Meng
2015-12-06 18:34 ` [U-Boot] [PATCH v8 10/14] sf: Remove unneeded SST_BP and SST_WP Jagan Teki
2015-12-10  1:31   ` Bin Meng
2015-12-06 18:34 ` [U-Boot] [PATCH v8 11/14] sf: ops: Fix missing break on spansion read_bar Jagan Teki
2015-12-09  4:53   ` Simon Glass
2015-12-06 18:34 ` [U-Boot] [PATCH v8 12/14] sf: sf_probe: Remove spi_slave pointer argument Jagan Teki
2015-12-09  4:53   ` Simon Glass
2015-12-10  1:31   ` Bin Meng
2015-12-06 18:34 ` [U-Boot] [PATCH v8 13/14] sf: Use static for file-scope functions Jagan Teki
2015-12-09  4:53   ` Simon Glass
2015-12-10  1:31   ` Bin Meng
2015-12-06 18:34 ` [U-Boot] [PATCH v8 14/14] sf: Rename sf_ops.c to spi-flash.c Jagan Teki
2015-12-09  4:54   ` Simon Glass
2015-12-09 13:48     ` Jagan Teki
2015-12-10  1:31     ` Bin Meng
2015-12-10 15:13       ` Jagan Teki
2015-12-11  6:23         ` Bin Meng
2015-12-11  6:28           ` Jagan Teki
2015-12-11  6:51             ` Bin Meng
2015-12-11  7:02               ` Jagan Teki
2015-12-11 14:34                 ` Simon Glass
2015-12-07 13:14 ` [U-Boot] [PATCH v8 00/14] sf: Tuning spi-flash layer Jagan Teki
2015-12-08 11:54   ` Bin Meng
2015-12-08 10:30 ` Jagan Teki
2015-12-10 15:18   ` Jagan Teki
2015-12-10 15:22 ` Jagan Teki
2015-12-11 16:45 ` Jagan Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449426866-696-6-git-send-email-jteki@openedev.com \
    --to=jteki@openedev.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox