[U-Boot] [PATCH 5/6] arm: socfpga: Introduce common board code

Chin Liang See
2015-12-07T12:53:48Z

On Sat, 2015-12-05 at 21:44 +0100, Marek Vasut wrote:
> The SoCFPGA has reached a point where every single board code become
> the same, since each and every single board is probed equally from
> OF.
> Move the common board code into arch/arm/mach-socfpga/ .
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> ---
> arch/arm/mach-socfpga/Makefile | 2 +-
> arch/arm/mach-socfpga/board.c | 64
> ++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 65 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm/mach-socfpga/board.c
>
> diff --git a/arch/arm/mach-socfpga/Makefile b/arch/arm/mach
> -socfpga/Makefile
> index 316b326..5cf9e23 100644
> --- a/arch/arm/mach-socfpga/Makefile
> +++ b/arch/arm/mach-socfpga/Makefile
> @@ -8,7 +8,7 @@
> #
>
> obj-y += misc.o timer.o reset_manager.o system_manager.o
> clock_manager.o \
> - fpga_manager.o scan_manager.o
> + fpga_manager.o scan_manager.o board.o
> obj-$(CONFIG_SPL_BUILD) += spl.o freeze_controller.o
>
> # QTS-generated config file wrappers
> diff --git a/arch/arm/mach-socfpga/board.c b/arch/arm/mach
> -socfpga/board.c
> new file mode 100644
> index 0000000..a41d089
> --- /dev/null
> +++ b/arch/arm/mach-socfpga/board.c

I am thinking this can go into misc.c instead new file.

> @@ -0,0 +1,64 @@
> +/*
> + * Altera SoCFPGA common board code
> + *
> + * Copyright (C) 2015 Marek Vasut <marex@denx.de>
> + *
> + * SPDX-License-Identifier: GPL-2.0+
> + */
> +
> +#include <common.h>
> +#include <errno.h>
> +#include <asm/arch/reset_manager.h>
> +#include <asm/io.h>
> +
> +#include <usb.h>
> +#include <usb/dwc2_udc.h>
> +
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +void s_init(void) {}
> +
> +/*
> + * Miscellaneous platform dependent initialisations
> + */
> +int board_init(void)

I am thinking we can skip the board_init where it located at original
board folder. If user has unique board specific initialization, they
can still do it there.

Thanks
Chin Liang