From: Chin Liang See <clsee@altera.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/6] arm: socfpga: Introduce common board code
Date: Mon, 7 Dec 2015 20:53:48 +0800 [thread overview]
Message-ID: <1449492828.2213.4.camel@altera.com> (raw)
In-Reply-To: <1449348262-18488-5-git-send-email-marex@denx.de>
On Sat, 2015-12-05 at 21:44 +0100, Marek Vasut wrote:
> The SoCFPGA has reached a point where every single board code become
> the same, since each and every single board is probed equally from
> OF.
> Move the common board code into arch/arm/mach-socfpga/ .
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> ---
> arch/arm/mach-socfpga/Makefile | 2 +-
> arch/arm/mach-socfpga/board.c | 64
> ++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 65 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm/mach-socfpga/board.c
>
> diff --git a/arch/arm/mach-socfpga/Makefile b/arch/arm/mach
> -socfpga/Makefile
> index 316b326..5cf9e23 100644
> --- a/arch/arm/mach-socfpga/Makefile
> +++ b/arch/arm/mach-socfpga/Makefile
> @@ -8,7 +8,7 @@
> #
>
> obj-y += misc.o timer.o reset_manager.o system_manager.o
> clock_manager.o \
> - fpga_manager.o scan_manager.o
> + fpga_manager.o scan_manager.o board.o
> obj-$(CONFIG_SPL_BUILD) += spl.o freeze_controller.o
>
> # QTS-generated config file wrappers
> diff --git a/arch/arm/mach-socfpga/board.c b/arch/arm/mach
> -socfpga/board.c
> new file mode 100644
> index 0000000..a41d089
> --- /dev/null
> +++ b/arch/arm/mach-socfpga/board.c
I am thinking this can go into misc.c instead new file.
> @@ -0,0 +1,64 @@
> +/*
> + * Altera SoCFPGA common board code
> + *
> + * Copyright (C) 2015 Marek Vasut <marex@denx.de>
> + *
> + * SPDX-License-Identifier: GPL-2.0+
> + */
> +
> +#include <common.h>
> +#include <errno.h>
> +#include <asm/arch/reset_manager.h>
> +#include <asm/io.h>
> +
> +#include <usb.h>
> +#include <usb/dwc2_udc.h>
> +
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +void s_init(void) {}
> +
> +/*
> + * Miscellaneous platform dependent initialisations
> + */
> +int board_init(void)
I am thinking we can skip the board_init where it located at original
board folder. If user has unique board specific initialization, they
can still do it there.
Thanks
Chin Liang
next prev parent reply other threads:[~2015-12-07 12:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-05 20:44 [U-Boot] [PATCH 1/6] arm: socfpga: de0_nano: Zap VIRTUAL_TARGET Marek Vasut
2015-12-05 20:44 ` [U-Boot] [PATCH 2/6] arm: socfpga: sockit: " Marek Vasut
2015-12-07 6:14 ` Chin Liang See
2015-12-05 20:44 ` [U-Boot] [PATCH 3/6] arm: socfpga: Switch CONFIG_G_DNL_MANUFACTURER to CONFIG_SYS_VENDOR Marek Vasut
2015-12-07 6:18 ` Chin Liang See
2015-12-05 20:44 ` [U-Boot] [PATCH 4/6] arm: socfpga: Switch CONFIG_HOSTNAME to CONFIG_SYS_BOARD Marek Vasut
2015-12-07 6:25 ` Chin Liang See
2015-12-07 8:36 ` Marek Vasut
2015-12-07 10:01 ` Chin Liang See
2015-12-07 12:01 ` Marek Vasut
2015-12-07 12:08 ` Chin Liang See
2015-12-05 20:44 ` [U-Boot] [PATCH 5/6] arm: socfpga: Introduce common board code Marek Vasut
2015-12-07 12:53 ` Chin Liang See [this message]
2015-12-07 13:23 ` Marek Vasut
2015-12-07 13:32 ` Chin Liang See
2015-12-07 14:23 ` Marek Vasut
2015-12-07 14:29 ` Chin Liang See
2015-12-07 14:37 ` Marek Vasut
2015-12-07 14:56 ` Chin Liang See
2015-12-07 17:46 ` Marek Vasut
2015-12-08 12:34 ` Chin Liang See
2015-12-08 12:57 ` Marek Vasut
2015-12-09 13:46 ` Chin Liang See
2015-12-05 20:44 ` [U-Boot] [PATCH 6/6] arm: socfpga: Drop the board boilerplate Marek Vasut
2015-12-07 12:56 ` Chin Liang See
2015-12-07 13:22 ` Marek Vasut
2015-12-07 13:29 ` Chin Liang See
2015-12-07 6:11 ` [U-Boot] [PATCH 1/6] arm: socfpga: de0_nano: Zap VIRTUAL_TARGET Chin Liang See
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449492828.2213.4.camel@altera.com \
--to=clsee@altera.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox