From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chin Liang See <clsee@altera.com>
Date: Mon, 7 Dec 2015 21:32:04 +0800
Subject: [U-Boot] [PATCH 5/6] arm: socfpga: Introduce common board code
In-Reply-To: <201512071423.26624.marex@denx.de>
References: <1449348262-18488-1-git-send-email-marex@denx.de>
 <1449348262-18488-5-git-send-email-marex@denx.de>
 <1449492828.2213.4.camel@altera.com> <201512071423.26624.marex@denx.de>
Message-ID: <1449495124.2213.11.camel@altera.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Mon, 2015-12-07 at 14:23 +0100, Marek Vasut wrote:
> On Monday, December 07, 2015 at 01:53:48 PM, Chin Liang See wrote:
> 
> [...]
> 
> > > diff --git a/arch/arm/mach-socfpga/board.c b/arch/arm/mach
> > > -socfpga/board.c
> > > new file mode 100644
> > > index 0000000..a41d089
> > > --- /dev/null
> > > +++ b/arch/arm/mach-socfpga/board.c
> > 
> > I am thinking this can go into misc.c instead new file.
> 
> misc.c is bloated with random crap already, I would like to keep
> things
> orderly a little. Let's keep the board code and platform code
> separated.

Initial thinking misc.c should be as lean as possible but that seems
not today. Can consider split them out per features such as usb.c
ethernet.c.

Thanks
Chin Liang
 

> 
> > > @@ -0,0 +1,64 @@
> > > +/*
> > > + * Altera SoCFPGA common board code
> > > + *
> > > + * Copyright (C) 2015 Marek Vasut <marex@denx.de>
> > > + *
> > > + * SPDX-License-Identifier:	GPL-2.0+
> > > + */
> > > +
> > > +#include <common.h>
> > > +#include <errno.h>
> > > +#include <asm/arch/reset_manager.h>
> > > +#include <asm/io.h>
> > > +
> > > +#include <usb.h>
> > > +#include <usb/dwc2_udc.h>
> > > +
> > > +DECLARE_GLOBAL_DATA_PTR;
> > > +
> > > +void s_init(void) {}
> > > +
> > > +/*
> > > + * Miscellaneous platform dependent initialisations
> > > + */
> > > +int board_init(void)
> > 
> > I am thinking we can skip the board_init where it located at
> > original
> > board folder. If user has unique board specific initialization,
> > they
> > can still do it there.
> 
> See my reply to 6/6 .
> 
> Best regards,
> Marek Vasut