From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chin Liang See <clsee@altera.com>
Date: Tue, 8 Dec 2015 20:34:53 +0800
Subject: [U-Boot] [PATCH 5/6] arm: socfpga: Introduce common board code
In-Reply-To: <201512071846.56468.marex@denx.de>
References: <1449348262-18488-1-git-send-email-marex@denx.de>
 <201512071537.24260.marex@denx.de> <1449500161.2213.28.camel@altera.com>
 <201512071846.56468.marex@denx.de>
Message-ID: <1449578093.2143.1.camel@altera.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Mon, 2015-12-07 at 18:46 +0100, Marek Vasut wrote:
> On Monday, December 07, 2015 at 03:56:01 PM, Chin Liang See wrote:
> [...]
> > > The cpu_eth_init() could use improvement, but we don't support
> > > generic
> > > reset handling yet I believe. That's the only thing which is
> > > obviously
> > > visible there, which could be improved.
> > > 
> > > The other thing which might use improvement is the FPGA
> > > registration,
> > > I suspect that might recycle the bindings from current linux
> > > 4.4.x at
> > > some point and move to DT as well.
> > 
> > Nice, looking forward then :)
> > 
> > To further clean-up, I am thinking we can move do_bridge to
> > reset_manager.c too. I can do this if it sound good to you.
> 
> It's not reset-manager specific though, is it ?
> 

All bridges are still release through reset manager except the
fpga2sdram. Since we bridge assert at reset manager, consolidating
these deassert function will make misc.c cleaner.

Thanks
Chin Liang

> Best regards,
> Marek Vasut