public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/7] lib: Split panic functions out of vsprintf.c
Date: Mon, 14 Dec 2015 08:38:27 +0100	[thread overview]
Message-ID: <1450078707.17328.55.camel@collabora.co.uk> (raw)
In-Reply-To: <CAPnjgZ1S=ADntxtKRQiz1evOwinH_-ZfHvf3jTbKJhi2pTx2+A@mail.gmail.com>

On Sun, 2015-12-13 at 20:45 -0700, Simon Glass wrote:
> On 8 December 2015 at 12:38, Simon Glass <sjg@chromium.org> wrote:
> > Hi Scott,
> > 
> > On 8 December 2015 at 12:36, Scott Wood <scottwood@freescale.com>
> > wrote:
> > > On Tue, 2015-12-08 at 12:34 -0700, Simon Glass wrote:
> > > > Hi Sjoerd,
> > > >?
> > OK, so how about this:
> > 
> > > > ifdef CONFIG_SPL_BUILD
> > > > # SPL U-Boot may use full-printf, tiny-printf or none at all
> > 
> > obj-$(CONFIG_SPL_SERIAL_SUPPORT) += panic.o strto.o
> > 
> > > > ifdef CONFIG_USE_TINY_PRINTF
> > obj-$(CONFIG_SPL_SERIAL_SUPPORT) += tiny-printf.o
> > > > else
> > obj-$(CONFIG_SPL_SERIAL_SUPPORT) += vsprintf.o
> > > > endif
> > > > else
> > > > # Main U-Boot always uses the full printf support
> > > > obj-y += vsprintf.o panic.o strto.o
> > > > endif
> 
> It's just a nit so I'm going to leave it as is for now.
> 
> Applied to u-boot-rockchip, thanks!

Heh, i just did an update series last night to send this morning :)
lovely timing.

I'll drop you some patches for these nits later this week while i still
remember them :) (I agree your suggestion here is nicer).


-- 
Sjoerd Simons
Collabora Ltd.

  reply	other threads:[~2015-12-14  7:38 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-04 22:27 [U-Boot] [PATCH 0/7] Switch rockchip firefly to using tiny-printf Sjoerd Simons
2015-12-04 22:27 ` [U-Boot] [PATCH 1/7] spl: use panic_str instead of panic Sjoerd Simons
2015-12-06 16:45   ` Simon Glass
2015-12-08  0:39     ` Simon Glass
2015-12-14  3:44       ` Simon Glass
2015-12-04 22:27 ` [U-Boot] [PATCH 2/7] spl: mmc: Explicitly init mmc struct Sjoerd Simons
2015-12-06 16:45   ` Simon Glass
2015-12-04 22:27 ` [U-Boot] [PATCH 3/7] lib/tiny-printf.c: Implement vprintf Sjoerd Simons
2015-12-08  0:39   ` Simon Glass
2015-12-14  3:44     ` Simon Glass
2015-12-04 22:27 ` [U-Boot] [PATCH 4/7] lib: Split panic functions out of vsprintf.c Sjoerd Simons
2015-12-08  0:39   ` Simon Glass
2015-12-08  7:27     ` Sjoerd Simons
2015-12-08 19:34       ` Simon Glass
2015-12-08 19:36         ` Scott Wood
2015-12-08 19:38           ` Simon Glass
2015-12-14  3:45             ` Simon Glass
2015-12-14  7:38               ` Sjoerd Simons [this message]
2015-12-04 22:27 ` [U-Boot] [PATCH 5/7] lib: split out strtoxxxx " Sjoerd Simons
2015-12-08  0:39   ` Simon Glass
2015-12-08  7:30     ` Sjoerd Simons
2015-12-14  3:45       ` Simon Glass
2015-12-04 22:27 ` [U-Boot] [PATCH 6/7] mmc: mmc: Don't use sprintf when using tiny-printf Sjoerd Simons
2015-12-08  0:40   ` Simon Glass
2015-12-08  7:34     ` Sjoerd Simons
2015-12-14  3:45       ` Simon Glass
2015-12-04 22:27 ` [U-Boot] [PATCH 7/7] rockchip: firefly: Use tiny-printf Sjoerd Simons
2015-12-08  0:40   ` Simon Glass
2015-12-14  3:45     ` Simon Glass
2015-12-05 10:00 ` [U-Boot] [PATCH 0/7] Switch rockchip firefly to using tiny-printf Stefan Roese
2015-12-07 21:43   ` Simon Glass
2015-12-07 21:53     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450078707.17328.55.camel@collabora.co.uk \
    --to=sjoerd.simons@collabora.co.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox