From: Chin Liang See <clsee@altera.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: socfpga: Actually enable L2 cache
Date: Mon, 21 Dec 2015 20:25:03 +0800 [thread overview]
Message-ID: <1450700703.2046.1.camel@altera.com> (raw)
In-Reply-To: <201512211109.10822.marex@denx.de>
On Mon, 2015-12-21 at 11:09 +0100, Marek Vasut wrote:
> On Monday, December 21, 2015 at 10:50:50 AM, Chin Liang See wrote:
[..]
> > Hmmm, here is the function for L2 cache within my development
> > branch.
> > Some of the latency tuning helps based on the benchmark result.
> > Probably you can give it a try, Marek?
> >
> > void v7_outer_cache_enable(void)
> > {
> > /* disable the L2 cache */
> > writel(0, &pl310_regs_base->pl310_ctrl);
> >
> > /* enable BRESP, instruction and data prefetch, full line of
> > zeroes */
> > setbits_le32(&pl310_regs_base->pl310_aux_ctrl,
> > PL310_AUX_CTRL_FULL_LINE_ZERO_MASK |
> > PL310_AUX_CTRL_DATA_PREFETCH_MASK |
> > PL310_AUX_CTRL_INST_PREFETCH_MASK |
> > PL310_AUX_CTRL_EARLY_BRESP_MASK);
> >
> > /* setup tag ram latency */
> > writel(0, &pl310_regs_base->pl310_tag_latency_ctrl);
>
> Are you _sure_ this is a good idea to set the latency to 0x0 ?
>
Actually it still have 1 cycle of latency, just no additional
Thanks
Chin Liang
next prev parent reply other threads:[~2015-12-21 12:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-19 5:58 [U-Boot] [PATCH] arm: socfpga: Actually enable L2 cache Marek Vasut
2015-12-19 10:03 ` Stefan Roese
2015-12-19 10:39 ` Stefan Roese
2015-12-19 16:32 ` Marek Vasut
2015-12-20 2:39 ` Stefan Roese
2015-12-20 2:56 ` Marek Vasut
2015-12-19 16:31 ` Marek Vasut
2015-12-20 2:38 ` Stefan Roese
2015-12-20 2:57 ` Marek Vasut
2015-12-21 9:50 ` Chin Liang See
2015-12-21 10:09 ` Marek Vasut
2015-12-21 12:25 ` Chin Liang See [this message]
2015-12-21 14:19 ` Marek Vasut
2015-12-21 14:37 ` Chin Liang See
2015-12-21 14:39 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450700703.2046.1.camel@altera.com \
--to=clsee@altera.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox