From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chin Liang See <clsee@altera.com>
Date: Mon, 21 Dec 2015 22:39:06 +0800
Subject: [U-Boot] [PATCH] arm: socfpga: Enabling MTD default partitions
In-Reply-To: <201512211524.07680.marex@denx.de>
References: <1450704241-2654-1-git-send-email-clsee@altera.com>
 <201512211524.07680.marex@denx.de>
Message-ID: <1450708746.2046.8.camel@altera.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Mon, 2015-12-21 at 15:24 +0100, Marek Vasut wrote:
> On Monday, December 21, 2015 at 02:23:54 PM, Chin Liang See wrote:
> > Enabling MTD default partitions if its not defined in board
> > configuration file. The layout as below
> > 
> > > u-boot partition for storing SPL image
> 
> But there's also U-Boot image here
> 
> > > env partition for storing U-Boot environment
> 
> There are two partitions for the environment ... I think you can just
> point
> to the layout below and dont need to list it in the commit message.

Yah, let me know that as its much easier to read.

> 
> > > UBI partition for storing kernel image and filesystem
> > > boot partition for backward compatibility / raw binary
> > > rootfs partition for storing filesystem in case boot partition
> > > used
> > 
> > Signed-off-by: Chin Liang See <clsee@altera.com>
> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > Cc: Dinh Nguyen <dinh.linux@gmail.com>
> > Cc: Pavel Machek <pavel@denx.de>
> > Cc: Marek Vasut <marex@denx.de>
> > Cc: Stefan Roese <sr@denx.de>
> > ---
> >  include/configs/socfpga_common.h |   23 +++++++++++++++++++++++
> >  1 files changed, 23 insertions(+), 0 deletions(-)
> > 
> > diff --git a/include/configs/socfpga_common.h
> > b/include/configs/socfpga_common.h index 699e78a..36fc9f0 100644
> > --- a/include/configs/socfpga_common.h
> > +++ b/include/configs/socfpga_common.h
> > @@ -271,6 +271,29 @@ unsigned int
> > cm_get_qspi_controller_clk_hz(void);
> >  #define CONFIG_SYS_CONSOLE_ENV_OVERWRITE
> >  #define CONFIG_ENV_SIZE			4096
> > 
> > +/*
> > + * mtd partitioning for serial NOR flash
> > + *
> > + * device nor0 <ff705000.spi>, # parts = 6
> > + * #: name                size            offset         
> >  mask_flags
> > + * 0: u-boot              0x00100000      0x00000000      0
> > + * 1: env1                0x00040000      0x00100000      0
> > + * 2: env2                0x00040000      0x00140000      0
> > + * 3: UBI                 0x03e80000      0x00180000      0
> > + * 4: boot                0x00e80000      0x00180000      0
> > + * 5: rootfs              0x01000000      0x01000000      0
> > + *
> > + */
> > +#if defined(CONFIG_CMD_SF) || !defined(MTDPARTS_DEFAULT)
> 
> This should be &&, right ?

Yup, will fix that.

> 
> > +#define MTDPARTS_DEFAULT	"mtdparts=ff705000.spi:"\
> 
> Make this ff705000.spi.0 please , otherwise it'd be impossible to
> support 
> multiple SPI NORs on a single QSPI controller (the mtdparts would get
> bound
> to all of them)

Good suggestion, let me update this too

Thanks
Chin Liang

> 
> > +				"1m(u-boot),"		\
> > +				"256k(env1),"		\
> > +				"256k(env2),"		\
> > +				"14848k(boot),"		\
> > +				"16m(rootfs),"		\
> > +				"- at 1536k(UBI)\0"
> > +#endif
> > +
> >  /* Environment for SDMMC boot */
> >  #if defined(CONFIG_ENV_IS_IN_MMC) && !defined(CONFIG_ENV_OFFSET)
> >  #define CONFIG_SYS_MMC_ENV_DEV		0	/* device 0
> > */
> 
> Best regards,
> Marek Vasut